unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 40538@debbugs.gnu.org
Subject: bug#40538: installer: Support uvesafb to install on machines without KMS.
Date: Sun, 12 Apr 2020 00:11:52 +0300	[thread overview]
Message-ID: <20200411211152.GA31526@E5400> (raw)
In-Reply-To: <874ktpspr5.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 5549 bytes --]

On Sat, Apr 11, 2020 at 10:59:10PM +0200, Ludovic Courtès wrote:
> Hi Florian,
> 
> "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
> 
> > Please consider the attached patch.  I chose to go without
> > kernel-module-loader-service (only copying its requirements field)
> > because I do not know how to conditionally extend or start another
> > Shepherd service from an activation snippet.
> >
> > I tested it on QEMU with and without nomodeset.  With a previous Guix
> > System install image, it stayed black when adding a nomodeset kernel
> > parameter.  I will test again on real hardware now, but previous
> > testing of uvesafb-enabled installer images proved successful unlike
> > non-uvesafb images.
> 
> Great.
> 
> > From 85a95ce758384979a0aae3bc9065197c74862b4b Mon Sep 17 00:00:00 2001
> > From: Florian Pelz <pelzflorian@pelzflorian.de>
> > Date: Sat, 11 Apr 2020 18:56:37 +0200
> > Subject: [PATCH] installer: Load uvesafb kernel module.
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > Fixes <https://bugs.gnu.org/40538>.
> >
> > Machines without Kernel Mode Setting (those with many old and current AMD
> > GPUs, SiS GPUs, …) need uvesafb to show the GUI installer.  Some may also need
> > a kernel parameter like nomodeset or vga=793, but we leave that for the user
> > to specify in GRUB.
> >
> > * gnu/system/install.scm (uvesafb-shepherd-service): New procedure.
> > (uvesafb-service-type): New variable.
> > (%uvesafb-service): New variable.
> > (%installation-services): Add it.
> 
> I made the following adjustments.
> 
> I also confirmed that everything goes well in QEMU, but obviously we’ll
> have to test on hardware.
> 
> Let’s publish an RC2 tomorrow so we can get feedback.
> 
> Thank you!
> 
> Ludo’.
> 

> diff --git a/gnu/system/install.scm b/gnu/system/install.scm
> index 73a013bed0..203a085bcd 100644
> --- a/gnu/system/install.scm
> +++ b/gnu/system/install.scm
> @@ -276,6 +276,7 @@ the user's target storage device rather than on the RAM disk."
>  (define %configuration-template-service
>    (service configuration-template-service-type #t))
>  
> +
>  (define %nscd-minimal-caches
>    ;; Minimal in-memory caching policy for nscd.
>    (list (nscd-cache (database 'hosts)
> @@ -295,21 +296,18 @@ the user's target storage device rather than on the RAM disk."
>  ;; support Kernel Mode Setting.  Otherwise kmscon is missing /dev/fb0.
>  (define (uvesafb-shepherd-service _)
>    (list (shepherd-service
> -         (documentation "Load uvesafb.")
> +         (documentation "Load the uvesafb kernel module.")
>           (provision '(uvesafb))
>           (requirement '(file-systems))
> -         (start (with-imported-modules (source-module-closure '((guix utils)))
> -                  #~(begin
> -                      (use-modules (guix utils))
> -                      (lambda ()
> -                        ;; uvesafb is only supported on x86 and x86_64.
> -                        (if (member (%current-system)
> -                                    '("x86_64-linux" "i686-linux"))
> -                            (invoke #+(file-append kmod "/bin/modprobe")
> -                                    "uvesafb"
> -                                    (string-append "v86d=" #$v86d "/sbin/v86d")
> -                                    "mode_option=1024x768")
> -                            #t)))))
> +         (start #~(lambda ()
> +                    ;; uvesafb is only supported on x86 and x86_64.
> +                    (or (not (and (string-suffix? "linux-gnu" %host-type)
> +                                  (or (string-prefix? "x86_64" %host-type)
> +                                      (string-prefix? "i686" %host-type))))
> +                        (invoke #+(file-append kmod "/bin/modprobe")
> +                                "uvesafb"
> +                                (string-append "v86d=" #$v86d "/sbin/v86d")
> +                                "mode_option=1024x768"))))
>           (respawn? #f)
>           (one-shot? #t))))

You don't need both of these lines. If it's a one-shot service then it
shouldn't respawn when it finishes, just when something else needs it
again.

>  
> @@ -319,11 +317,10 @@ the user's target storage device rather than on the RAM disk."
>     (extensions
>      (list (service-extension shepherd-root-service-type
>                               uvesafb-shepherd-service)))
> +   (description
> +    "Load the @code{uvesafb} kernel module with the right options.")
>     (default-value #t)))
>  
> -(define %uvesafb-service
> -  (service uvesafb-service-type))
> -
>  (define %installation-services
>    ;; List of services of the installation system.
>    (let ((motd (plain-file "motd" "
> @@ -451,7 +448,7 @@ Access documentation at any time by pressing Alt-F2.\x1b[0m
>            ;; current AMD GPUs, SiS GPUs, ...) need uvesafb to show the GUI
>            ;; installer.  Some may also need a kernel parameter like nomodeset
>            ;; or vga=793, but we leave that for the user to specify in GRUB.
> -          %uvesafb-service)))
> +          (service uvesafb-service-type))))
>  
>  (define %issue
>    ;; Greeting.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-04-11 21:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 12:54 bug#40538: installer: Support uvesafb to install on machines without KMS pelzflorian (Florian Pelz)
2020-04-10 14:38 ` Ludovic Courtès
2020-04-10 14:58   ` pelzflorian (Florian Pelz)
2020-04-12  6:37     ` Bengt Richter
2020-04-12  8:35       ` Bengt Richter
2020-04-12  8:56       ` pelzflorian (Florian Pelz)
2020-04-11 18:43   ` pelzflorian (Florian Pelz)
2020-04-11 19:03     ` pelzflorian (Florian Pelz)
2020-04-11 20:59     ` Ludovic Courtès
2020-04-11 21:11       ` Efraim Flashner [this message]
2020-04-12  9:23         ` pelzflorian (Florian Pelz)
2020-04-12 14:28           ` Ludovic Courtès
2020-04-12 18:33             ` pelzflorian (Florian Pelz)
2020-04-12  9:02       ` pelzflorian (Florian Pelz)
2020-04-12 11:24         ` pelzflorian (Florian Pelz)
2020-04-12 12:33           ` pelzflorian (Florian Pelz)
2020-04-12 14:48           ` Mathieu Othacehe
2020-04-12 15:30             ` pelzflorian (Florian Pelz)
2020-04-12 17:48               ` Bengt Richter
2020-04-12 18:11                 ` pelzflorian (Florian Pelz)
2020-04-13  5:00                   ` Bengt Richter
2020-04-13  5:37                     ` pelzflorian (Florian Pelz)
2020-04-14  8:57                       ` pelzflorian (Florian Pelz)
2020-04-14  7:24               ` Mathieu Othacehe
2020-04-14  8:16                 ` pelzflorian (Florian Pelz)
2020-04-14  8:34                   ` pelzflorian (Florian Pelz)
2020-04-14 10:09                   ` Ludovic Courtès
2020-04-14 10:28                     ` pelzflorian (Florian Pelz)
2020-04-14 13:14                       ` pelzflorian (Florian Pelz)
2020-04-14 14:12                         ` Ludovic Courtès
2020-04-14 17:09                         ` Mathieu Othacehe
2020-04-14 21:31                           ` pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200411211152.GA31526@E5400 \
    --to=efraim@flashner.co.il \
    --cc=40538@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).