From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pelzflorian (Florian Pelz)" Subject: bug#40493: installer: Provide a way to select multiple keyboard layouts Date: Tue, 7 Apr 2020 23:56:53 +0200 Message-ID: <20200407215653.soqccnapoy32bqwt@pelzflorian.localdomain> References: <87369fmd8d.fsf@gmail.com> <20200407175002.uzjqzm7fdgxftrrn@pelzflorian.localdomain> <87wo6r6ngn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45350) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLwDO-00020W-HM for bug-guix@gnu.org; Tue, 07 Apr 2020 17:57:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLwDN-0001MH-NZ for bug-guix@gnu.org; Tue, 07 Apr 2020 17:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39588) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jLwDN-0001MD-KO for bug-guix@gnu.org; Tue, 07 Apr 2020 17:57:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jLwDN-00066O-Iy for bug-guix@gnu.org; Tue, 07 Apr 2020 17:57:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <87wo6r6ngn.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 40493@debbugs.gnu.org On Tue, Apr 07, 2020 at 10:38:16PM +0200, Ludovic Courtès wrote: > Overall LGTM! Minor suggestion below: I will make a new patch tonight and follow your suggestions. Thank you! The layout toggling worked fine btw, except Arabic layout is called "ara" and not "ar" in base.xml … Regards, Florian