From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Date: Mon, 9 Mar 2020 12:42:42 +0200 Message-ID: <20200309104242.GH1423@E5400> References: <20200308170316.22591-1-mike@rohleder.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9sSKoi6Rw660DLir" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:41229) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBFtE-0000i9-JZ for bug-guix@gnu.org; Mon, 09 Mar 2020 06:44:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBFtC-0007AX-5J for bug-guix@gnu.org; Mon, 09 Mar 2020 06:44:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBFtC-0007AM-1F for bug-guix@gnu.org; Mon, 09 Mar 2020 06:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBFtB-0003rh-V7 for bug-guix@gnu.org; Mon, 09 Mar 2020 06:44:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20200308170316.22591-1-mike@rohleder.de> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: mike@rohleder.de Cc: 25201@debbugs.gnu.org --9sSKoi6Rw660DLir Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable When you add a patch you also need to register it in gnu/local.mk so when we create tarballs it makes sure that all the files are included. On the other hand, since it's really only a 1 line change it would probably be better to do it in the snippet. Can you send a revised patch? (Or let me know why it should be a patch file :) ) On Sun, Mar 08, 2020 at 06:03:16PM +0100, mike@rohleder.de wrote: > Fixes > --- > gnu/packages/patches/mumble-statistic-25201.patch | 13 +++++++++++++ > gnu/packages/telephony.scm | 2 ++ > 2 files changed, 15 insertions(+) > create mode 100644 gnu/packages/patches/mumble-statistic-25201.patch >=20 > diff --git a/gnu/packages/patches/mumble-statistic-25201.patch b/gnu/pack= ages/patches/mumble-statistic-25201.patch > new file mode 100644 > index 0000000000..3cce1826a7 > --- /dev/null > +++ b/gnu/packages/patches/mumble-statistic-25201.patch > @@ -0,0 +1,13 @@ > +changed usage statistic gathering defaults to off. See > + > +--- a/src/mumble/Settings.cpp 2020-03-08 15:29:11.897056953 +0100 > ++++ b/src/mumble/Settings.cpp 2020-03-08 14:11:53.600486793 +0100 > +@@ -298,7 +298,7 @@ > + bHideInTray =3D !isUnityDesktop && QSystemTrayIcon::isSystemTrayAvaila= ble(); > + #endif > + bStateInTray =3D true; > +- bUsage =3D true; > ++ bUsage =3D false; > + bShowUserCount =3D false; > + bChatBarUseSelection =3D false; > + bFilterHidesEmptyChannels =3D true; > diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm > index a645c58562..74991079db 100644 > --- a/gnu/packages/telephony.scm > +++ b/gnu/packages/telephony.scm > @@ -15,6 +15,7 @@ > ;;; Copyright =C2=A9 2019 Jan Wielkiewicz > ;;; Copyright =C2=A9 2019 Ivan Vilata i Balaguer > ;;; Copyright =C2=A9 2020 Brett Gilio > +;;; Copyright =C2=A9 2020 Michael Rohleder > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -404,6 +405,7 @@ address of one of the participants.") > (base32 > "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs")) > (modules '((guix build utils))) > + (patches (search-patches "mumble-statistic-25201.patch")) > (snippet > `(begin > ;; Remove bundled software. Keep arc4random, celt-0.7= =2E0, > --=20 > 2.25.1 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --9sSKoi6Rw660DLir Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5mHZ8ACgkQQarn3Mo9 g1GXoQ//Zk5tXb4gbtBDwvD44R7ItE57YqwO/XeLbks/jGqODUvjFdeeumrqlLeF 7TsNqj7MsfLl/QX0NfMyvvYXQ4PqSrnP9S8+Vjecj60zcDEUAIF7Q6OdzYRwIQTz cO7rc5Brlwrqhe5nfmnNggXqRfqn4lccu5BkBzaJSHS1BF+AGqpEYQrC9BQJXZjX nD4RAJF0q3krw9+gxfVa7uqzDNs+RF61VB5bYdOsIs8/AmwirmlOlHOKZEwvnkxw gHYZYqpTKd3pxS8F+StshI/W0sUZu36WyIFj21on4DPU2nWwiCkdbRHBxHLnY0MF oknCXIEwmYrVF/I3U0F3glEOMCi6xik8Imj52bOgB0wMcCeMpJWPaSaavjOeQCzl YYBS84dVOoowIgdECz9jKRPKV0g2Y08HZD/kcvlN39ip+YYKdPnB5YFRUzzEhpTv MMTI5mM3ItWZDOj5RBBJV5nvrVD1mC7txSUrjRVOMd9bEaiHTQXVO4hGTRVWrXXM MaBaMCzGthKjRTSth1xZHnKaccoEeCvNJTsrb3HsBvJjaRJV3SEEn1pofoBYkZ/p cKr/Kx2HzJ/8A/hW04dKHhGArurcH+FPY04WwoPDRmcXToZyVEQGCjEjHdyoG1SS ErUlDqzSQQALF/UD5N3qgkjUJDKWq8P9dJQ48jVkhbGspXh90ck= =fwlF -----END PGP SIGNATURE----- --9sSKoi6Rw660DLir--