From: Mike Rosset <mike.rosset@gmail.com>
To: 38148@debbugs.gnu.org
Cc: mike.rosset@gmail.com
Subject: bug#38148: [PATCH 4/5] gnu: python-pyqt: Improved qprinter.h substitutition comment
Date: Tue, 14 Jan 2020 03:06:38 -0800 [thread overview]
Message-ID: <20200114110639.14059-3-mike.rosset@gmail.com> (raw)
In-Reply-To: <20200114110639.14059-1-mike.rosset@gmail.com>
* gnu/packages/qt.scm (python-pyqt)[comments]: And python-pyqtwebengine now
uses mkdir-p instead of a system call.
---
gnu/packages/qt.scm | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index fcb297e99c..611c38a443 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -1948,8 +1948,8 @@ module provides support functions to the automatically generated code.")
,@%gnu-build-system-modules)
#:phases
(modify-phases %standard-phases
- ;; When building python-pyqtwebengine <qprinter.h> can not be
- ;; included. Here we substitute the full path to the header in the
+ ;; When building python-pyqtwebengine, <qprinter.h> can not be
+ ;; included. Here we substitute the full path to the header in the
;; store.
(add-before 'configure 'substitute-source
(lambda* (#:key inputs #:allow-other-keys)
@@ -2025,7 +2025,6 @@ contain over 620 classes.")
("qtsvg" ,qtsvg)
("qtdeclarative" ,qtdeclarative)
("qtwebchannel" ,qtwebchannel)
- ("qtwebengine" ,qtwebengine)
("python-pyqt" ,python-pyqt)
("qtwebengine" ,qtwebengine)))
(arguments
@@ -2044,14 +2043,13 @@ contain over 620 classes.")
(last (string-split python #\-)))
(python-major+minor
(string-join
- (take (string-split python-version #\.) 2)
- "."))
+ (take (string-split python-version #\.) 2) "."))
(lib (string-append out "/lib/python"
python-major+minor
"/site-packages/PyQt5"))
(stubs (string-append lib "/PyQt5")))
- (system* "mkdir" "-p" sipdir)
+ (mkdir-p sipdir)
(invoke "python" "configure.py"
"-w"
"--no-dist-info"
@@ -2072,8 +2070,7 @@ contain over 620 classes.")
from pkgutil import extend_path
__path__ = extend_path(__path__, __name__)
")))
- #t)))
- )))
+ #t))))))
(home-page "https://www.riverbankcomputing.com/software/pyqtwebengine/intro")
(synopsis "Python bindings for QtWebEngine")
(description
--
2.24.1
next prev parent reply other threads:[~2020-01-14 11:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 10:05 bug#38148: Guix packages old/broken version of qutebrowser Florian Bruhin
2019-11-09 16:49 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-11-10 2:32 ` Bengt Richter
2020-01-13 10:33 ` bug#38148: [PATCH 1/2] gnu: Add python-pyqtwebengine Mike Rosset
2020-01-13 10:33 ` bug#38148: [PATCH 2/2] gnu: qutebrowser: Update to 1.9.0 Mike Rosset
2020-01-13 14:20 ` Pierre Neidhardt
2020-01-13 18:54 ` Mike Rosset
2020-01-13 19:02 ` Pierre Neidhardt
2020-01-13 10:45 ` bug#38148: [PATCH 1/2] gnu: Add python-pyqtwebengine Mike Rosset
2020-01-13 14:16 ` Pierre Neidhardt
2020-01-14 0:42 ` Mike Rosset
2020-01-14 9:42 ` Pierre Neidhardt
2020-01-14 10:25 ` Mike Rosset
2020-01-14 11:09 ` Mike Rosset
2020-01-15 15:31 ` Pierre Neidhardt
2020-01-15 17:26 ` Mike Rosset
2020-01-14 0:13 ` bug#38148: [PATCH 3/4] gnu: python-pyqt: Improved qprinter.h substitutition comment Mike Rosset
2020-01-14 0:13 ` bug#38148: [PATCH 4/4] gnu: qutebrowser: Improve comment sections Mike Rosset
2020-01-14 11:04 ` bug#38148: [PATCH 1/5] gnu: python-pyqt: Substitute the full path of <qprinter.h> Mike Rosset
2020-01-14 11:06 ` bug#38148: [PATCH 2/5] gnu: Add python-pyqtwebengine Mike Rosset
2020-01-14 11:06 ` bug#38148: [PATCH 3/5] gnu: qutebrowser: Update to 1.9.0 Mike Rosset
2020-01-14 11:06 ` Mike Rosset [this message]
2020-01-14 11:06 ` bug#38148: [PATCH 5/5] gnu: qutebrowser: Improve comment sections Mike Rosset
2020-01-15 20:55 ` bug#38148: Guix packages old/broken version of qutebrowser Ricardo Wurmus
2020-01-16 12:04 ` Florian Bruhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114110639.14059-3-mike.rosset@gmail.com \
--to=mike.rosset@gmail.com \
--cc=38148@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).