From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brice Waegeneire Subject: bug#38524: [PATCH v2] services: dhcp-client: Ignore interfaces that need non-free firmware. Date: Sat, 14 Dec 2019 08:23:26 +0100 Message-ID: <20191214072326.7570-1-brice@waegenei.re> References: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:34326) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ig1mW-00085P-AR for bug-guix@gnu.org; Sat, 14 Dec 2019 02:24:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ig1mV-0007fS-4O for bug-guix@gnu.org; Sat, 14 Dec 2019 02:24:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57164) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ig1mU-0007eZ-Vm for bug-guix@gnu.org; Sat, 14 Dec 2019 02:24:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ig1mT-0004Cg-Qj for bug-guix@gnu.org; Sat, 14 Dec 2019 02:24:01 -0500 In-Reply-To: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> Sender: "Debbugs-submit" Resent-Message-ID: List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 38524@debbugs.gnu.org Fixes bug #38524 (see: https://bugs.gnu.org/38524). * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces that need non-free firmware. --- This patch version contains a link to the issue as Brett asked. gnu/services/networking.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 93d9b6a15e..7a57e33974 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -223,14 +223,14 @@ fe80::1%lo0 apps.facebook.com\n") (define valid? (lambda (interface) (and (arp-network-interface? interface) - (not (loopback-network-interface? interface))))) + (not (loopback-network-interface? interface)) + ;; XXX: Make sure the interfaces are up so that + ;; 'dhclient' can actually send/receive over them. + (false-if-exception + (set-network-interface-up interface))))) (define ifaces (filter valid? (all-network-interface-names))) - ;; XXX: Make sure the interfaces are up so that 'dhclient' can - ;; actually send/receive over them. - (for-each set-network-interface-up ifaces) - (false-if-exception (delete-file #$pid-file)) (let ((pid (fork+exec-command (cons* #$dhclient "-nw" -- 2.19.2