bug#37882: linux-module-build-system doesn't accept make-flags

bug#37882: linux-module-build-system doesn't accept make-flags

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

In (guix build linux-module-build-system) the build phase looks for
make-flags, but 'make-flags' doesn't exist in (guix build-system
linux-module), making it not really supported.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#37882: [PATCH] build-system/linux-module: Accept a #:make-flags keyword.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

* guix/build-system/linux-module.scm (linux-module-build): Accept a
MAKE-FLAGS argument.
<builder>: Pass it on.
---

Efraim,

Is this in any way related to the topic coming up on IRC last week, or just a coincidence?

In any case, I'd written the following simple fix but never merged it because I have yet to meet a module with a legitimate need for it.  It works, though.

Kind regards,

T G-R

 guix/build-system/linux-module.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/build-system/linux-module.scm b/guix/build-system/linux-module.scm
index 6084d22210..dde2423434 100644
--- a/guix/build-system/linux-module.scm
+++ b/guix/build-system/linux-module.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2019 Danny Milosavljevic <dannym@scratchpost.org>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -120,6 +121,7 @@
 (define* (linux-module-build store name inputs
                              #:key
                              (search-paths '())
+                             (make-flags '())
                              (tests? #t)
                              (phases '(@ (guix build linux-module-build-system)
                                          %standard-phases))
@@ -146,6 +148,7 @@
                                            search-paths)
                      #:phases ,phases
                      #:system ,system
+                     #:make-flags ,make-flags
                      #:tests? ,tests?
                      #:outputs %outputs
                      #:inputs %build-inputs)))
-- 
2.23.0

bug#37882: [PATCH] build-system/linux-module: Accept a #:make-flags keyword.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Fri, Oct 25, 2019 at 09:37:31PM +0200, Tobias Geerinckx-Rice via Bug reports for GNU Guix wrote:
> * guix/build-system/linux-module.scm (linux-module-build): Accept a
> MAKE-FLAGS argument.
> <builder>: Pass it on.
> ---
> 
> Efraim,
> 
> Is this in any way related to the topic coming up on IRC last week, or just a coincidence?
> 
> In any case, I'd written the following simple fix but never merged it because I have yet to meet a module with a legitimate need for it.  It works, though.
> 

I thought I had a use-case for it but it turns out I'm pretty sure I
didn't need it in the end. It was more of surprise that it was in one
place and not another.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#37882: [PATCH] build-system/linux-module: Accept a #:make-flags keyword.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

On Sun, 27 Oct 2019 10:18:06 +0200
Efraim Flashner <efraim@flashner.co.il> wrote:

> > In any case, I'd written the following simple fix but never merged it because I have yet to meet a module with a legitimate need for it.  It works, though.
> >   
> It was more of surprise that it was in one
> place and not another.

Whoops.  LGTM anyway!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

bug#37882: [PATCH] build-system/linux-module: Accept a #:make-flags keyword.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

I pushed this patch

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]