From: Julien Lepiller <julien@lepiller.eu>
To: 36375-done@debbugs.gnu.org
Subject: bug#36375: [PATCH] Re: ‘guix package’ should lock the profile
Date: Fri, 8 Nov 2019 22:03:04 +0100 [thread overview]
Message-ID: <20191108220304.7dd04d45@sybil.lepiller.eu> (raw)
In-Reply-To: <871ruif85i.fsf@gnu.org>
Le Fri, 08 Nov 2019 21:03:05 +0100,
Ludovic Courtès <ludo@gnu.org> a écrit :
> Hello!
>
> Julien Lepiller <julien@lepiller.eu> skribis:
>
> > From 71a85b5a8aac6c0bd5a1a4e3b52e409b2112df7a Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien@lepiller.eu>
> > Date: Thu, 7 Nov 2019 21:50:54 +0100
> > Subject: [PATCH 1/2] guix: Add file-locking with no wait.
> >
> > * guix/build/syscalls.scm (with-file-lock/no-wait): New procedure.
> > (lock-file): Take a #:wait? key.
>
> [...]
>
> > From 50c792e155d1207127f10ff0c0360442b7736a64 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien@lepiller.eu>
> > Date: Fri, 25 Oct 2019 21:39:21 +0200
> > Subject: [PATCH 2/2] guix: package: lock profiles when processing
> > them.
> >
> > * guix/scripts/package.scm (process-actions): Get a per-profile
> > lock to prevent concurrent actions on profiles.
> > * tests/guix-package.sh: Add test.
>
> LGTM!
>
> I tested ‘with-file-lock’ on an NFSv3 mount, and ‘F_SETLKW’ is
> correctly implemented, FWIW.
>
> Thank you!
>
> Ludo’.
Pushed as f49e9131889775a74a85c1f9b29f108030337b8b and
b1fb663404894268b5ee92c040f12c52c0bee425.
prev parent reply other threads:[~2019-11-08 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 14:10 bug#36375: ‘guix package’ should lock the profile Ludovic Courtès
2019-10-25 19:44 ` bug#36375: [PATCH] " Julien Lepiller
2019-10-25 21:21 ` Ludovic Courtès
2019-10-25 22:08 ` Julien Lepiller
2019-11-06 13:24 ` Ludovic Courtès
2019-11-07 21:19 ` Julien Lepiller
2019-11-08 20:03 ` Ludovic Courtès
2019-11-08 21:03 ` Julien Lepiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108220304.7dd04d45@sybil.lepiller.eu \
--to=julien@lepiller.eu \
--cc=36375-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).