From: Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
To: 37421@debbugs.gnu.org
Subject: bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d.
Date: Mon, 16 Sep 2019 15:52:28 +0200 [thread overview]
Message-ID: <20190916135228.22045-1-me@tobias.gr> (raw)
In-Reply-To: <877e6839f0.fsf@wioo.waw.pl>
Work around <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37386>.
* gnu/packages/node.scm (node)[arguments]: Disable failing tests.
---
Jelle, Guix,
So here's the obvious non-solution, ignoring test failures being the lesser evil compared to 4 potential CVEs anywhere in a Web browser's closure.
It seems to ‘work’ in a short VM Chromium test. As in, nothing broke. Don't know how to test Node. Thoughts?
Kind regards,
T G-R
gnu/packages/node.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index fc43fcb04c..f467be7665 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -91,6 +91,11 @@
(add-before 'configure 'patch-files
(lambda* (#:key inputs #:allow-other-keys)
+ ;; FIXME: These tests fail with openssl@1.1.1d.
+ (for-each delete-file
+ '("test/parallel/test-crypto-binary-default.js"
+ "test/parallel/test-crypto-dh.js"))
+
;; Fix hardcoded /bin/sh references.
(substitute* '("lib/child_process.js"
"lib/internal/v8_prof_polyfill.js"
--
2.23.0
next prev parent reply other threads:[~2019-09-16 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 8:57 bug#37421: node fails to build during update sirmacik
2019-09-16 13:52 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix [this message]
2019-09-16 16:09 ` bug#37421: [PATCH] gnu: node: Disable tests that fail with openssl@1.1.1d Ludovic Courtès
2019-09-16 18:57 ` Jelle Licht
2019-09-16 21:39 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-09-17 14:43 ` Jelle Licht
2019-09-20 15:11 ` bug#37421: Apply nodejs test workaround? Jack Hill
2019-09-20 15:31 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916135228.22045-1-me@tobias.gr \
--to=bug-guix@gnu.org \
--cc=37421@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).