bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[Jack Hill]

Hi Guix,

Based on my experience setting up Guix on a CentOS 7 foreign distribution, 
if quoted, the variable name in a systemd unit Environment definition 
should be inside the quotes. I didn't not find definitive documentation 
stating this, but all the examples show it this way. If the value is left 
like

```
Environment=GUIX_LOCPATH='/path/to/profile/lib/locale'
```

the guix-daemon process is not able to find the right locale even when it 
is installed.

Best,
Jack

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[Jack Hill]

I wrote more about this on help-guix@

https://lists.gnu.org/archive/html/help-guix/2019-06/msg00024.html

bug#36074: [PATCH] etc: guix-daemon.service.in: fix GUIX_LOCPATH quoting

[Jack Hill]

etc/guix-daemon.service.in: Move the GUIX_LOCPATH environment varialbe name
inside the quotes are required in systemd unit files.
---
  etc/guix-daemon.service.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-daemon.service.in b/etc/guix-daemon.service.in
index 7b20a91931..407cdd199c 100644
--- a/etc/guix-daemon.service.in
+++ b/etc/guix-daemon.service.in
@@ -7,7 +7,7 @@ Description=Build daemon for GNU Guix

  [Service]
  ExecStart=@localstatedir@/guix/profiles/per-user/root/current-guix/bin/guix-daemon --build-users-group=guixbuild
-Environment=GUIX_LOCPATH='@localstatedir@/guix/profiles/per-user/root/guix-profile/lib/locale' LC_ALL=en_US.utf8
+Environment='GUIX_LOCPATH=@localstatedir@/guix/profiles/per-user/root/guix-profile/lib/locale' LC_ALL=en_US.utf8
  RemainAfterExit=yes
  StandardOutput=syslog
  StandardError=syslog
-- 
2.21.0

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[Ricardo Wurmus]

Hi Jack,

thank you for the bug report, the analysis, and the patch.  I changed
the commit log and pushed it to the master branch with commit
579d17b70dac067f8194ede46513400b91ac136a.

Thanks!

--
Ricardo

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[Ludovic Courtès]

Hi,

Jack Hill <jackhill@jackhill.us> skribis:

> Based on my experience setting up Guix on a CentOS 7 foreign
> distribution, if quoted, the variable name in a systemd unit
> Environment definition should be inside the quotes. I didn't not find
> definitive documentation stating this, but all the examples show it
> this way. If the value is left like
>
> ```
> Environment=GUIX_LOCPATH='/path/to/profile/lib/locale'
> ```

Good catch!  Indeed,
<https://www.freedesktop.org/software/systemd/man/systemd.service.html>
shows examples with quotes “inside” and “outside”, but what we want here
is quotes outside.

Thanks,
Ludo’.

bug#36074: Still got the issue in Xubuntu 18.4

[Andréas Livet]

Hello,

I'm running guix under Xubuntu 18.04 and still got the issue after 
modifying `/etc/systemd/system/guix-daemon.service` as stated in the patch.

After that I've done :

`systemctl restart guix-daemon`

`systemctl daemon-reload `

Should I done something else ?

I'm new to guix so sorry if it seems obvious.

Andréas

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[Andréas Livet]

Hello,

I'm running guix under Xubuntu 18.04 and still got the issue after 
modifying `/etc/systemd/system/guix-daemon.service` as stated in the patch.

After that I've done :

`systemctl restart guix-daemon`

`systemctl daemon-reload `

Should I done something else ?

I'm new to guix so sorry if it seems obvious.

Andréas

PS : Sorry if this is a double post, though the email subject must be 
exactly the same so I re-send my email.

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[David Loyall]

Andréas,

I'm not sure if you and I are having the same issue, but I found your
message after searching the web for information about the issue I was
facing.

I think this thread, which contains some links, provides a good
summary of the information available on the web for my issue:
https://lists.gnu.org/archive/html/help-guix/2019-06/msg00030.html

That said, the solution I found was this:

> I think the fix for this would be to clarify which package should be installed in **root's profile** when installing on a systemd foreign distro."

(Emphasis mine.  The quote is from Jack Hill in
https://lists.gnu.org/archive/html/help-guix/2019-06/msg00024.html)

So, I did `sudo guix package -i glibc-utf8-locales` (I previously did
the same without sudo--no change.)

...Before that, I'd done the other things recommended in the
aforementioned summary post.

Please note that I'm only copying and pasting magical invocations; I
don't understand locales nor guix.  I hope this message is helpful.

Cheers,
--sebboh

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[Andréas Livet]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Thanks sebboh !

It fix the error. I've already read the thread on the mailing list but 
didn't see that the package should be install as root !

I have now other problems with UTF-8 :

* I can't open file containing non ASCII characters with libreoffice

* I can't type non ASCII characters in zsh


Don't know if this is related to this bug or not. Will try to reboot to 
see if it changes something.


Anyway, thanks for your help !

Andréas


[-- Attachment #2: Type: text/html, Size: 995 bytes --]

bug#36074: Incorrect quoting of GUIX_LOCPATH environment variable in guix-daemon.service

[Andreas Enge]

Closing the bug, since the problem seems to be solved; for the
follow-up, see bug#36180.

Andreas