From mboxrd@z Thu Jan  1 00:00:00 1970
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Subject: bug#35640: Make USB modems just work on Guix
Date: Wed, 12 Jun 2019 21:51:20 +0200
Message-ID: <20190612195120.bg7yuvjghf2d546f@pelzflorian.localdomain>
References: <20190514103555.1b2a6316@scratchpost.org>
 <20190514205648.nl4s4lwvc4t67gho@pelzflorian.localdomain>
 <87ef4zvpm7.fsf@gnu.org>
 <20190522162909.tds5wz7lj6npkgy4@pelzflorian.localdomain>
 <87ef4nx3s2.fsf@gnu.org>
 <20190524201210.bzeyua7lv2mamf52@pelzflorian.localdomain>
 <20190525111856.jfu5ly2p6ynn3rdk@pelzflorian.localdomain>
 <87lfyupgxm.fsf@gnu.org>
 <20190612121312.hobngtkentkiavai@pelzflorian.localdomain>
 <874l4vxadq.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:44669)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hb9QP-0001FE-65
 for bug-guix@gnu.org; Wed, 12 Jun 2019 16:00:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hb9Hu-0000gR-5G
 for bug-guix@gnu.org; Wed, 12 Jun 2019 15:52:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48792)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hb9Hu-0000g9-1p
 for bug-guix@gnu.org; Wed, 12 Jun 2019 15:52:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hb9Ht-0005sU-Vv
 for bug-guix@gnu.org; Wed, 12 Jun 2019 15:52:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.35640.B35640.156036908422535@debbugs.gnu.org>
Content-Disposition: inline
In-Reply-To: <874l4vxadq.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 35640@debbugs.gnu.org

On Wed, Jun 12, 2019 at 02:21:05PM +0200, Ludovic Courtès wrote:
> "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
> > On Sat, May 25, 2019 at 07:44:37PM +0200, Ludovic Courtès wrote:
> >> >> +                 (substitute* "usb_modeswitch_dispatcher"
> >> >> +                   (("!/usr/bin/tclsh")
> >> >> +                    (string-append "!" jimtcl "/bin/jimsh"))
> […]
> I meant that the ‘patch-shebangs’ phase should take care of this, so you
> can remove this substitution and save two lines.
> 
> Ludo’.

It is needed.  Upstream USB_Modeswitch bundles jimtcl.  Its Makefile
uses jimsh0 from the bundled jimtcl, if possible, and replaces the
shebang using sed.  Therefore it seems right to use jimsh for Guix’
USB_ModeSwitch as well.

patch-shebang fails because the basename of #!/usr/bin/tclsh is not
jimsh.

patch-shebang: /gnu/store/24yzny7szv1fnmq6ci1x2ndyy7dzyigk-usb-modeswitch-2.5.2-dispatcher/bin/usb_modeswitch_dispatcher: warning: no binary for interpreter `tclsh' found in $PATH

Regards,
Florian