bug#36135: installer wifi password prompt

bug#36135: installer wifi password prompt

[Julien Lepiller]

Hi,

i just installed a new Guix System and had to use wifi for connecting
to the internet. Unfortunately, I found a few bugs with the wifi screen:

* The wifi screen doesn't automatically scan for wifi network, it would
  be nice if it did it when you first get to that screen.
* The password prompt is not hidden, it's a simple text prompt.
* The password prompt was not large enough for my password, so I was
  unable to connect. I had to use connmanctl from another tty to
  connect.
* Even if already connected (outside of the installer), we still have to
  choose a network. The connected network is marked with a '*' so the
  code should be able to access that information, I think.

Thank you!

bug#36135: [PATCH 3/2] installer: Hide the Wi-Fi passphrase by default.

[Tobias Geerinckx-Rice]

* gnu/installer/newt/wifi.scm (run-wifi-password-page):
Add an #:INPUT-SHOW-CHECKBOX? to the input page.
---

Guix,

This adds a ‘[ ] Show’ checkbox to the newt installer's Wi-Fi passphrase input field, which has also been requested at least twice now.  Most recently here[0].

Kind regards,

T G-R

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36135

 gnu/installer/newt/wifi.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/installer/newt/wifi.scm b/gnu/installer/newt/wifi.scm
index 1cb2ef2df3..040e013293 100644
--- a/gnu/installer/newt/wifi.scm
+++ b/gnu/installer/newt/wifi.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com>
 ;;; Copyright © 2019 Meiyo Peng <meiyo@riseup.net>
+;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -88,7 +89,8 @@ nmc_wifi_strength_bars."
 (define (run-wifi-password-page)
   "Run a page prompting user for a password and return it."
   (run-input-page (G_ "Please enter the wifi password.")
-                  (G_ "Password required")))
+                  (G_ "Password required")
+                  #:input-show-checkbox? #t))
 
 (define (run-wrong-password-page service-name)
   "Run a page to inform user of a wrong password input."
-- 
2.21.0

bug#36135: installer wifi password prompt

[Ludovic Courtès]

Hello,

Julien Lepiller <julien@lepiller.eu> skribis:

> * The wifi screen doesn't automatically scan for wifi network, it would
>   be nice if it did it when you first get to that screen.
> * The password prompt is not hidden, it's a simple text prompt.
> * The password prompt was not large enough for my password, so I was
>   unable to connect. I had to use connmanctl from another tty to
>   connect.
> * Even if already connected (outside of the installer), we still have to
>   choose a network. The connected network is marked with a '*' so the
>   code should be able to access that information, I think.

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
> Add an #:INPUT-SHOW-CHECKBOX? to the input page.

[...]

> +                  #:input-show-checkbox? #t))

It’s called #:input-hide-checkbox? AFAICS.

You can double-check that it builds without warnings with:

  guix system vm -v2 gnu/system/install.scm

Please add a “Partly fixes …” line.  This fixes both the password length
and the password visibility issues since ‘run-input-page’ will now use
FLAG-SCROLL.

Thanks!

Ludo’.

bug#36135: installer wifi password prompt

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]

Ludo',

Ludovic Courtès wrote:
> Tobias Geerinckx-Rice <me@tobias.gr> skribis:
>
>> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
>> Add an #:INPUT-SHOW-CHECKBOX? to the input page.
>
> [...]
>
>> +                  #:input-show-checkbox? #t))
>
> It’s called #:input-hide-checkbox? AFAICS.

Yes.  See the other patches in this ad-hoc ‘series’.

> You can double-check that it builds without warnings with:
>
>   guix system vm -v2 gnu/system/install.scm

Sure, I guess, but could you explain the point of doing so? 
Reproducibility by others?  I don't think patches like these 
should be pushed with such light testing, and I don't see how this 
can be tested in a VM.

Hence the dusty Dell Latitude mentioned earlier ;-)

It smells funny.

> Please add a “Partly fixes …” line.  This fixes both the 
> password length
> and the password visibility issues since ‘run-input-page’ will 
> now use
> FLAG-SCROLL.

Yah, I didn't merge the bugs for that reason, and because I'm 
still trying to fix more bugs (well, mainly waiting for dd while 
doing other stuff, since this can't be tested in a VM…)

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#36135: installer wifi password prompt

[Ludovic Courtès]

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Ludovic Courtès wrote:
>> Tobias Geerinckx-Rice <me@tobias.gr> skribis:
>>
>>> * gnu/installer/newt/wifi.scm (run-wifi-password-page):
>>> Add an #:INPUT-SHOW-CHECKBOX? to the input page.
>>
>> [...]
>>
>>> +                  #:input-show-checkbox? #t))
>>
>> It’s called #:input-hide-checkbox? AFAICS.
>
> Yes.  See the other patches in this ad-hoc ‘series’.

OK.

>> You can double-check that it builds without warnings with:
>>
>>   guix system vm -v2 gnu/system/install.scm
>
> Sure, I guess, but could you explain the point of doing so?
> Reproducibility by others?  I don't think patches like these should be
> pushed with such light testing, and I don't see how this can be tested
> in a VM.

No argument here!  The patch referred to a keyword argument that does
not exist, which is why I’m indeed suggesting more testing.  Simply
looking at the compiler warnings would have raised a flag.

Ludo’.

bug#36135: installer wifi password prompt

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hah,

Ludovic Courtès wrote:
> No argument here!  The patch referred to a keyword argument that 
> does
> not exist, which is why I’m indeed suggesting more testing. 
> Simply
> looking at the compiler warnings would have raised a flag.

There were no warnings and the code itself runs fine (believe me, 
I've run it way too often already -_-') because this was written 
on top of #36132.

I guess I was optimistic about its speedy acceptance.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#36135: installer wifi password prompt

[Ludovic Courtès]

Hi Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Ludovic Courtès wrote:
>> No argument here!  The patch referred to a keyword argument that
>> does
>> not exist, which is why I’m indeed suggesting more testing. Simply
>> looking at the compiler warnings would have raised a flag.
>
> There were no warnings and the code itself runs fine (believe me, I've
> run it way too often already -_-') because this was written on top of
> #36132.

Oh, my bad!  I hadn’t seen <https://issues.guix.gnu.org/issue/36132>.

I’ll take a look.

Ludo’.