From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#35722: Filesystem error in the installer
Date: Tue, 14 May 2019 20:20:08 +0200
Message-ID: <20190514201804.22dd17fd@scratchpost.org>
References: <63bd426cd2764658e6c1b5379544d7993c8ddc4a.camel@iamleeg.com>
	<871s11yp5b.fsf@gnu.org> <20190514185008.768fcc9c@scratchpost.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	boundary="Sig_/eXjLwr.DheAg=Dhs+T9XInU";
	protocol="application/pgp-signature"
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:37339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hQc7j-0003Cz-Q8
	for bug-guix@gnu.org; Tue, 14 May 2019 14:26:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hQc2x-0002vy-PA
	for bug-guix@gnu.org; Tue, 14 May 2019 14:21:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:36280)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hQc2x-0002vp-Mh
	for bug-guix@gnu.org; Tue, 14 May 2019 14:21:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hQc2w-0001T5-CT
	for bug-guix@gnu.org; Tue, 14 May 2019 14:21:03 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.35722.D35722.15578580155557@debbugs.gnu.org>
In-Reply-To: <20190514185008.768fcc9c@scratchpost.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Cc: Mathieu Othacehe <m.othacehe@gmail.com>, 35722-done@debbugs.gnu.org, Graham Lee <graham@iamleeg.com>

--Sig_/eXjLwr.DheAg=Dhs+T9XInU
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Root cause analysis:

                (user-partitions (append
                                  (auto-partition disk #:scheme scheme)=20
                                  (create-special-user-partitions
                                   (disk-partitions disk))))) <---


(define (create-special-user-partitions partitions)
  "Return a list with a <user-partition> record describing the ESP partition
found in PARTITIONS, if any."
  (filter-map (lambda (partition)
                (and (esp-partition? partition)
                     (partition->user-partition partition))) <----
              partitions))

I think create-special-user-partitions and the form above is automatically
trying to keep existing UEFI ESP partitions of the user.

And partition->user-partition failed for (existing) fat16 partitions.

So the fix of adding fat16 was definitely the right one for that specific
file system type.

It should be fine now.

--Sig_/eXjLwr.DheAg=Dhs+T9XInU
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlzbBtgACgkQ5xo1VCww
uqX2CQf/RVuJLJ3kVdJ5U70RHRvL0XNiLIoZsKXjbtuGhJYdhLEAkj61VuIxNVF6
25U6R5CPBmbDskSM9td0bl9FrHpl4m7N09wd4AEJOpKJJEI1zfqPcBiBZVL/L7LT
GsLrPnRPWVffKm575kO53sycXpAtEizXiHWj4GpXvEZ853W10DYhMBKTeJaWpc3S
PaXpnENLosFZw3AHuohTiJpHueR/GHD19/ZcR2KSLDo1b55SqKXhGVhviPXPwt9I
jfeWYBRYHPo8MArGWqQpBHz+AsN4bMnEO34cPmclgBmgqqWoJ8aul/7gx4zQDl4I
6wc4lsh7qkJgGqwEP+NqbHW2PtxvMw==
=e9gl
-----END PGP SIGNATURE-----

--Sig_/eXjLwr.DheAg=Dhs+T9XInU--