From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: bug#34407: [PATCH] shepherd: Delete the socket file upon exit. Date: Tue, 19 Feb 2019 20:08:59 +0100 Message-ID: <20190219200900.12407d94__42057.3483150051$1550603421$gmane$org@scratchpost.org> References: <87ef87w0d3.fsf@member.fsf.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/uQLgM.Ds.uwG.7Pwacu/x_/"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:32827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwAmM-0006OG-93 for bug-guix@gnu.org; Tue, 19 Feb 2019 14:10:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwAmL-0006vj-JO for bug-guix@gnu.org; Tue, 19 Feb 2019 14:10:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwAmK-0006us-N9 for bug-guix@gnu.org; Tue, 19 Feb 2019 14:10:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gwAmJ-0007j6-22 for bug-guix@gnu.org; Tue, 19 Feb 2019 14:10:04 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87ef87w0d3.fsf@member.fsf.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: guix-devel@gnu.org, 34407@debbugs.gnu.org --Sig_/uQLgM.Ds.uwG.7Pwacu/x_/ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 17 Feb 2019 11:38:16 +0800 iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote: > Yes, I have the 'rm /run/user/1000/shepherd/socket' workaround in my sess= ion > script too... >=20 > According to 'man 2 bind', the socket pathname should be deleted when no > longer required, so a patch to fix this bug: Hmm, I guess you can do that. But /run is supposed to be a tmpfs and elogind is supposed to rm -rf /run/u= ser/1000 after all sessions of that user terminated in any case, so how is it left o= ver in the first place? If the deletion in the case above doesn't work, please report a bug. If that patch is only in order to enable users to restart user's shepherd without exiting all their sessions, then I guess that's ok--although unusua= l. Does your patch do the right thing if the user's shepherd is already running? (i.e. keep the socket file) --Sig_/uQLgM.Ds.uwG.7Pwacu/x_/ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlxsVEwACgkQ5xo1VCww uqX81Af7BZ7/hVWriTJH7eYvonNkK2drhcv2OZWZ5zemuYvXxuQEJpb1bTMrgZkp x3eLXWNP4GRS3FZFJThSB07QDNyWDII3b8GFw/IMqqS3kKCVRFbbj/4ZvdcQADoW Um9+2paMXMfXpXsn5uDV9Tv+KmWTx8Sw33LP1fIUJXox7bqJIcUHZd5Jy4OoWR5I G9t//DzMvCOD+kJsBxFrafjQePwXz5VxcIBY+xqbPF1WZJ3DPqsf1YFMIsFDPYYc 2Pbo6Xk+KzlT9JYbUl+km7ZpsOhiewFY7YWudmCVNNGnLs0gm6/naqlPaqOo1PUj buwKQWoi+Ws4BeqSt1+tO2XRG1bucg== =K5gI -----END PGP SIGNATURE----- --Sig_/uQLgM.Ds.uwG.7Pwacu/x_/--