bug#32835: icecat show many warning and don't display correctly

bug#32835: icecat show many warning and don't display correctly

[Andreas Enge]

Hello,

On Fri, Jan 18, 2019 at 07:57:40AM -0800, Quiliro Ordonez wrote:
> El 2019-01-07 21:41, 荒井吉則 escribió:
> > It's working. 
> > 
> > export
> > XDG_DATA_DIRS="$HOME/.guix-profile/share${XDG_DATA_DIRS:+:}$XDG_DATA_DIRS"
> 
> icecat &
> does not work.
> 
> export
> XDG_DATA_DIRS="$HOME/.guix-profile/share${XDG_DATA_DIRS:+:}$XDG_DATA_DIRS"
> && icecat &
> works perfectly.
> 
> Must something be modified on the software definition? This is not
> something the user should change.

this seems to be the same problem as bug #32835, which I am cc-ing.
Do we need to add search paths? Or wrap a binary?

Andreas

bug#32835: icecat show many warning and don't display correctly

[Yoshinori Arai]

On Sun, Jan 27, 2019 at 04:54:10PM +0100, Andreas Enge wrote:
> Hello,
> 
> On Fri, Jan 18, 2019 at 07:57:40AM -0800, Quiliro Ordonez wrote:
> > El 2019-01-07 21:41, 荒井吉則 escribió:
> > > It's working. 
> > > 
> > > export
> > > XDG_DATA_DIRS="$HOME/.guix-profile/share${XDG_DATA_DIRS:+:}$XDG_DATA_DIRS"
> > 
> > icecat &
> > does not work.
> > 
> > export
> > XDG_DATA_DIRS="$HOME/.guix-profile/share${XDG_DATA_DIRS:+:}$XDG_DATA_DIRS"
> > && icecat &
> > works perfectly.
> > 
> > Must something be modified on the software definition? This is not
> > something the user should change.
> 
> this seems to be the same problem as bug #32835, which I am cc-ing.
> Do we need to add search paths? Or wrap a binary?
> 
> Andreas
> 
> 
I think it's no problem if 'source "$HOME/.guix-profile/etc/profile"'
is written in user's bash_profile.

I'm afraid my response is out of your point.

bug#32835: icecat show many warning and don't display correctly

[Andreas Enge]

On Mon, Jan 28, 2019 at 10:31:29AM +0900, Yoshinori Arai wrote:
> I think it's no problem if 'source "$HOME/.guix-profile/etc/profile"'
> is written in user's bash_profile.

I already do, but this is not enough. Installing icecat into the user profile
does not cause XDG* environment variables to be set in $HOME/.guix-profile/etc/profile.
It may work incidentally when other installed packages cause the variable
to be set.

Andreas

bug#32835: icecat show many warning and don't display correctly

[Ricardo Wurmus]

Andreas Enge <andreas@enge.fr> writes:

> On Mon, Jan 28, 2019 at 10:31:29AM +0900, Yoshinori Arai wrote:
>> I think it's no problem if 'source "$HOME/.guix-profile/etc/profile"'
>> is written in user's bash_profile.
>
> I already do, but this is not enough. Installing icecat into the user profile
> does not cause XDG* environment variables to be set in $HOME/.guix-profile/etc/profile.
> It may work incidentally when other installed packages cause the variable
> to be set.

The solution might be to use glib-or-gtk-build-system instead of
gnu-build-system.  This would wrap the binary in the required
variables.

Would someone like to try this before we make the change in the master
branch?

--
Ricardo

bug#32835: icecat show many warning and don't display correctly

[Andreas Enge]

On Wed, Jan 30, 2019 at 07:02:29PM +0100, Ricardo Wurmus wrote:
> The solution might be to use glib-or-gtk-build-system instead of
> gnu-build-system.  This would wrap the binary in the required
> variables.
> 
> Would someone like to try this before we make the change in the master
> branch?

Okay, I will give it a try.

Andreas

bug#32835: icecat show many warning and don't display correctly

[Andreas Enge]

On Wed, Jan 30, 2019 at 07:02:29PM +0100, Ricardo Wurmus wrote:
> The solution might be to use glib-or-gtk-build-system instead of
> gnu-build-system.  This would wrap the binary in the required
> variables.
> 
> Would someone like to try this before we make the change in the master
> branch?

I did and nothing changed. I was a bit surprised that icecat does not get
rebuilt. In any case, XDG_DATA_DIRS still does not appear as an environment
variable in $HOME/.guix-profile/etc/profile after installing icecat.

Andreas

bug#32835: icecat show many warning and don't display correctly

[Maxim Cournoyer]

Hello,

On January 31, 2019 10:47:23 AM UTC, Andreas Enge <andreas@enge.fr> wrote:
>On Wed, Jan 30, 2019 at 07:02:29PM +0100, Ricardo Wurmus wrote:
>> The solution might be to use glib-or-gtk-build-system instead of
>> gnu-build-system.  This would wrap the binary in the required
>> variables.
>> 
>> Would someone like to try this before we make the change in the
>master
>> branch?
>
>I did and nothing changed. I was a bit surprised that icecat does not
>get
>rebuilt.

Then something is wrong. Changing something as important should have definitly triggered a rebuild.

Are you modifying a git checkout of Guide and prefixing all of the Guix commands with "./pre-inst-env" ?

Maxim

Re: bug#32835: icecat show many warning and don't display correctly

[Andreas Enge]

On Thu, Jan 31, 2019 at 01:24:03PM +0000, Maxim Cournoyer wrote:
> Then something is wrong. Changing something as important should have definitly triggered a rebuild.
> Are you modifying a git checkout of Guide and prefixing all of the Guix commands with "./pre-inst-env" ?

Apologies, I must have made a mistake. Trying again a new build starts.

Andreas

bug#32835: icecat show many warning and don't display correctly

[Andreas Enge]

Well, things are more delicate than that. It is not enough to just swap the
build system, something probably also needs to be done around these lines
in the build recipe:
       #:modules ((ice-9 ftw)
                  (ice-9 rdelim)
                  (ice-9 match)
                  ,@%gnu-build-system-modules)

Also, the binary is already wrapped:
         (add-after 'install 'wrap-program
           (lambda* (#:key inputs outputs #:allow-other-keys)
             (let* ((out (assoc-ref outputs "out"))
                    (lib (string-append out "/lib"))
                    (gtk (assoc-ref inputs "gtk+"))
                    (gtk-share (string-append gtk "/share")))
               (wrap-program (car (find-files lib "^icecat$"))
                 `("XDG_DATA_DIRS" ":" prefix (,gtk-share)))
               #t))))))

I am deferring to someone more knowledgeable...

Andreas