From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: bug#33962: guix pull fails on latest master Date: Thu, 3 Jan 2019 14:33:21 -0500 Message-ID: <20190103193321.GB5598@jasmine.lan> References: <219a0e95-fb46-5fba-5030-745cefa2441d@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vGgW1X5XWziG23Ko" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf8kn-0002Gm-LY for bug-guix@gnu.org; Thu, 03 Jan 2019 14:34:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf8kk-00046J-Ny for bug-guix@gnu.org; Thu, 03 Jan 2019 14:34:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gf8kk-000466-KM for bug-guix@gnu.org; Thu, 03 Jan 2019 14:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gf8kk-0006TG-GL for bug-guix@gnu.org; Thu, 03 Jan 2019 14:34:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <219a0e95-fb46-5fba-5030-745cefa2441d@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Brendan Tildesley Cc: 33961-done@debbugs.gnu.org, 33962-done@debbugs.gnu.org, rhelling@mykolab.com --vGgW1X5XWziG23Ko Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 04, 2019 at 01:24:22AM +1100, Brendan Tildesley wrote: > 95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard fails > to build because it references meson-build-system without importing the > required module. I'm guessing adding=A0 #:use-module (guix build-system > meson)=A0=A0 ; would fix it. >=20 > I'm curious to know how this error was made. My guess is that the code contribution was tested with the meson-build-system module imported correctly. However, the actual commit or patch was created without the module import line. When reviewing patches just by reading them, it's easy to miss mistakes like this one. This should be fixed in commit 4382cef28cb6de4b2b505788b759b0fe4f8ea603 Thanks for the reports! --vGgW1X5XWziG23Ko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlwuY4EACgkQJkb6MLrK fwhmdg//ZO1ndMzAskKAgmxcaNy9dHifcxIYEuoe0O9rl9Q/OKJTooABSx5rFH2P 5/bxTDfjOIYZs6w+Ph7EYR3ZEyx8CYsSO7AnXwYPfMuIG5SyUov9jmcLl2VeoXfX s4cu/vLYEacAYyWNGDO6AyXI/qykkoclB8id3Dxga3fnPHO0Oxm5DpSV+hDinfNr IT1cuDwzGaDsG5qrljt/5W8TTp+5v+lMeHJrOzYZKWiwj2X4+CN0uZDJV3ceaMfZ bPkdMyvcXTmjr5nz3LmpfxRJDPMaPvGegfuwDBPTQnSChxO9T1OmHim21A9dLaw6 2Qo1v6J9Ov/1JLzAZ1kWj7W2WM5Z3TEMQmmtReGNiQkWN+MZNn2bjb2Eck/hHLvW jgE263LeUL7/W+fURAcIBcdp0aDhj4V8yU6Hczgs4crLt9jrtbIY4bzEI1x6pLfd CqeLJhdxFJ8OEiiPkooZw3w6CvtJtuG8AjLeJK/p4j1aqO+YIV+HUYtL9DriOaFe E3QwMg0JlTWDAImpHOCkzfSJ5fRBpK3FAAXpme9kQV/dKnhJh41XoFF2e1gm5Gvm 6IBG/lG/SlSFPeExiTLttPBytYJrVk3uxmqpe944FaiyUk2rucMZ/k/wg9gwkIju CFotsqbtFhXaDLD6OVj0s5uq4qCjmWogfVBE509IEJ/vbLk+1oI= =+931 -----END PGP SIGNATURE----- --vGgW1X5XWziG23Ko--