unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Brendan Tildesley <brendan.tildesley@gmail.com>
Cc: 33961-done@debbugs.gnu.org, 33962-done@debbugs.gnu.org,
	rhelling@mykolab.com
Subject: bug#33962: guix pull fails on latest master
Date: Thu, 3 Jan 2019 14:33:21 -0500	[thread overview]
Message-ID: <20190103193321.GB5598@jasmine.lan> (raw)
In-Reply-To: <219a0e95-fb46-5fba-5030-745cefa2441d@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

On Fri, Jan 04, 2019 at 01:24:22AM +1100, Brendan Tildesley wrote:
> 95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard fails
> to build because it references meson-build-system without importing the
> required module. I'm guessing adding  #:use-module (guix build-system
> meson)   ; would fix it.
> 
> I'm curious to know how this error was made.

My guess is that the code contribution was tested with the
meson-build-system module imported correctly. However, the actual commit
or patch was created without the module import line.

When reviewing patches just by reading them, it's easy to miss mistakes
like this one.

This should be fixed in commit 4382cef28cb6de4b2b505788b759b0fe4f8ea603

Thanks for the reports!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2019-01-03 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03 14:24 bug#33962: guix pull fails on latest master Brendan Tildesley
     [not found] ` <handler.33962.B.154652547612614.ack@debbugs.gnu.org>
2019-01-03 14:32   ` bug#33962: Acknowledgement (guix pull fails on latest master) Brendan Tildesley
2019-01-03 14:48 ` bug#33962: guix pull fails on latest master Rutger Helling
2019-01-03 19:33 ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103193321.GB5598@jasmine.lan \
    --to=leo@famulari.name \
    --cc=33961-done@debbugs.gnu.org \
    --cc=33962-done@debbugs.gnu.org \
    --cc=brendan.tildesley@gmail.com \
    --cc=rhelling@mykolab.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).