From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#33896: libblockdev inputs are not used correctly Date: Sat, 29 Dec 2018 20:50:36 +0200 Message-ID: <20181229185036.GV2581@macbook41> References: <20181228143255.78bf15b1@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Fq7EdiloNwzjWdQG" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdK22-0004uH-3y for bug-guix@gnu.org; Sat, 29 Dec 2018 14:12:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gdJhO-0002Yu-Ce for bug-guix@gnu.org; Sat, 29 Dec 2018 13:51:37 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:42493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gdJhO-0002YZ-7c for bug-guix@gnu.org; Sat, 29 Dec 2018 13:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gdJhO-0007Kw-15 for bug-guix@gnu.org; Sat, 29 Dec 2018 13:51:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20181228143255.78bf15b1@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic Cc: 33896@debbugs.gnu.org --Fq7EdiloNwzjWdQG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 28, 2018 at 02:32:55PM +0100, Danny Milosavljevic wrote: > Currently, libblockdev has inputs which aren't used. >=20 > These SHOULD be used, but the source files are not patched > so the executables in the inputs are not found or used. >=20 > Example: >=20 > * libblockdev depends on dosfstools because src/plugins/fs/vfat.c would u= se > "mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually ref= er > to the inputs. >=20 > This problem is valid for everything in src/plugins/fs . >=20 > Do we proceed to patch it to use the inputs or do we move dosfstools etc > to propagated-inputs ? >=20 > I'd suggest the former. Similar to the enlightenment package getting more 'substitute*'s to improve functionality, I agree that patching libblockdev to actually find all the inputs/executables is preferable. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Fq7EdiloNwzjWdQG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlwnwfkACgkQQarn3Mo9 g1GPdQ//dvh7pDkTle9SoyPTCH9iUEQ0E+uPbVQxqsuLySyWdK4PEj1WWYVd98Fq DhlK+egUUAkAsGGSPBgXdKZoJkY7t1dO4+X1YPgh1fEuKjhXCGdfb1DiUXk1GNJg egNTxhRa0BUMgeIg4rqeCSvqc2C2lsaf++sQedmskF8+VJvDc3bDu/T0n9E0P3vQ 9/qi9NWXLVLxaOMSV5oScArJeMTgOsQKQSUK457cJucy5N2YEtuwsoZbo6X9XdM9 Pmd8pkI09HOvfQiaBRr0vmsyM9WwIdajVt3r+ElReKoOWUnHVuIBRbu0l45OUAwv nmcnoOh4su8TTRGcZWEtB+36RC+v5IqigBWGdoEQkly2DfulARBexSGuTlRqv+t+ qrILuw2uL/RO6WtPJEoQZeZ70f65EEd/wNqyHFe6pQfEwsdXCB5Lr6f54UZ6i/LP QzXSf7DJqnVWavJxiTNXC0aXynCagrJIV7iOoZ4eOC8m4XjPLD4d6f1DN+HcMl0D wj9VIdZYoLT2zZDPwWUYeOYjOpdi4QqFMr1avBtGPOis+LgfW8+1kz2O5GQyPBou yoRjOK8jM27YPKXM5bUr/TB8GQ0aBuf0sHEXFp1lOo/FeGibekwV7WJVnlJ6uAkd Znup9KM+P0nwjJENwGFSglrmljdO85tExdhwC/lRLQvBBpzmKw8= =p5yZ -----END PGP SIGNATURE----- --Fq7EdiloNwzjWdQG--