From: Danny Milosavljevic <dannym@scratchpost.org>
To: 33896@debbugs.gnu.org
Subject: bug#33896: libblockdev inputs are not used correctly
Date: Fri, 28 Dec 2018 14:32:55 +0100 [thread overview]
Message-ID: <20181228143255.78bf15b1@scratchpost.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
Currently, libblockdev has inputs which aren't used.
These SHOULD be used, but the source files are not patched
so the executables in the inputs are not found or used.
Example:
* libblockdev depends on dosfstools because src/plugins/fs/vfat.c would use
"mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually refer
to the inputs.
This problem is valid for everything in src/plugins/fs .
Do we proceed to patch it to use the inputs or do we move dosfstools etc
to propagated-inputs ?
I'd suggest the former.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2018-12-28 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 13:32 Danny Milosavljevic [this message]
2018-12-29 18:50 ` bug#33896: libblockdev inputs are not used correctly Efraim Flashner
2019-01-05 17:55 ` Ludovic Courtès
2021-09-25 21:28 ` bug#33896: [PATCH 1/2] gnu: libblockdev: Embed executable paths Sarah Morgensen
2021-09-25 21:46 ` bug#33896: [PATCH 2/2] gnu: libblockdev: Fix inputs Sarah Morgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228143255.78bf15b1@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=33896@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).