From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#33509: core-updates: arc-theme fails with "Invalid GNOME version: 3.24" Date: Tue, 27 Nov 2018 18:06:17 +0200 Message-ID: <20181127160617.GA17277@macbook41> References: <20181126125515.5dee070e@alma-ubu> <20181126210033.GI28778@macbook41> <20181127160745.2f994639@alma-ubu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRftD-0004YM-7W for bug-guix@gnu.org; Tue, 27 Nov 2018 11:07:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRft8-0008Sp-9w for bug-guix@gnu.org; Tue, 27 Nov 2018 11:07:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48181) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRft8-0008SP-5b for bug-guix@gnu.org; Tue, 27 Nov 2018 11:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gRft7-00071O-Pr for bug-guix@gnu.org; Tue, 27 Nov 2018 11:07:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20181127160745.2f994639@alma-ubu> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 33509@debbugs.gnu.org --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2018 at 04:07:45PM +0100, Bj=C3=B6rn H=C3=B6fling wrote: > On Mon, 26 Nov 2018 23:00:33 +0200 > Efraim Flashner wrote: >=20 > > On Mon, Nov 26, 2018 at 12:55:15PM +0100, Bj=C3=B6rn H=C3=B6fling wrote: > > > On core-updates the package arc-theme fails: > > >=20 > > > starting phase `configure' > > > source directory: > > > "/tmp/guix-build-arc-theme-20170302.drv-0/arc-theme-20170302" build > > > directory: > > > "/tmp/guix-build-arc-theme-20170302.drv-0/arc-theme-20170302" > > > configure flags: > > > ("CONFIG_SHELL=3D/gnu/store/q19l04vd2za80mk1845pz7r8cz29qk43-bash > > > configure: WARNING: unrecognized options: --enable-fast-install > > > checking for a BSD-compatible > > > install... /gnu/store/5s2nib1lrd2101bbrivcl17kjx1m checking whether > > > build environment is sane... yes checking for a thread-safe mkdir > > > -p... /gnu/store/5s2nib1lrd2101bbrivcl17kjx1msp checking for > > > gawk... gawk checking whether make sets $(MAKE)... no checking > > > whether make supports nested variables... yes checking for > > > pkg-config... /gnu/store/xyiyf12w4i7zf5g5b4ah0bi1mmd6i8xa-pkg-confi > > > checking pkg-config is at least version 0.9.0... yes configure: > > > error: Invalid GNOME version: 3.24 > > >=20 > > > It seams that only GNOME versions until 3.22 are valid. > > >=20 > > > Nix has a workaround that sets the version down: > > >=20 > > > https://github.com/NixOS/nixpkgs/commit/165fa89762d7156bb3f2774cd3ff0= d40cd0a9606 > > >=20 > > > If I set the version hard to 3.22 the package builds again > > > successfully: > > >=20 > > > - '(#:phases > > > + '(#:configure-flags > > > + '("--with-gnome=3D3.22") > > > + #:phases > > >=20 > > > Is it legitimate to patch it like that or do we need more tests? > > >=20 > > > Bj=C3=B6rn > > > =20 > >=20 > > I'd look into if you can use (version-major+minor (package-version > > gnome)) so it doesn't have to be updated. > >=20 > >=20 >=20 > Hi Efraim, >=20 > I don't know what you mean with "so it doesn't have to be updated"? I > mean changing the package definition is an update? >=20 > Also, I don't know what your intention with "version-major+minor" is? > On core-updates the current version of gnome is "3.24.3". > Then (version-major+minor gnome-version) would still evaluate to 3.24, > which IS too big, 3.22 is the maximum accepted version.=20 >=20 > Let me explain a bit more: With adding "--with-gnome=3D3.22" we are > pretending the configure-script that we will use gnome-3.22, although > we still use the latest version (To be precise, we use gtk+, but that > seams to report the gnome-version with pkg-config).=20 >=20 > This version number is then used to search in the directory >=20 > /tmp/guix-build-arc-theme-20170302.drv-0/arc-theme-20170302/common/gtk-3.0 >=20 > the matching "major.minor" version, choosing the right theme. >=20 > 3.22 is already symlinking to 3.20, and that is the highest available > real directory. >=20 > So we might get wrong look&feel here, because it is not adapted to > GNOME 3.24. But there is no further development upstream anyway. If it > doesn't look totally malformed, we can use it like that. My disk is a > bit full, I can't do a vm-image with it currently. >=20 > Bj=C3=B6rn >=20 I see, I misunderstood and thought we were hardcoding 3.22 based on the version of gnome, not based on the version string the configure script is looking for. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlv9a3UACgkQQarn3Mo9 g1E3eg/+KfaOrwIHschBiDqEJMflrb1R721HWZdRhNWwQZCiDNja+3Ad2r5nfyUH tWXodfIotmD7YXyX1v0CifiV8tW6TIxrCZcR+Z3xyJjN1S8EF81BYadiWx9RZeud N43JVTkAz+AQSGiDg98RCu8JsYOBrY8giLR3D0FvKG7snHP8yi5utRZhId3p5DRX uZLXUpMRtsY81zOSGF/oK+ZRx1lXGCKKt9RgQAqEcZNjx5cU8eHCR3r2gYBfXp3Q Exu/3E80hpoXrnTVixbOR6Ny4UY+646fhwImi6al+yd8tlN+tz8No7l+78vJoSL9 xreNhZMuB5t+P8ZjTc5J+zdNcAV0ghBS5nb+ofSvrW+KuecWnz5ugMQDRD+RX8Rv +ZYg+dP1VPAYtXc9txJLZ4zAS/El1PIncOUZlI0PtYWfFkAavQn3ofTNlmSUdJOX KG8XbNNnXEoP2nigVRDk1LqHQe6X6vrkwZKxNRXzJiijfT7KlbjF5LO2mffDYaq0 661Opa8vADsuUtRKwgbiAlEIpZonDv7PlYuhkU1QzP/6cGH2WpvZy23ybtiX7J1Z O0ugOHnFDOVK+/j1vmQ4fvQOr8JsOirxXkScefAvc9VMZct/K/ncvzai6j4xAMxj IwMCjGHq9R+hdwNbC1VuJySM9LLF0wryC8Jjxo6CU19mP2lfviw= =N8JF -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--