bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Nils Gillmann]

Hi,

at taler we need shpchp as a module in the initrd.

Before version 4.18.x, shpchp was a module we've build in guix' linux-libre,
you were able to just specify it for the initrd.

With 4.18.9, this module became a compile-in/built-in (see linux
commit log).  I want to avoid maintaining yet another kernel
definition for future complications if I can.  Can we get this module
built in by default?

I consider it a bug as the functionality was given before and
disappeared now, leaving our system unable to upgrade unless I write
some code around it.

Thanks.

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Mark H Weaver]

Hi Nils,

Nils Gillmann <gillmann@n0.is> writes:

> at taler we need shpchp as a module in the initrd.
>
> Before version 4.18.x, shpchp was a module we've build in guix' linux-libre,
> you were able to just specify it for the initrd.
>
> With 4.18.9, this module became a compile-in/built-in (see linux
> commit log).  I want to avoid maintaining yet another kernel
> definition for future complications if I can.  Can we get this module
> built in by default?

Sure, that sounds sensible.  I'll push a config update soon.

     Thanks,
       Mark

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Ludovic Courtès]

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> Nils Gillmann <gillmann@n0.is> writes:
>
>> at taler we need shpchp as a module in the initrd.
>>
>> Before version 4.18.x, shpchp was a module we've build in guix' linux-libre,
>> you were able to just specify it for the initrd.
>>
>> With 4.18.9, this module became a compile-in/built-in (see linux
>> commit log).  I want to avoid maintaining yet another kernel
>> definition for future complications if I can.  Can we get this module
>> built in by default?
>
> Sure, that sounds sensible.  I'll push a config update soon.

I’ve reopened the bug because I think we need the same change as in
fe73352e8073ea0a0e6f6b5591f24395671998ab for AArch64 (at least it
appears to be needed on the OverDrive 1000.)

Could you take a look?

(I’m not entirely sure about the workflow to get the updated config from
“make oldconfig”…)

Thanks,
Ludo’.

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Mark H Weaver]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

Hi Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

> Mark H Weaver <mhw@netris.org> skribis:
>
>> Nils Gillmann <gillmann@n0.is> writes:
>>
>>> at taler we need shpchp as a module in the initrd.
>>>
>>> Before version 4.18.x, shpchp was a module we've build in guix' linux-libre,
>>> you were able to just specify it for the initrd.
>>>
>>> With 4.18.9, this module became a compile-in/built-in (see linux
>>> commit log).  I want to avoid maintaining yet another kernel
>>> definition for future complications if I can.  Can we get this module
>>> built in by default?
>>
>> Sure, that sounds sensible.  I'll push a config update soon.
>
> I’ve reopened the bug because I think we need the same change as in
> fe73352e8073ea0a0e6f6b5591f24395671998ab for AArch64 (at least it
> appears to be needed on the OverDrive 1000.)
>
> Could you take a look?

Sure.  I've attached a proposed patch below.  Would you like to try it
and push it to master if it works?

> (I’m not entirely sure about the workflow to get the updated config from
> “make oldconfig”…)

FYI, my current method is:

* Unpack the latest linux-libre source.
* Copy the existing kernel configuration to .config in the source dir.
* Manually edit .config with desired configuration change.
* Within "guix environment linux-libre" run:

      ARCH=arm64 make oldconfig

  More generally, ARCH should be set to the value returned by
  'system->linux-architecture' in (gnu packages linux).
* Manually edit out some changes that are clearly irrelevant,
  such the addition of a top comment saying which compiler I have in my
  PATH.

Some day, I would prefer to have multiple smaller configuration files,
with a shared common configuration plus smaller architecture-specific
files, but we're not there yet.

     Thanks,
       Mark



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] gnu: linux-libre: Enable SHPC PCI Hotplug driver on ARM64 --]
[-- Type: text/x-patch, Size: 1163 bytes --]

From 41fdb333b05e300622c4c41aaced70fff2c6df7f Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Wed, 17 Oct 2018 20:09:19 -0400
Subject: [PATCH] gnu: linux-libre: Enable SHPC PCI Hotplug driver on ARM64.

Fixes <https://bugs.gnu.org/32840> on ARM64.

* gnu/packages/aux-files/linux-libre/4.18-arm64.conf: Add
CONFIG_HOTPLUG_PCI_SHPC=y.
---
 gnu/packages/aux-files/linux-libre/4.18-arm64.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/aux-files/linux-libre/4.18-arm64.conf b/gnu/packages/aux-files/linux-libre/4.18-arm64.conf
index ab30f51d2..64b14b52c 100644
--- a/gnu/packages/aux-files/linux-libre/4.18-arm64.conf
+++ b/gnu/packages/aux-files/linux-libre/4.18-arm64.conf
@@ -1,6 +1,6 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/arm64 4.18.0-gnu Kernel Configuration
+# Linux/arm64 4.18.14-gnu Kernel Configuration
 #
 CONFIG_ARM64=y
 CONFIG_64BIT=y
@@ -481,7 +481,7 @@ CONFIG_HOTPLUG_PCI=y
 CONFIG_HOTPLUG_PCI_ACPI=y
 CONFIG_HOTPLUG_PCI_ACPI_IBM=m
 CONFIG_HOTPLUG_PCI_CPCI=y
-# CONFIG_HOTPLUG_PCI_SHPC is not set
+CONFIG_HOTPLUG_PCI_SHPC=y
 
 #
 # PCI controller drivers
-- 
2.19.1

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Ludovic Courtès]

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:

[...]

>> I’ve reopened the bug because I think we need the same change as in
>> fe73352e8073ea0a0e6f6b5591f24395671998ab for AArch64 (at least it
>> appears to be needed on the OverDrive 1000.)
>>
>> Could you take a look?
>
> Sure.  I've attached a proposed patch below.  Would you like to try it
> and push it to master if it works?

It does fix the problem for me so I’ve pushed it as
402e60859da609e95d16a04a253977da88f4077e.

>> (I’m not entirely sure about the workflow to get the updated config from
>> “make oldconfig”…)
>
> FYI, my current method is:
>
> * Unpack the latest linux-libre source.
> * Copy the existing kernel configuration to .config in the source dir.
> * Manually edit .config with desired configuration change.
> * Within "guix environment linux-libre" run:
>
>       ARCH=arm64 make oldconfig
>
>   More generally, ARCH should be set to the value returned by
>   'system->linux-architecture' in (gnu packages linux).
> * Manually edit out some changes that are clearly irrelevant,
>   such the addition of a top comment saying which compiler I have in my
>   PATH.

OK, thanks for explaining!

> Some day, I would prefer to have multiple smaller configuration files,
> with a shared common configuration plus smaller architecture-specific
> files, but we're not there yet.

Yeah…

Anyway I’m happy to say I have GuixSD running on the OverDrive 1000!
There were a few more shenanigans (the openSuSE kernel had a few things
set to “y” that we’re setting to “m”), but then it went smoothly.

Thanks!

Ludo’.

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Mark H Weaver]

Nils Gillmann <gillmann@n0.is> writes:

> at taler we need shpchp as a module in the initrd.
>
> Before version 4.18.x, shpchp was a module we've build in guix' linux-libre,
> you were able to just specify it for the initrd.
>
> With 4.18.9, this module became a compile-in/built-in (see linux
> commit log).  I want to avoid maintaining yet another kernel
> definition for future complications if I can.  Can we get this module
> built in by default?

Done in commit fe73352e8073ea0a0e6f6b5591f24395671998ab on master.
Closing this bug now, but please reopen if appropriate.

     Thanks!
       Mark

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Ricardo Wurmus]

Mark H Weaver <mhw@netris.org> writes:

> Nils Gillmann <gillmann@n0.is> writes:
>
>> at taler we need shpchp as a module in the initrd.
>>
>> Before version 4.18.x, shpchp was a module we've build in guix' linux-libre,
>> you were able to just specify it for the initrd.
>>
>> With 4.18.9, this module became a compile-in/built-in (see linux
>> commit log).  I want to avoid maintaining yet another kernel
>> definition for future complications if I can.  Can we get this module
>> built in by default?
>
> Done in commit fe73352e8073ea0a0e6f6b5591f24395671998ab on master.
> Closing this bug now, but please reopen if appropriate.

I don’t understand why building it as a module is needed when upstream
decided to turn it into a built-in feature.

Could you please explain?

-- 
Ricardo

bug#32840: linux-libre 4.18.9: shpchp is no longer a module (now: built-in)

[Nils Gillmann]

Ricardo Wurmus transcribed 808 bytes:
> 
> Mark H Weaver <mhw@netris.org> writes:
> 
> > Nils Gillmann <gillmann@n0.is> writes:
> >
> >> at taler we need shpchp as a module in the initrd.
> >>
> >> Before version 4.18.x, shpchp was a module we've build in guix' linux-libre,
> >> you were able to just specify it for the initrd.
> >>
> >> With 4.18.9, this module became a compile-in/built-in (see linux
> >> commit log).  I want to avoid maintaining yet another kernel
> >> definition for future complications if I can.  Can we get this module
> >> built in by default?
> >
> > Done in commit fe73352e8073ea0a0e6f6b5591f24395671998ab on master.
> > Closing this bug now, but please reopen if appropriate.

Thanks! I'll get back if this didn't fix upgrading the server.

> I don’t understand why building it as a module is needed when upstream
> decided to turn it into a built-in feature.
> 
> Could you please explain?

There are modules [M] and boolean y/n "builtins" in Linux. We don't need
to build it as a module now, since upstream changed it to be a builtin.
It is not covered by whatever selection we have in the kernel config as
builtins. Since the module disappeared, users of the module were left
with the choice to remove it and either build their own kernel variation
or ask for it as a feature.

I asked for it, since Taler wanted as little reliance on third-party
repositories as possible, no matter how reliable the repositories are.

> -- 
> Ricardo
> 
> 
> 
>