unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
Cc: 32360@debbugs.gnu.org
Subject: bug#32360: gst-plugins-base has test failures (when built as a dependency)
Date: Fri, 17 Aug 2018 14:05:54 -0400	[thread overview]
Message-ID: <20180817180554.GB15789@jasmine.lan> (raw)
In-Reply-To: <20180817171642.GA4821@jasmine.lan>


[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]

Here is a patch that excludes Opus when building gst-plugins-base on and
for 32-bit systems. I think it's not so bad to be missing support for
Opus in this context until the underlying bug is fixed.

With this patch, gst-plugins-base builds successfully with
'--system=i686-linux'. I didn't test the full Wine build.

[-- Attachment #1.2: 0001-gnu-gst-plugins-base-Don-t-build-with-Opus-for-32-bi.patch --]
[-- Type: text/plain, Size: 1962 bytes --]

From e1cc6137514c1e002b82ec48c3a5e260937ceeb1 Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Fri, 17 Aug 2018 13:43:04 -0400
Subject: [PATCH] gnu: gst-plugins-base: Don't build with Opus for 32-bit
 systems.

Fixes <https://bugs.gnu.org/32360> and <https://bugs.gnu.org/32466>.

* gnu/packages/gstreamer.scm (gst-plugins-base)[inputs]: Exclude opus
when building for 32-bit systems.
---
 gnu/packages/gstreamer.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index 951ca93fb..4477d2f86 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -4,7 +4,7 @@
 ;;; Copyright © 2015, 2016 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2015, 2018 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
+;;; Copyright © 2016, 2018 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
@@ -167,7 +167,6 @@ This package provides the core library and elements.")
        ("orc" ,orc)))              ;required by gstreamer-audio-1.0.pc
     (inputs
      `(("cdparanoia" ,cdparanoia)
-       ("opus" ,opus)
        ("pango" ,pango)
        ("libogg" ,libogg)
        ("libtheora" ,libtheora)
@@ -176,7 +175,12 @@ This package provides the core library and elements.")
        ("zlib" ,zlib)
        ("libXext" ,libxext)
        ("libxv" ,libxv)
-       ("alsa-lib" ,alsa-lib)))
+       ("alsa-lib" ,alsa-lib)
+       ;; XXX Don't build with opus on 32-bit systems:
+       ;; <https://bugs.gnu.org/32360>
+       ,@(if (target-64bit?)
+           `(("opus" ,opus))
+           '())))
     (native-inputs
       `(("pkg-config" ,pkg-config)
         ("glib:bin" ,glib "bin")
-- 
2.18.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-08-17 18:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03 11:38 bug#32360: gst-plugins-base has test failures (when built as a dependency) Björn Höfling
2018-08-17 17:16 ` Leo Famulari
2018-08-17 18:05   ` Leo Famulari [this message]
2018-08-17 21:50     ` Björn Höfling
2018-08-18 10:46       ` Pjotr Prins
2018-08-18 11:34         ` Tobias Geerinckx-Rice
2018-08-19  7:35           ` Pjotr Prins
2018-08-18  7:44     ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817180554.GB15789@jasmine.lan \
    --to=leo@famulari.name \
    --cc=32360@debbugs.gnu.org \
    --cc=bjoern.hoefling@bjoernhoefling.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).