bug#32467: Upgrade of libraw to 0.19 makes krita build fail

bug#32467: Upgrade of libraw to 0.19 makes krita build fail

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 2132 bytes --]

Commit 290532870e3c9ea832e62701ec8784a78d6c6714 updated libraw:

-    (version "0.18.12")
+    (version "0.19.0")

This makes the build of krita fail:

/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcr
aw/src/kdcraw_p.cpp: In member function ?bool KDcrawIface::KDcraw::Private::load
FromLibraw(const QString&, QByteArray&, int&, int&, int&)?:
/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcr
aw/src/kdcraw_p.cpp:381:32: error: ?struct libraw_output_params_t? has no member
 named ?linenoise?
             raw.imgdata.params.linenoise    = m_parent->m_rawDecodingSettings.N
RThreshold * 2.11E-5 + 0.00111111;
                                ^
/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcr
aw/src/kdcraw_p.cpp:382:32: error: ?struct libraw_output_params_t? has no member
 named ?cfaline?
             raw.imgdata.params.cfaline      = true;
                                ^
/tmp/guix-build-krita-4.1.1.drv-0/krita-4.1.1/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:389:32: error: ?struct libraw_output_params_t? has no member named ?lclean?
             raw.imgdata.params.lclean       = m_parent->m_rawDecodingSettings.NRThreshold     * 5E-5;

The problem is already known upstream but not yet solved:

https://bugs.kde.org/show_bug.cgi?id=396121
https://bugs.gentoo.org/659904

Note that this problem is currently hidden by kxmlgui not building:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32013

I fixed #32013 quick and dirty, reverted the libraw-update and then
krita built again.


We should also check the build status of the other dependencies of
libraw as well:

./pre-inst-env  guix refresh -l libraw

Building the following 17 packages would ensure 22 dependent packages are rebuilt: econnman@1.1 lekha@0.2.1 terminology@1.2.1 edi@0.6.0 enlightenment@0.22.3 python-efl@1.20.0 rage@0.3.0 dbus-c++@0.9.0 shotwell@0.28.0 luminance-hdr@2.4.0 emulation-station@2.0.1 openmw@0.43-1.5bc0736 guile-sly@0.1 perceptualdiff@1.3 darktable@2.4.4 krita@3.3.3 krita@4.1.1


Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

bug#32467: Upgrade of libraw to 0.19 makes krita build fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]

Thanks for looking into this!

Fixed in commit fd67d793c27f4f675708862df59336cb1133ade1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]