From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#32347: gzip cannot be patched Date: Thu, 2 Aug 2018 14:57:18 +0300 Message-ID: <20180802115718.GD13776@macbook41> References: <87muu56m31.fsf@fastmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bi5JUZtvcfApsciF" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flCF5-0003eY-85 for bug-guix@gnu.org; Thu, 02 Aug 2018 07:58:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flCF0-0002p4-CZ for bug-guix@gnu.org; Thu, 02 Aug 2018 07:58:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flCF0-0002oj-78 for bug-guix@gnu.org; Thu, 02 Aug 2018 07:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1flCEz-0006F4-W5 for bug-guix@gnu.org; Thu, 02 Aug 2018 07:58:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <87muu56m31.fsf@fastmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Marius Bakke Cc: 32347@debbugs.gnu.org --bi5JUZtvcfApsciF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 02, 2018 at 01:32:02PM +0200, Marius Bakke wrote: > Hello! >=20 > I'm trying to add a patch to 'gzip', but it causes an infinite loop and > eventually the system runs out of memory. >=20 > It can be reproduced by adding this hunk: >=20 > modified gnu/packages/compression.scm > @@ -215,6 +215,7 @@ adding and extracting files to/from a tar archive.") > (method url-fetch) > (uri (string-append "mirror://gnu/gzip/gzip-" > version ".tar.xz")) > + (snippet '(#t)) > (sha256 > (base32 > "16h8g4acy7fgfxcjacr3wijjsnixwsfd2jhz3zwdi2qrzi262l5f")))) >=20 > [back] >=20 > I guess this is because gzip itself is a patch input. Is this something > that can be fixed, or do we have to use "patching phases" in these cases? Its also in commencement.scm, so that might be the loop instead. You could try "unpatching" it there. It looks like it has a pseudo-package inside of glibc-utf8-locales-final, with grep-final a few packages lower being potential inspiration for undoing the modifications in "real gzip". --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --bi5JUZtvcfApsciF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlti8ZkACgkQQarn3Mo9 g1FoMBAAvYb0JVu/OtB6h/q+z5MBM0/mCVPt/5g99cVyLypygB0Dv8evlCAc1E5c Dsmkco/hoUiA/qYXmEEDB+td5IL6pfd8RVtMca3AyN1aPv6LLBjQoG80V4+dz359 BDNeGNrhgCVwfHi/zCkZVUg+YSb4XVPtA2kJrhkizVqPbXgVCIAOo976jspzj6cK fO8Ox2uHJpGsevp3GPpf64nGNw/Ps4Jv/0KJYlN2W6lIZ7QI46MSphSHOHfePPa8 pbbESvYXK9fjY80OE7lkCw3Dj5oGx7gQfcmCNl14kqWx1xnWwZmCwh//7KY5rBR+ 3SzcR41hKObpfMhZ+u6j0UMbxGm5vU7sTTRibt1zDr56migixtR7p72TTgoqRLtN 2zKP3V/WwurxfhcW/Ftib9z8IQP1mZ249nJkwLLgxFCFxSGkC0yxXwlLkmuLqNtE t6SsLpltf60ELdimvDqT+oZ4maHfHN6EIx8oRtS6eZ5eqyfEFlvI6q3B8x9ySLnE /cL7kYIzNyhw8oVxnYndqdIEza1eTPoibiG3gqXLe3IthVGA8H9q11LegGKMcqkY YXAAS8staqk7wTeCFSGOLk/s4rlEn/6cbi4ewKZEqJzjAeWgGjt1M6CXaMvdGMti LZI81XAkMu4QLt0pt7+h0CEqMPc1rC6qijUHqbci3/NKRgw99jQ= =jNMn -----END PGP SIGNATURE----- --bi5JUZtvcfApsciF--