From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: bug#32126: call-with-temporary-directory rarely cleans up after itself Date: Wed, 11 Jul 2018 14:59:37 -0400 Message-ID: <20180711185937.GA16510@jasmine.lan> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdKLQ-0006jM-S9 for bug-guix@gnu.org; Wed, 11 Jul 2018 15:00:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdKLL-0006qR-5X for bug-guix@gnu.org; Wed, 11 Jul 2018 15:00:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdKLL-0006q6-0k for bug-guix@gnu.org; Wed, 11 Jul 2018 15:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fdKLK-0007UL-Ov for bug-guix@gnu.org; Wed, 11 Jul 2018 15:00:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdKL8-0006ig-Dt for bug-guix@gnu.org; Wed, 11 Jul 2018 14:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdKL4-0006dB-Ii for bug-guix@gnu.org; Wed, 11 Jul 2018 14:59:50 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53911) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fdKL4-0006cg-DN for bug-guix@gnu.org; Wed, 11 Jul 2018 14:59:46 -0400 Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 27EA5E45C9 for ; Wed, 11 Jul 2018 14:59:44 -0400 (EDT) Content-Disposition: inline List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 32126@debbugs.gnu.org --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline While testing something, I noticed that temporary directories created with ((guix utils) call-with-temporary-directory) were not being deleted. This procedure is documented to delete the directories after execution: "Call PROC with a name of a temporary directory; close the directory and delete it when leaving the dynamic extent of this call." It uses rmdir, which is documented as follows: "Remove the existing directory named by path. The directory must be empty for this to succeed." [0] I think this is a case where one expects the directory to be deleted as with `rm -rf`, regardless of whether or not it is empty. Should we alter the call-with-temporary-directory procedure to use ((guix build utils) delete-file-recursively)? [0] https://www.gnu.org/software/guile/manual/html_node/File-System.html#index-rmdir --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAltGU5UACgkQJkb6MLrK fwh8wxAA1wolIirt3aXo1K8Osy1DqBQwmik9gA/eQol4RxWdSc2hH0trux6Z55Lw D5sKWpRsS/s92oT+TNX/raWJ0Wuajc3lxrzCJpKvg1jw58m0vKbVIvYb8Sv66IF7 LfkHeH55/Q0f42HmBG8ONPttb9ZUs/pE+cy1jUZqS8LJPxamhzP10jlarHAUE3aV nAXFwukt3AcN9RvnsfvnwFRlPCmo6Ue+Q3Otm86XE5FXCVq9RGboj3sUXFGWVy1g SzcifNzmnTa31nbuaHlX0WQCefOxosEbnx5cjs8Pzeo5zmTGe7fuJHX9pV7WonRq A5iOKr4g2Mw/I49t1/JFVkoSzquXsWQJvgHdb7MdlhnSXjFEj1KNRyf0MUYcBYh0 LnyG8wX8uW4Hki1/xyRDH6mFMxdOP37K7b6KMrB4jT4JnMyo7E61ea13ksOGIrg5 ZVqCXdJuQh3UwiNhW0OQZfN7b7pvj4fnesEYJArF9sYmt1w9Fnaztmk2AUqtatsA 2HPBW/u8xk3Mzb7mTThKD0vVV7CDFeqCj5o/fx+dEVVvMPXp3YV8nnn4vzRxWhc9 za5F7C/xpEi2w57WHUvOgB+SKvi/hwR4MUHHulbjXIlpbNXkyWkr7Yygwet7tvWq ONxXc4tYdrfIHHX+PKP+ALjxNjvuSqKbp2ke/niNE2S4opFwc0Q= =I5hX -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--