From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#30820: Chunked store references in compiled code break grafting
	(again)
Date: Mon, 19 Mar 2018 22:22:05 +0100
Message-ID: <20180319222205.2e35f26f@scratchpost.org>
References: <87o9jq7j7r.fsf@gnu.org>
	<87efkm7eov.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	boundary="Sig_/3pd6DzVOf2uaP+Xy_IAApRS";
	protocol="application/pgp-signature"
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ey2FH-00047R-9f
	for bug-guix@gnu.org; Mon, 19 Mar 2018 17:23:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ey2FC-0005nQ-C8
	for bug-guix@gnu.org; Mon, 19 Mar 2018 17:23:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34381)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ey2FC-0005nD-9B
	for bug-guix@gnu.org; Mon, 19 Mar 2018 17:23:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30820.B30820.152149453915446@debbugs.gnu.org>
In-Reply-To: <87efkm7eov.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 30820@debbugs.gnu.org

--Sig_/3pd6DzVOf2uaP+Xy_IAApRS
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Ludo,

> The second issue is that the patch only ever worked with literal
> strings.  It does not =E2=80=9Csee=E2=80=9D strings in constant arrays li=
ke the =E2=80=98str=E2=80=99
> array in the example above.
>=20
> The gconv-module file name mentioned in the first message in this bug
> report is an example of a string assigned to a static array, in
> iconv/gconv_conf.c:
>=20
>   /* This is the default path where we look for module lists.  */
>   static const char default_gconv_path[] =3D GCONV_PATH;

I don't understand why this is a problem.  Grafting would just
mutate default_gconv_path, right?  Who cares how the runtime memcpy
works (if there's no literal as source)?

Or do you mean that it memcpys at compile time?

--Sig_/3pd6DzVOf2uaP+Xy_IAApRS
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqwKf0ACgkQ5xo1VCww
uqUYdwgAleW7oQUOv9JYQlQUy9qQtR7eJNFwmndTLjqcOlaJ2PE9Yb0jg7X1ZTGm
A29BKyL14YhV+2GmUeirPZfk4XJlUXMqYiOtqlYIa23h5uYfAtnYjl0Jfln9PJG0
vYewh1Wr6sAHcUghjmy09Vg0Fy1cEj/ydA2WzzeKHJ+qftYWOxctO75cuDsRxdCj
adF3zNMKi25Ro2ovBwf1wYO3vF/UIcwvNCnSQO+rEZlWYcjawCV9WCz8TlRRgfEK
7ZqCMu45So1HDjSAm48pqD195IMNnA142MrcHJPvfc7VU3+fQvQphh4+g5aXqZHX
v8uodHrRZxIefQFE2EFTHz87+beRxw==
=2Gaa
-----END PGP SIGNATURE-----

--Sig_/3pd6DzVOf2uaP+Xy_IAApRS--