From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Subject: bug#30716: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened Date: Mon, 5 Mar 2018 21:29:12 +0100 Message-ID: <20180305212912.625ecf29@alma-ubu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/I0Q=IErw.coJ_FlOFJw4DqB"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eswkK-0003zU-La for bug-guix@gnu.org; Mon, 05 Mar 2018 15:30:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eswkE-0005Bn-ON for bug-guix@gnu.org; Mon, 05 Mar 2018 15:30:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:38371) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eswkE-0005Bg-KW for bug-guix@gnu.org; Mon, 05 Mar 2018 15:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eswkE-0004nT-CK for bug-guix@gnu.org; Mon, 05 Mar 2018 15:30:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eswjZ-0003jT-SL for bug-guix@gnu.org; Mon, 05 Mar 2018 15:29:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eswjW-0004xu-Ll for bug-guix@gnu.org; Mon, 05 Mar 2018 15:29:21 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:51526 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eswjW-0004wN-DP for bug-guix@gnu.org; Mon, 05 Mar 2018 15:29:18 -0500 Received: from alma-ubu (pD951FC9C.dip0.t-ipconnect.de [217.81.252.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 324F940709 for ; Mon, 5 Mar 2018 21:29:14 +0100 (CET) List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 30716@debbugs.gnu.org --Sig_/I0Q=IErw.coJ_FlOFJw4DqB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Guix pull has the wrong error message when the commit-id for the "--commit" parameter is too short: $>guix pull --commit=3Dd20647722ad36024a3a0b6e1e75c1ba49b9f61d Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git error: unable to parse OID - contains invalid characters Instead of that error-message it should complain that the OID is too short. Even better, it should just accept a shortened OID and use it, as long as it is unique. Note: When there really is a wrong character used, this error message is also correctly shown: $>guix pull --commit=3Dd20647722ad36024a3a0b6e1e75c1ba49b9f61dz Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'= ... guix pull: error: Git error: unable to parse OID - contains invalid charact= ers Note: If the OID is long enough and well-formed, but just non-existent, the error message is adequately correct: $> guix pull --commit=3Dd20647722ad36024a3a0b6e1e75c1ba49b9f61dd=20 Updating from Git repository at=20 'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git error: object not found - no match for id (d20647722ad36024a3a0b6e1e75c1ba49b9f61dd) Bj=C3=B6rn --Sig_/I0Q=IErw.coJ_FlOFJw4DqB Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlqdqJgACgkQvyhstlk+X/12HACfW4XDQl4pIrvhJJCTOZ9aUJQ0 zPUAoKDUf03If3R7+vKtf/i4y4KG4+sy =UqPm -----END PGP SIGNATURE----- --Sig_/I0Q=IErw.coJ_FlOFJw4DqB--