bug#30716: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened

bug#30716: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

Guix pull has the wrong error message when the commit-id for the
"--commit" parameter is too short:

$>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61d
Updating from Git repository at
'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git
error: unable to parse OID - contains invalid characters

Instead of that error-message it should complain that the OID is too
short.

Even better, it should just accept a shortened OID and use it, as long
as it is unique.

Note: When there really is a wrong character used, this error message
is also correctly shown:

$>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dz
Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
guix pull: error: Git error: unable to parse OID - contains invalid characters


Note: If the OID is long enough and well-formed, but just non-existent,
the error message is adequately correct:

$> guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dd 
Updating from Git repository at 
'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git
error: object not found - no match for id
(d20647722ad36024a3a0b6e1e75c1ba49b9f61dd)


Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

bug#30716: guix pull: error: Git error: unable to parse OID - contains invalid characters when COMMIT-ID is shortened

[Ludovic Courtès]

Hi Björn,

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:

> $>guix pull --commit=d20647722ad36024a3a0b6e1e75c1ba49b9f61dz
> Updating from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
> guix pull: error: Git error: unable to parse OID - contains invalid characters

This was actually and out-of-bounds read in Guile-Git (!), now fixed:

  https://gitlab.com/guile-git/guile-git/commit/d37a40de69d727529fe2aebb6afcf362bf8e9ba7

Furthermore, ‘guix pull’ now supports short IDs provided a recent-enough
Guile-Git is available:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=95bd9f65a8ee64d17707a76aebc8720bbd961b68

Thanks,
Ludo’.