unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#30667: 'guix system vm' must keep mount_tag-length limited below 32 bytes for --expose and --share
@ 2018-03-01 18:05 Björn Höfling
  2018-03-08 10:56 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Björn Höfling @ 2018-03-01 18:05 UTC (permalink / raw)
  To: 30667

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

I prepared a QEMU VM with:

./pre-inst-env  guix system vm \
--expose=/home/bjoern/digikam-testpool/=/image-pool \
../guix-systems/digikam-test.scm

Starting the VM it complained:

$> /gnu/store/zg5a42vcz4qf6h3yrdrijyaxkbhr967s-run-vm.sh 
qemu-system-x86_64: -virtfs local,path=/home/bjoern/digikam-testpool/,security_model=none,mount_tag=TAG_home_bjoern_digikam-testpool_: mount tag 'TAG_home_bjoern_digikam-testpool_' (33 bytes) is longer than maximum (31 bytes)

I haven't looked into the Guix code, but I suppose there is somewhere
a place where the command line and the '/etc/fstab' file is filled
with the mount tags.

Here we should check the tag-length and shrink it (uniquely) if
it is more than 31 bytes in size.

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#30667: 'guix system vm' must keep mount_tag-length limited below 32 bytes for --expose and --share
  2018-03-01 18:05 bug#30667: 'guix system vm' must keep mount_tag-length limited below 32 bytes for --expose and --share Björn Höfling
@ 2018-03-08 10:56 ` Ludovic Courtès
  2018-03-10 14:46   ` Björn Höfling
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2018-03-08 10:56 UTC (permalink / raw)
  To: Björn Höfling; +Cc: 30667-done

Hi Björn,

Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:

> I prepared a QEMU VM with:
>
> ./pre-inst-env  guix system vm \
> --expose=/home/bjoern/digikam-testpool/=/image-pool \
> ../guix-systems/digikam-test.scm
>
> Starting the VM it complained:
>
> $> /gnu/store/zg5a42vcz4qf6h3yrdrijyaxkbhr967s-run-vm.sh 
> qemu-system-x86_64: -virtfs local,path=/home/bjoern/digikam-testpool/,security_model=none,mount_tag=TAG_home_bjoern_digikam-testpool_: mount tag 'TAG_home_bjoern_digikam-testpool_' (33 bytes) is longer than maximum (31 bytes)

Fixed in dffc5ab5e47e45b94188828205c8d567994926ad, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#30667: 'guix system vm' must keep mount_tag-length limited below 32 bytes for --expose and --share
  2018-03-08 10:56 ` Ludovic Courtès
@ 2018-03-10 14:46   ` Björn Höfling
  0 siblings, 0 replies; 3+ messages in thread
From: Björn Höfling @ 2018-03-10 14:46 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 30667-done

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

On Thu, 08 Mar 2018 11:56:57 +0100
ludo@gnu.org (Ludovic Courtès) wrote:

> Hi Björn,
> 
> Björn Höfling <bjoern.hoefling@bjoernhoefling.de> skribis:
> 
> > I prepared a QEMU VM with:
> >
> > ./pre-inst-env  guix system vm \
> > --expose=/home/bjoern/digikam-testpool/=/image-pool \
> > ../guix-systems/digikam-test.scm
> >
> > Starting the VM it complained:
> >  
> > $> /gnu/store/zg5a42vcz4qf6h3yrdrijyaxkbhr967s-run-vm.sh   
> > qemu-system-x86_64: -virtfs
> > local,path=/home/bjoern/digikam-testpool/,security_model=none,mount_tag=TAG_home_bjoern_digikam-testpool_:
> > mount tag 'TAG_home_bjoern_digikam-testpool_' (33 bytes) is longer
> > than maximum (31 bytes)  
> 
> Fixed in dffc5ab5e47e45b94188828205c8d567994926ad, thanks!
> 
> Ludo’.

Tested. Works. Thanks for fixing it!

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-10 14:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 18:05 bug#30667: 'guix system vm' must keep mount_tag-length limited below 32 bytes for --expose and --share Björn Höfling
2018-03-08 10:56 ` Ludovic Courtès
2018-03-10 14:46   ` Björn Höfling

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).