From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#30311: efi-less grub install fails
Date: Thu, 1 Feb 2018 00:34:14 +0100
Message-ID: <20180201003414.4a535dec@scratchpost.org>
References: <idjmv0t503l.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eh1uD-0003BO-Pf
	for bug-guix@gnu.org; Wed, 31 Jan 2018 18:35:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eh1uA-0005cj-J5
	for bug-guix@gnu.org; Wed, 31 Jan 2018 18:35:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:43764)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eh1uA-0005cY-Fy
	for bug-guix@gnu.org; Wed, 31 Jan 2018 18:35:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eh1uA-0006sB-6y
	for bug-guix@gnu.org; Wed, 31 Jan 2018 18:35:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30311.B30311.151744166226364@debbugs.gnu.org>
In-Reply-To: <idjmv0t503l.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: 30311@debbugs.gnu.org

Hi Ricardo,

On Wed, 31 Jan 2018 19:55:58 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> =E2=80=9Cguix system init=E2=80=9D fails with a configuration file that s=
pecifies
> grub-bootloader (not grub-efi-bootloader).
>=20
> =E2=80=9Cgrub-install=E2=80=9D reports an error about =E2=80=9Clib/grub/x=
86_64-efi/modinfo.sh=E2=80=9D
> not being available.  It suggests passing =E2=80=9C--target=E2=80=9D or =
=E2=80=9C--device=E2=80=9D.
>=20
> Our invocation of grub-install does not include a =E2=80=9C--target=E2=80=
=9D argument.
> Only after I edited it to pass =E2=80=9C--target=3Di386-pc=E2=80=9D did =
=E2=80=9Cguix system init=E2=80=9D
> pass.

Hmm, I wonder what happened here.

We've been very careful to keep grub and grub-efi separate.

The entire directory lib/grub/x86_64-efi shouldn't be available in the
"grub" package output - and I checked on master, it isn't.  Good.

So that leaves automatic target selection as the culprit.

And indeed, there's a call to grub_install_get_default_x86_platform
in util/grub-install.c .  And that checks for availability of
/sys/firmware/efi and if it exists, defaults to EFI.

I think it's a bug in grub to do that for a grub which doesn't have EFI
platform support. :P

We could just always pass i386-pc in install-grub for i386, but then
we lose i386-ieee1275 (which I have never heard anyone using so maybe
not so bad).

Please report a bug with grub...