From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#30113: SVN checkouts without descriptive file names
Date: Sun, 14 Jan 2018 17:53:11 +0100
Message-ID: <20180114175311.3d463379@scratchpost.org>
References: <20180114160253.GA17578@jasmine.lan>
	<CAE4v=piHf9rRCeNVzRwcq+6unQx5pU0hz=qPb0OwWtqZUfLV2A@mail.gmail.com>
	<04cea8f4-3bee-9992-2e9e-b5c2e25ca5a8@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38101)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ealXp-00087J-RQ
	for bug-guix@gnu.org; Sun, 14 Jan 2018 11:54:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ealXm-0001DG-QO
	for bug-guix@gnu.org; Sun, 14 Jan 2018 11:54:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48328)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ealXm-0001D8-MV
	for bug-guix@gnu.org; Sun, 14 Jan 2018 11:54:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ealXm-00080Y-FI
	for bug-guix@gnu.org; Sun, 14 Jan 2018 11:54:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.30113.B30113.151594879830729@debbugs.gnu.org>
In-Reply-To: <04cea8f4-3bee-9992-2e9e-b5c2e25ca5a8@tobias.gr>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 30113@debbugs.gnu.org

On Sun, 14 Jan 2018 17:43:27 +0100
Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> G=C3=A1bor Boskovits wrote on 14/01/18 at 17:13:
> > Maybe we could use guix to check for these, and some
> > other things could also be spotted.
> > WDYT? =20
>=20
> Agreed, I think.

Yeah, +1

> We should be able to improve the quality of these guesses: the
> repository URI is about as likely to be foo://bar/<package>... as a
> regular tarball URI.
>=20
> Or we make a file-name mandatory for certain methods.

I agree that some heuristics to figure out the file-name from (svn-referenc=
e-url ref) would be nice.

It's not that important that the store filenames are meaningful to humans, =
it's just nice-to-have.  So I'd say heuristic it and be done with it.

On second thought, maybe even default file-name to the Guix package name (i=
f possible at this point in Guix).  The hash value will make it unique rega=
rdless (for example if there are multiple svn-download blocks in the same p=
ackage)