From: Danny Milosavljevic <dannym@scratchpost.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 30113@debbugs.gnu.org
Subject: bug#30113: SVN checkouts without descriptive file names
Date: Sun, 14 Jan 2018 17:53:11 +0100 [thread overview]
Message-ID: <20180114175311.3d463379@scratchpost.org> (raw)
In-Reply-To: <04cea8f4-3bee-9992-2e9e-b5c2e25ca5a8@tobias.gr>
On Sun, 14 Jan 2018 17:43:27 +0100
Tobias Geerinckx-Rice <me@tobias.gr> wrote:
> Gábor Boskovits wrote on 14/01/18 at 17:13:
> > Maybe we could use guix to check for these, and some
> > other things could also be spotted.
> > WDYT?
>
> Agreed, I think.
Yeah, +1
> We should be able to improve the quality of these guesses: the
> repository URI is about as likely to be foo://bar/<package>... as a
> regular tarball URI.
>
> Or we make a file-name mandatory for certain methods.
I agree that some heuristics to figure out the file-name from (svn-reference-url ref) would be nice.
It's not that important that the store filenames are meaningful to humans, it's just nice-to-have. So I'd say heuristic it and be done with it.
On second thought, maybe even default file-name to the Guix package name (if possible at this point in Guix). The hash value will make it unique regardless (for example if there are multiple svn-download blocks in the same package)
next prev parent reply other threads:[~2018-01-14 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 16:02 bug#30113: SVN checkouts without descriptive file names Leo Famulari
2018-01-14 16:13 ` Gábor Boskovits
2018-01-14 16:43 ` Tobias Geerinckx-Rice
2018-01-14 16:53 ` Danny Milosavljevic [this message]
2018-01-14 17:43 ` Gábor Boskovits
2018-01-14 19:28 ` Gábor Boskovits
2018-01-14 19:34 ` Tobias Geerinckx-Rice
2019-02-25 23:50 ` Leo Famulari
2018-01-14 16:32 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114175311.3d463379@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=30113@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).