bug#29485: perl-geo-ip has /usr/share/ within the code

bug#29485: perl-geo-ip has /usr/share/ within the code

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

I'm searching for a good solution to analyze some logs. Geo::IP
is good enough. Now the problem is this:

user@abyayala /gnu/store/5mhrli41qbcpns3gg0yf1vv07lvpg8hm-perl-geo-ip-1.51$ egrep -nr "/usr/" lib/perl5/site_perl/5.26.0/
lib/perl5/site_perl/5.26.0/Geo/IP/Record.pod:9:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
lib/perl5/site_perl/5.26.0/Geo/IP.pm:5075:# default path /usr/local/share/GeoIP
lib/perl5/site_perl/5.26.0/Geo/IP.pm:5159:    my $def_db_file = '/usr/local/share/GeoIP/GeoIP.dat';
lib/perl5/site_perl/5.26.0/Geo/IP.pm:5962:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
lib/perl5/site_perl/5.26.0/Geo/IP.pm:5984:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;
lib/perl5/site_perl/5.26.0/Geo/IP.pm:6046:I<datadir>, typically I</usr/local/share/GeoIP/GeoIP.dat>.
lib/perl5/site_perl/5.26.0/Geo/IP.pm:6078:typically I</usr/local/share/GeoIP/GeoIPCity.dat>.
lib/perl5/site_perl/5.26.0/Geo/IP.pm:6226:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;

However this is not really a problem unless you are on GuixSD.
As we do not package the DB of MaxDB (yet) you'll need for this, it's
not a problem. I'm filing this bug to remind myself to fix Geo::IP once
I have revisited the discussion we had about the DB a while back.
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29485: perl-geo-ip has /usr/share/ within the code

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]

ng0 transcribed 2.5K bytes:
> I'm searching for a good solution to analyze some logs. Geo::IP
> is good enough. Now the problem is this:
> 
> user@abyayala /gnu/store/5mhrli41qbcpns3gg0yf1vv07lvpg8hm-perl-geo-ip-1.51$ egrep -nr "/usr/" lib/perl5/site_perl/5.26.0/
> lib/perl5/site_perl/5.26.0/Geo/IP/Record.pod:9:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5075:# default path /usr/local/share/GeoIP
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5159:    my $def_db_file = '/usr/local/share/GeoIP/GeoIP.dat';
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5962:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5984:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6046:I<datadir>, typically I</usr/local/share/GeoIP/GeoIP.dat>.
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6078:typically I</usr/local/share/GeoIP/GeoIPCity.dat>.
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6226:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;
> 
> However this is not really a problem unless you are on GuixSD.
> As we do not package the DB of MaxDB (yet) you'll need for this, it's
> not a problem. I'm filing this bug to remind myself to fix Geo::IP once
> I have revisited the discussion we had about the DB a while back.
> -- 
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
>   WWW: https://n0.is

They comment this in the file:
# --- unfortunately we do not know the path so we assume the
# default path /usr/local/share/GeoIP
# if thats not true, you can set $Geo::IP::PP_OPEN_TYPE_PATH

But I think we should fix it once we have the data set.
WDYT?
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29485: perl-geo-ip is broken since ever!

[zimoun]

Hi,

The old bug #29485 is about the hard coded database of the package
perl-geo-ip.

   <http://issues.guix.gnu.org/issue/29485>
   
On Tue, 28 Nov 2017 at 15:41, ng0 <ng0@n0.is> wrote:

> user@abyayala /gnu/store/5mhrli41qbcpns3gg0yf1vv07lvpg8hm-perl-geo-ip-1.51$ egrep -nr "/usr/" lib/perl5/site_perl/5.26.0/
> lib/perl5/site_perl/5.26.0/Geo/IP/Record.pod:9:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5075:# default path /usr/local/share/GeoIP
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5159:    my $def_db_file = '/usr/local/share/GeoIP/GeoIP.dat';
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5962:  my $gi = Geo::IP->open("/usr/local/share/GeoIP/GeoIPCity.dat", GEOIP_STANDARD);
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:5984:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6046:I<datadir>, typically I</usr/local/share/GeoIP/GeoIP.dat>.
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6078:typically I</usr/local/share/GeoIP/GeoIPCity.dat>.
> lib/perl5/site_perl/5.26.0/Geo/IP.pm:6226:  my $g = Geo::IP->open('/usr/local/share/GeoIP/GeoIPv6.dat') or die;

I am reproducing this with the Guix commit f4450e8.


> However this is not really a problem unless you are on GuixSD.
> As we do not package the DB of MaxDB (yet) you'll need for this, it's
> not a problem. I'm filing this bug to remind myself to fix Geo::IP once
> I have revisited the discussion we had about the DB a while back.

It is a problem and the package is broken.  I am assuming this package
is not used so I am proposing to simply remove it.  Otherwise, the
database should be also packaged, else it appears to me meaningless.


All the best,
simon

bug#29485: perl-geo-ip is broken since ever!

[Leo Famulari]

On Thu, Dec 03, 2020 at 01:34:23AM +0100, zimoun wrote:
> It is a problem and the package is broken.  I am assuming this package
> is not used so I am proposing to simply remove it.  Otherwise, the
> database should be also packaged, else it appears to me meaningless.

Removal sounds good to me.

bug#29485: perl-geo-ip is broken since ever!

[zimoun]

Hi,

On Thu, 03 Dec 2020 at 01:08, Leo Famulari <leo@famulari.name> wrote:
> On Thu, Dec 03, 2020 at 01:34:23AM +0100, zimoun wrote:
>> It is a problem and the package is broken.  I am assuming this package
>> is not used so I am proposing to simply remove it.  Otherwise, the
>> database should be also packaged, else it appears to me meaningless.
>
> Removal sounds good to me.

See 45372.  Once merged, let close this one.


All the best,
simon

bug#29485: perl-geo-ip is broken since ever!

[Leo Famulari]

On Tue, Dec 22, 2020 at 06:00:38PM +0100, zimoun wrote:
> Hi,
> 
> On Thu, 03 Dec 2020 at 01:08, Leo Famulari <leo@famulari.name> wrote:
> > On Thu, Dec 03, 2020 at 01:34:23AM +0100, zimoun wrote:
> >> It is a problem and the package is broken.  I am assuming this package
> >> is not used so I am proposing to simply remove it.  Otherwise, the
> >> database should be also packaged, else it appears to me meaningless.
> >
> > Removal sounds good to me.
> 
> See 45372.  Once merged, let close this one.

Done with commit 06de9ca75f4bb508cdba3082d8ae80f014dbc38b

bug#29485: perl-geo-ip is broken since ever!

[zimoun]

On Tue, 22 Dec 2020 at 14:24, Leo Famulari <leo@famulari.name> wrote:
> On Tue, Dec 22, 2020 at 06:00:38PM +0100, zimoun wrote:
>> Hi,
>> 
>> On Thu, 03 Dec 2020 at 01:08, Leo Famulari <leo@famulari.name> wrote:
>> > On Thu, Dec 03, 2020 at 01:34:23AM +0100, zimoun wrote:
>> >> It is a problem and the package is broken.  I am assuming this package
>> >> is not used so I am proposing to simply remove it.  Otherwise, the
>> >> database should be also packaged, else it appears to me meaningless.
>> >
>> > Removal sounds good to me.
>> 
>> See 45372.  Once merged, let close this one.
>
> Done with commit 06de9ca75f4bb508cdba3082d8ae80f014dbc38b

Thanks!