From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: bug#27811: net-tools patch has no effect? Date: Tue, 25 Jul 2017 00:12:25 -0400 Message-ID: <20170725041225.GA31642@jasmine.lan> References: <20170724220201.GA6136@jasmine.lan> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZrDV-0001t9-Ts for bug-guix@gnu.org; Tue, 25 Jul 2017 00:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZrDS-00089u-KN for bug-guix@gnu.org; Tue, 25 Jul 2017 00:13:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dZrDS-00089l-0J for bug-guix@gnu.org; Tue, 25 Jul 2017 00:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dZrDR-0004xY-OQ for bug-guix@gnu.org; Tue, 25 Jul 2017 00:13:01 -0400 In-Reply-To: <20170724220201.GA6136@jasmine.lan> Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 27811@debbugs.gnu.org --/04w6evG8XlLl3ft Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable The problem is that, in the patch phase, the patch file is referred to as 'patch', but the package for the `patch` program is what that variable resolves to: (let ((patch.gz (assoc-ref inputs "patch"))) After fixing that by renaming the variable for the patch file to something unique, the build fails like this: ------ gcc -D_GNU_SOURCE -O2 -Wall -g -I. -idirafter ./include/ -Ilib -c -o ipm= addr.o ipmaddr.c ipmaddr.c: In function =E2=80=98multiaddr_modify=E2=80=99: ipmaddr.c:351:25: warning: pointer targets in passing argument 2 of =E2=80= =98parse_lla=E2=80=99 differ in signedness [-Wpointer-sign] if (parse_lla(*argv, ifr.ifr_hwaddr.sa_data) < 0) ^ ipmaddr.c:78:12: note: expected =E2=80=98unsigned char *=E2=80=99 but argum= ent is of type =E2=80=98char *=E2=80=99 static int parse_lla(char *str, unsigned char *addr) ^ gcc -Llib -o ipmaddr ipmaddr.o -lnet-tools=20 gcc -D_GNU_SOURCE -O2 -Wall -g -I. -idirafter ./include/ -Ilib -c -o mii= -tool.o mii-tool.c mii-tool.c: In function =E2=80=98main=E2=80=99: mii-tool.c:432:29: error: too few arguments to function =E2=80=98parse_medi= a=E2=80=99 case 'A': nway_advertise =3D parse_media(optarg); break; ^ mii-tool.c:163:12: note: declared here static int parse_media(char *arg, unsigned *bmcr2) ^ mii-tool.c:433:26: error: too few arguments to function =E2=80=98parse_medi= a=E2=80=99 case 'F': fixed_speed =3D parse_media(optarg); break; ^ mii-tool.c:163:12: note: declared here static int parse_media(char *arg, unsigned *bmcr2) ^ mii-tool.c:456:2: warning: implicit declaration of function =E2=80=98versio= n=E2=80=99 [-Wimplicit-function-declaration] version(); ^ mii-tool.c: At top level: mii-tool.c:32:13: warning: =E2=80=98Version=E2=80=99 defined but not used [= -Wunused-variable] static char Version[] =3D "$Id: mii-tool.c,v 1.9 2006/09/27 20:59:18 ecki = Exp $\n(Author: David Hinds based on Donald Becker's mii-diag)"; ^ make: *** [: mii-tool.o] Error 1 phase `build' failed after 7.5 seconds ------ This problem with the wrong number of arguments being passed to parse_media() is introduced in the Debian patch, so we should check if there is a better version of the patch or if fixes are being applied upstream. --/04w6evG8XlLl3ft Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAll2xSYACgkQJkb6MLrK fwi2wQ//SZ1JxoI+jzblv8C7N3mvREvep6SyawqNg8PY2K46EXl9kA6mqOW2oGAq wHOOJAFob7IA96+oWJhnNyM7X6k8zCK+mTxoNXozpIxtZVl7wx+Gx9C6FUukG8Mn uUSWBFHwymF8AAwmu8w3N91GXPl6EbySfSOJBtDasVzUMEVgzwNNpWmeZmjJiiZC FHWWliIAnLKh56J4McuDOQKqw4ombzj+LUZODGxYvbKzOoQIvvSPVNiILn1wBaSL PKVP67q84M54TNHocVLjYTLPenEI1ObkIfXe3DnfHAOjFGfEREuOTOcx8ilolSmt dASk3qGljQwCnCcezzo7SXzW25sbYNJBLDRcxVePyOM2nmT5JcNE73Cnv0YhIlmh 6eHz76L9TEAHXx94w0PAiViZ4tFtT8De6zLGFOGIGyhnIIX3u/WKGUDMbpAvGAqx 2y9gTmCIo473ysUQISE1CPmSoMlw0TeGxX1972VP/Nqx/G3PAkU/tjI4NBOFL7ZE PgZdHwdSIpWNP/99+myPFrCeqXi3/kblCEsrqksxI3k4MncwErd+BCAr/oXIZYqB ywQ6ISZwgXM2489u5CswU+U3OZpO4PaklF5s3fK4WqLmpA5JNQR10EmcOQRGCDLG IYykzk77r8mcPfsQewNzyDwqe41IlUVmDiScg8dBpzSmenqN4Ys= =uy9D -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft--