bug#27556: libpng has wrong hash.

bug#27556: libpng has wrong hash.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

I don't know if they moved the file around, renamed it or
whatever, but the hash is now
"0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab".
We should use this in icecat as intended (I use it for
firefox nightly I work on) so that these errors get
attention.

@ build-started /gnu/store/l2ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv - x86_64-linux /var/log/guix/drvs/l2//ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv.bz2

Starting download of /gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz
From http://downloads.sourceforge.net/project/libpng-apng/libpng16/1.6.28/libpng-1.6.28-apng.patch.gz...
following redirection to `https://netix.dl.sourceforge.net/project/libpng-apng/libpng16/1.6.28/libpng-1.6.28-apng.patch.gz'...
 ...-apng.patch.gz  11KiB           1.2MiB/s 00:00 [####################] 100.0%
sha256 hash mismatch for output path `/gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz'
  expected: 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
  actual:   0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
@ build-failed /gnu/store/l2ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv - 1 sha256 hash mismatch for output path `/gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz'
  expected: 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
  actual:   0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
cannot build derivation `/gnu/store/x1dqpvyjz4v25z4al6kll6i3n3whv9h3-libpng-apng-1.6.28.drv': 1 dependencies couldn't be built
guix build: error: build failed: build of `/gnu/store/x1dqpvyjz4v25z4al6kll6i3n3whv9h3-libpng-apng-1.6.28.drv' failed


-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

On Sun, Jul 02, 2017 at 08:13:44PM +0000, ng0 wrote:
> I don't know if they moved the file around, renamed it or
> whatever, but the hash is now
> "0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab".
> We should use this in icecat as intended (I use it for
> firefox nightly I work on) so that these errors get
> attention.
> 
> @ build-started /gnu/store/l2ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv - x86_64-linux /var/log/guix/drvs/l2//ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv.bz2
> 
> Starting download of /gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz
> From http://downloads.sourceforge.net/project/libpng-apng/libpng16/1.6.28/libpng-1.6.28-apng.patch.gz...
> following redirection to `https://netix.dl.sourceforge.net/project/libpng-apng/libpng16/1.6.28/libpng-1.6.28-apng.patch.gz'...
>  ...-apng.patch.gz  11KiB           1.2MiB/s 00:00 [####################] 100.0%
> sha256 hash mismatch for output path `/gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz'
>   expected: 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
>   actual:   0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
> @ build-failed /gnu/store/l2ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv - 1 sha256 hash mismatch for output path `/gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz'
>   expected: 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
>   actual:   0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
> cannot build derivation `/gnu/store/x1dqpvyjz4v25z4al6kll6i3n3whv9h3-libpng-apng-1.6.28.drv': 1 dependencies couldn't be built
> guix build: error: build failed: build of `/gnu/store/x1dqpvyjz4v25z4al6kll6i3n3whv9h3-libpng-apng-1.6.28.drv' failed

Clarification: This is libpng-apng, not libpng.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 2181 bytes --]

Leo Famulari transcribed 2.9K bytes:
> On Sun, Jul 02, 2017 at 08:13:44PM +0000, ng0 wrote:
> > I don't know if they moved the file around, renamed it or
> > whatever, but the hash is now
> > "0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab".
> > We should use this in icecat as intended (I use it for
> > firefox nightly I work on) so that these errors get
> > attention.
> > 
> > @ build-started /gnu/store/l2ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv - x86_64-linux /var/log/guix/drvs/l2//ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv.bz2
> > 
> > Starting download of /gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz
> > From http://downloads.sourceforge.net/project/libpng-apng/libpng16/1.6.28/libpng-1.6.28-apng.patch.gz...
> > following redirection to `https://netix.dl.sourceforge.net/project/libpng-apng/libpng16/1.6.28/libpng-1.6.28-apng.patch.gz'...
> >  ...-apng.patch.gz  11KiB           1.2MiB/s 00:00 [####################] 100.0%
> > sha256 hash mismatch for output path `/gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz'
> >   expected: 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
> >   actual:   0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
> > @ build-failed /gnu/store/l2ajzgighkr23qhyrqzy3qm64gy7v75y-libpng-1.6.28-apng.patch.gz.drv - 1 sha256 hash mismatch for output path `/gnu/store/lsgx25nk7cg24hn6cn898jrkhs8aily3-libpng-1.6.28-apng.patch.gz'
> >   expected: 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
> >   actual:   0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
> > cannot build derivation `/gnu/store/x1dqpvyjz4v25z4al6kll6i3n3whv9h3-libpng-apng-1.6.28.drv': 1 dependencies couldn't be built
> > guix build: error: build failed: build of `/gnu/store/x1dqpvyjz4v25z4al6kll6i3n3whv9h3-libpng-apng-1.6.28.drv' failed
> 
> Clarification: This is libpng-apng, not libpng.

Right, my mistake. It still is wrong, and that's
been the case for at least 3 weeks.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: Fix for bug#27556

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 328 bytes --]

Appended. I haven't asked upstream why it changed
all I know is that I am currently packaging software
which depends on this library and I'd like to drop
my local correction.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #1.2: 0001-gnu-libpng-apng-Correct-the-hash.patch --]
[-- Type: text/plain, Size: 1483 bytes --]

From 40764bb662ff7534f6e7afa55bfb709bfef19e49 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Wed, 12 Jul 2017 15:20:36 +0000
Subject: [PATCH] gnu: libpng-apng: Correct the hash.

Fixes <http://bugs.gnu.org/27556>.

* gnu/packages/image.scm (libpng-apng)[source]: Correct the hash.
---
 gnu/packages/image.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 139be6281..3ae1072e2 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2016, 2017 Kei Kebreau <kei@openmailbox.org>
-;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -126,7 +126,7 @@ library.  It supports almost all PNG features and is extensible.")
                                   version "/libpng-" version "-apng.patch.gz"))
                   (sha256
                    (base32
-                    "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5"))))))
+                    "0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab"))))))
     (native-inputs
      `(("libtool" ,libtool)))
     (synopsis "APNG patch for libpng")
-- 
2.13.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: Fix for bug#27556

[ng0]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

ng0 transcribed 3.1K bytes:
> Appended. I haven't asked upstream why it changed
> all I know is that I am currently packaging software
> which depends on this library and I'd like to drop
> my local correction.

I have sent an email to the upstream maintainer, asking why the hash has
been changed in place.

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[ng0]

[-- Attachment #1: Type: text/plain, Size: 2155 bytes --]

----- Forwarded message -----

> Date: Sun, 23 Jul 2017 18:21:19 +0900 (JST)
> To: ng0
> Cc: daisuken@users.sourceforge.net
> Subject: Re: why has the hash for libpng-apng 1.6.28 changed?
> 
> Hi,
> 
> I calculated the hash for libpng-apng files on my local orignals.
> 
> md5sum
> 9f2b36bccf89c5f4097111f0f73c1798  libpng-1.6.28-apng.patch.README.txt
> fca7c6d87c8352e645facefc2e1dd153  libpng-1.6.28-apng.patch.gz
> 
> sha1sum
> cb620589ecf9c28a4ecc00e6225dd41ca660a959  libpng-1.6.28-apng.patch.README.txt
> 4fa952f5ad374fce8d478b7e54ee4298a0b8d159  libpng-1.6.28-apng.patch.gz
> 
> Local file time stamps are
> 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.README.txt
> 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.gz
> 
> That values equals on sourceforge.net.
> https://sourceforge.net/projects/libpng-apng/files/libpng16/1.6.28/
> 
> I don't really understand what happend, but it look just fine.
> 
> Cheers,
> ---
> daisuken@users.sourceforge.net
> 
> 
> From: ng0
> Subject: why has the hash for libpng-apng 1.6.28 changed?
> Date: Sat, 22 Jul 2017 09:06:28 +0000
> Message-ID: <20170722090628.rvnmyvafhkgrnl7t@abyayala>
> 
> ng0> Hi,
> ng0> 
> ng0> I noticed that the hash for libpng-apng at the source changed, for version 1.6.28.
> ng0> 
> ng0> Can you tell me what happened? As libpng-apng is a recent addition in our
> ng0> system (GNU Guix) I'm not yet aware of any bad or good practices or the
> ng0> lack of them libpng-apng applies.
> ng0> My current guess is that you changed the tarball in place, or that
> ng0> Sourceforge changed it in place. We'll diff the tarball contents and see
> ng0> what changed, but a maintainers reply will also be good.
> ng0> 
> ng0> Greetings,
> ng0> -- 
> ng0> ng0
> ng0> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> ng0> GnuPG: https://n0is.noblogs.org/my-keys
> ng0> https://www.infotropique.org https://krosos.org
> 

----- End forwarded message -----

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

On Sun, Jul 23, 2017 at 10:15:47AM +0000, ng0 wrote:
> ----- Forwarded message -----
> 
> > Date: Sun, 23 Jul 2017 18:21:19 +0900 (JST)
> > To: ng0
> > Cc: daisuken@users.sourceforge.net
> > Subject: Re: why has the hash for libpng-apng 1.6.28 changed?
> > 
> > Hi,
> > 
> > I calculated the hash for libpng-apng files on my local orignals.
> > 
> > md5sum
> > 9f2b36bccf89c5f4097111f0f73c1798  libpng-1.6.28-apng.patch.README.txt
> > fca7c6d87c8352e645facefc2e1dd153  libpng-1.6.28-apng.patch.gz
> > 
> > sha1sum
> > cb620589ecf9c28a4ecc00e6225dd41ca660a959  libpng-1.6.28-apng.patch.README.txt
> > 4fa952f5ad374fce8d478b7e54ee4298a0b8d159  libpng-1.6.28-apng.patch.gz
> > 
> > Local file time stamps are
> > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.README.txt
> > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.gz
> > 
> > That values equals on sourceforge.net.
> > https://sourceforge.net/projects/libpng-apng/files/libpng16/1.6.28/
> > 
> > I don't really understand what happend, but it look just fine.
> > 
> > Cheers,
> > ---
> > daisuken@users.sourceforge.net

Okay, this doesn't help us, so we need to inspect the different tarballs
ourselves. Do you have an old copy of the patch you can share?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[ng0]

[-- Attachment #1: Type: text/plain, Size: 9945 bytes --]

Leo Famulari transcribed 2.3K bytes:
> On Sun, Jul 23, 2017 at 10:15:47AM +0000, ng0 wrote:
> > ----- Forwarded message -----
> > 
> > > Date: Sun, 23 Jul 2017 18:21:19 +0900 (JST)
> > > To: ng0
> > > Cc: daisuken@users.sourceforge.net
> > > Subject: Re: why has the hash for libpng-apng 1.6.28 changed?
> > > 
> > > Hi,
> > > 
> > > I calculated the hash for libpng-apng files on my local orignals.
> > > 
> > > md5sum
> > > 9f2b36bccf89c5f4097111f0f73c1798  libpng-1.6.28-apng.patch.README.txt
> > > fca7c6d87c8352e645facefc2e1dd153  libpng-1.6.28-apng.patch.gz
> > > 
> > > sha1sum
> > > cb620589ecf9c28a4ecc00e6225dd41ca660a959  libpng-1.6.28-apng.patch.README.txt
> > > 4fa952f5ad374fce8d478b7e54ee4298a0b8d159  libpng-1.6.28-apng.patch.gz
> > > 
> > > Local file time stamps are
> > > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.README.txt
> > > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.gz
> > > 
> > > That values equals on sourceforge.net.
> > > https://sourceforge.net/projects/libpng-apng/files/libpng16/1.6.28/
> > > 
> > > I don't really understand what happend, but it look just fine.
> > > 
> > > Cheers,
> > > ---
> > > daisuken@users.sourceforge.net
> 
> Okay, this doesn't help us, so we need to inspect the different tarballs
> ourselves. Do you have an old copy of the patch you can share?

Yes. I mean no. I am not sure. I have libpng-apng git checkout
and also the 1.6.25 extracted tarball directory (but not sure
when I got it), and the tarballs for 1.6.5 and 1.6.28.

But I think I found our problem:

user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.28-apng.patch.gz
0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.25-apng.patch.gz
026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5

(inputs
 `(("apng" ,(origin
    (method url-fetch)
     (uri
     (string-append "mirror://sourceforge/libpng-apng/libpng16/"
     version "/libpng-" version "-apng.patch.gz"))
     (sha256
     (base32
     "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5"))))))

My really strong guess is that we never updated the hash for
libpng-apng when the libpng was updated fron which libpng-apng
inherits its version.

I don't have the time to look at our git history right now,
but you could do that, look at wether libpng-apng was touched
since 1.6.25->1.6.28 update of libpng.

user@shadownet ~/re-src$ ls -al *png* ; ls -al tarballs/*png*
libpng-1.6.25:
total 3416
drwxr-xr-x   8 user users   4096 Mar 24 14:51 ./
drwxr-xr-x 282 user users  12288 Jul 22 09:39 ../
-rw-r--r--   1 user users  44739 Sep  1  2016 aclocal.m4
-rw-r--r--   1 user users   1207 Sep  1  2016 ANNOUNCE
drwxr-xr-x   2 user users   4096 Mar 24 14:51 arm/
-rwxr-xr-x   1 user users   7979 Aug  3  2015 autogen.sh
-rw-r--r--   1 user users 285838 Sep  1  2016 CHANGES
-rw-r--r--   1 user users  30349 Sep  1  2016 CMakeLists.txt
-rwxr-xr-x   1 user users   7333 Feb 21  2015 compile
-rwxr-xr-x   1 user users  42938 Feb 21  2015 config.guess
-rw-r--r--   1 user users   3307 Sep  1  2016 config.h.in
-rwxr-xr-x   1 user users  35987 Feb 21  2015 config.sub
-rwxr-xr-x   1 user users 477565 Sep  1  2016 configure
-rw-r--r--   1 user users  14688 Sep  1  2016 configure.ac
drwxr-xr-x  15 user users   4096 Mar 24 14:51 contrib/
-rwxr-xr-x   1 user users  23566 Feb 21  2015 depcomp
-rw-r--r--   1 user users  40303 Sep  1  2016 example.c
-rw-r--r--   1 user users  17971 Sep  1  2016 INSTALL
-rwxr-xr-x   1 user users  14675 Feb 21  2015 install-sh
-rw-r--r--   1 user users 270700 Sep  1  2016 libpng.3
-rw-r--r--   1 user users   2396 Sep  1  2016 libpng-config.in
-rw-r--r--   1 user users 228244 Sep  1  2016 libpng-manual.txt
-rw-r--r--   1 user users    293 Sep  1  2016 libpng.pc.in
-rw-r--r--   1 user users    764 Sep  1  2016 libpngpf.3
-rw-r--r--   1 user users   4937 Sep  1  2016 LICENSE
-rw-r--r--   1 user users 324089 Sep  1  2016 ltmain.sh
-rw-r--r--   1 user users  13620 Sep  1  2016 Makefile.am
-rw-r--r--   1 user users  89190 Sep  1  2016 Makefile.in
drwxr-xr-x   2 user users   4096 Mar 24 14:51 mips/
-rwxr-xr-x   1 user users   6872 Feb 21  2015 missing
-rw-r--r--   1 user users   2432 Sep  1  2016 png.5
-rw-r--r--   1 user users   2498 Jul 12  2000 pngbar.jpg
-rw-r--r--   1 user users   2399 Jul 12  2000 pngbar.png
-rw-r--r--   1 user users 155048 Sep  1  2016 png.c
-rw-r--r--   1 user users  22842 Sep  1  2016 pngconf.h
-rw-r--r--   1 user users   5368 Sep  1  2016 pngdebug.h
-rw-r--r--   1 user users  29224 Sep  1  2016 pngerror.c
-rw-r--r--   1 user users  33379 Sep  1  2016 pngget.c
-rw-r--r--   1 user users 143481 Sep  1  2016 png.h
-rw-r--r--   1 user users  12343 Sep  1  2016 pnginfo.h
-rw-r--r--   1 user users   8353 Sep  1  2016 pngmem.c
-rw-r--r--   1 user users   2069 Aug 26  2004 pngnow.png
-rw-r--r--   1 user users  31617 Sep  1  2016 pngpread.c
-rw-r--r--   1 user users  83266 Sep  1  2016 pngpriv.h
-rw-r--r--   1 user users 141254 Sep  1  2016 pngread.c
-rw-r--r--   1 user users   3956 Sep  1  2016 pngrio.c
-rw-r--r--   1 user users 168573 Sep  1  2016 pngrtran.c
-rw-r--r--   1 user users 142873 Sep  1  2016 pngrutil.c
-rw-r--r--   1 user users  49969 Sep  1  2016 pngset.c
-rw-r--r--   1 user users  20036 Sep  1  2016 pngstruct.h
-rw-r--r--   1 user users  61255 Sep  1  2016 pngtest.c
-rw-r--r--   1 user users   8695 Jan  6  2013 pngtest.png
-rw-r--r--   1 user users  25150 Sep  1  2016 pngtrans.c
-rw-r--r--   1 user users    497 Sep  1  2016 pngusr.dfa
-rw-r--r--   1 user users   5655 Sep  1  2016 pngwio.c
-rw-r--r--   1 user users  76028 Sep  1  2016 pngwrite.c
-rw-r--r--   1 user users  15391 Sep  1  2016 pngwtran.c
-rw-r--r--   1 user users  80139 Sep  1  2016 pngwutil.c
drwxr-xr-x   5 user users   4096 Mar 24 14:51 projects/
-rw-r--r--   1 user users  11403 Sep  1  2016 README
drwxr-xr-x   2 user users   4096 Mar 24 14:51 scripts/
-rwxr-xr-x   1 user users   4640 Feb 21  2015 test-driver
drwxr-xr-x   2 user users   4096 Mar 24 14:51 tests/
-rw-r--r--   1 user users   1252 Aug 15  2016 TODO

libpng-apng-code:
total 2764
drwxr-xr-x   6 user users   4096 Jul 22 08:53 ./
drwxr-xr-x 282 user users  12288 Jul 22 09:39 ../
-rw-r--r--   1 user users 322880 Jul 22 08:53 aclocal.m4
-rw-r--r--   1 user users   1728 Jul 22 08:53 ANNOUNCE
-rwxr-xr-x   1 user users    877 Jul 22 08:53 autogen.sh
-rw-r--r--   1 user users 141161 Jul 22 08:53 CHANGES
-rw-r--r--   1 user users  12406 Jul 22 08:53 CMakeLists.txt
-rwxr-xr-x   1 user users  44941 Jul 22 08:53 config.guess
-rw-r--r--   1 user users   2218 Jul 22 08:53 config.h.in
-rwxr-xr-x   1 user users  34423 Jul 22 08:53 config.sub
-rwxr-xr-x   1 user users 411663 Jul 22 08:53 configure
-rw-r--r--   1 user users   3862 Jul 22 08:53 configure.ac
drwxr-xr-x   7 user users   4096 Jul 22 08:53 contrib/
-rwxr-xr-x   1 user users  18615 Jul 22 08:53 depcomp
-rw-r--r--   1 user users  30668 Jul 22 08:53 example.c
drwxr-xr-x   8 user users   4096 Jul 22 08:53 .git/
-rw-r--r--   1 user users   5175 Jul 22 08:53 INSTALL
-rwxr-xr-x   1 user users  13663 Jul 22 08:53 install-sh
-rw-r--r--   1 user users 141280 Jul 22 08:53 libpng-1.4.8.txt
-rw-r--r--   1 user users 184598 Jul 22 08:53 libpng.3
-rwxr-xr-x   1 user users   2379 Jul 22 08:53 libpng-config.in
-rw-r--r--   1 user users    293 Jul 22 08:53 libpng.pc.in
-rw-r--r--   1 user users  19036 Jul 22 08:53 libpngpf.3
-rw-r--r--   1 user users   4192 Jul 22 08:53 LICENSE
-rwxr-xr-x   1 user users 253153 Jul 22 08:53 ltmain.sh
-rw-r--r--   1 user users   4541 Jul 22 08:53 Makefile.am
-rw-r--r--   1 user users  60025 Jul 22 08:53 Makefile.in
-rwxr-xr-x   1 user users  11419 Jul 22 08:53 missing
-rw-r--r--   1 user users   2408 Jul 22 08:53 png.5
-rw-r--r--   1 user users   2498 Jul 22 08:53 pngbar.jpg
-rw-r--r--   1 user users   2399 Jul 22 08:53 pngbar.png
-rw-r--r--   1 user users  26634 Jul 22 08:53 png.c
-rw-r--r--   1 user users  47082 Jul 22 08:53 pngconf.h
-rw-r--r--   1 user users  12267 Jul 22 08:53 pngerror.c
-rw-r--r--   1 user users  28616 Jul 22 08:53 pngget.c
-rw-r--r--   1 user users 124654 Jul 22 08:53 png.h
-rw-r--r--   1 user users  16821 Jul 22 08:53 pngmem.c
-rw-r--r--   1 user users   2069 Jul 22 08:53 pngnow.png
-rw-r--r--   1 user users  54513 Jul 22 08:53 pngpread.c
-rw-r--r--   1 user users  37962 Jul 22 08:53 pngpriv.h
-rw-r--r--   1 user users  45779 Jul 22 08:53 pngread.c
-rw-r--r--   1 user users   5313 Jul 22 08:53 pngrio.c
-rw-r--r--   1 user users 141155 Jul 22 08:53 pngrtran.c
-rw-r--r--   1 user users 107313 Jul 22 08:53 pngrutil.c
-rw-r--r--   1 user users  39242 Jul 22 08:53 pngset.c
-rw-r--r--   1 user users  54601 Jul 22 08:53 pngtest.c
-rw-r--r--   1 user users   8608 Jul 22 08:53 pngtest.png
-rw-r--r--   1 user users  20655 Jul 22 08:53 pngtrans.c
-rw-r--r--   1 user users   7648 Jul 22 08:53 pngwio.c
-rw-r--r--   1 user users  47855 Jul 22 08:53 pngwrite.c
-rw-r--r--   1 user users  16934 Jul 22 08:53 pngwtran.c
-rw-r--r--   1 user users  89100 Jul 22 08:53 pngwutil.c
drwxr-xr-x   6 user users   4096 Jul 22 08:53 projects/
-rw-r--r--   1 user users  13273 Jul 22 08:53 README
drwxr-xr-x   2 user users   4096 Jul 22 08:53 scripts/
-rwxr-xr-x   1 user users     43 Jul 22 08:53 test-pngtest.sh
-rw-r--r--   1 user users   1443 Jul 22 08:53 TODO
-rw-r--r-- 1 user users  10720 Jan 10  2017 tarballs/libpng-1.6.25-apng.patch.gz
-rw-r--r-- 1 user users 982204 Jan 10  2017 tarballs/libpng-1.6.25.tar.xz
-rw-r--r-- 1 user users    819 Jan 10  2017 tarballs/libpng-1.6.25.tar.xz.asc
-rw-r--r-- 1 user users  10766 Jan 10  2017 tarballs/libpng-1.6.28-apng.patch.gz

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 3069 bytes --]

On Wed, Jul 26, 2017 at 06:56:51AM +0000, ng0 wrote:
> Leo Famulari transcribed 2.3K bytes:
> > On Sun, Jul 23, 2017 at 10:15:47AM +0000, ng0 wrote:
> > > ----- Forwarded message -----
> > > 
> > > > Date: Sun, 23 Jul 2017 18:21:19 +0900 (JST)
> > > > To: ng0
> > > > Cc: daisuken@users.sourceforge.net
> > > > Subject: Re: why has the hash for libpng-apng 1.6.28 changed?
> > > > 
> > > > Hi,
> > > > 
> > > > I calculated the hash for libpng-apng files on my local orignals.
> > > > 
> > > > md5sum
> > > > 9f2b36bccf89c5f4097111f0f73c1798  libpng-1.6.28-apng.patch.README.txt
> > > > fca7c6d87c8352e645facefc2e1dd153  libpng-1.6.28-apng.patch.gz
> > > > 
> > > > sha1sum
> > > > cb620589ecf9c28a4ecc00e6225dd41ca660a959  libpng-1.6.28-apng.patch.README.txt
> > > > 4fa952f5ad374fce8d478b7e54ee4298a0b8d159  libpng-1.6.28-apng.patch.gz
> > > > 
> > > > Local file time stamps are
> > > > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.README.txt
> > > > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.gz
> > > > 
> > > > That values equals on sourceforge.net.
> > > > https://sourceforge.net/projects/libpng-apng/files/libpng16/1.6.28/
> > > > 
> > > > I don't really understand what happend, but it look just fine.
> > > > 
> > > > Cheers,
> > > > ---
> > > > daisuken@users.sourceforge.net
> > 
> > Okay, this doesn't help us, so we need to inspect the different tarballs
> > ourselves. Do you have an old copy of the patch you can share?
> 
> Yes. I mean no. I am not sure. I have libpng-apng git checkout
> and also the 1.6.25 extracted tarball directory (but not sure
> when I got it), and the tarballs for 1.6.5 and 1.6.28.
> 
> But I think I found our problem:
> 
> user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.28-apng.patch.gz
> 0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
> user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.25-apng.patch.gz
> 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
> 
> (inputs
>  `(("apng" ,(origin
>     (method url-fetch)
>      (uri
>      (string-append "mirror://sourceforge/libpng-apng/libpng16/"
>      version "/libpng-" version "-apng.patch.gz"))
>      (sha256
>      (base32
>      "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5"))))))
> 
> My really strong guess is that we never updated the hash for
> libpng-apng when the libpng was updated fron which libpng-apng
> inherits its version.
> 
> I don't have the time to look at our git history right now,
> but you could do that, look at wether libpng-apng was touched
> since 1.6.25->1.6.28 update of libpng.
> 

git blame shows that back in February I updated libpng to 1.6.28 from
1.6.25, but that the last time libpng-apng was touched was by ng0 back
in January.

commit: 864738baaa7bb75c08647ccfc684736479e67f7f

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[ng0]

[-- Attachment #1: Type: text/plain, Size: 3828 bytes --]

Efraim Flashner transcribed 4.1K bytes:
> On Wed, Jul 26, 2017 at 06:56:51AM +0000, ng0 wrote:
> > Leo Famulari transcribed 2.3K bytes:
> > > On Sun, Jul 23, 2017 at 10:15:47AM +0000, ng0 wrote:
> > > > ----- Forwarded message -----
> > > > 
> > > > > Date: Sun, 23 Jul 2017 18:21:19 +0900 (JST)
> > > > > To: ng0
> > > > > Cc: daisuken@users.sourceforge.net
> > > > > Subject: Re: why has the hash for libpng-apng 1.6.28 changed?
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > I calculated the hash for libpng-apng files on my local orignals.
> > > > > 
> > > > > md5sum
> > > > > 9f2b36bccf89c5f4097111f0f73c1798  libpng-1.6.28-apng.patch.README.txt
> > > > > fca7c6d87c8352e645facefc2e1dd153  libpng-1.6.28-apng.patch.gz
> > > > > 
> > > > > sha1sum
> > > > > cb620589ecf9c28a4ecc00e6225dd41ca660a959  libpng-1.6.28-apng.patch.README.txt
> > > > > 4fa952f5ad374fce8d478b7e54ee4298a0b8d159  libpng-1.6.28-apng.patch.gz
> > > > > 
> > > > > Local file time stamps are
> > > > > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.README.txt
> > > > > 2017-01-06 21:02:10.938833896 +0900  libpng-1.6.28-apng.patch.gz
> > > > > 
> > > > > That values equals on sourceforge.net.
> > > > > https://sourceforge.net/projects/libpng-apng/files/libpng16/1.6.28/
> > > > > 
> > > > > I don't really understand what happend, but it look just fine.
> > > > > 
> > > > > Cheers,
> > > > > ---
> > > > > daisuken@users.sourceforge.net
> > > 
> > > Okay, this doesn't help us, so we need to inspect the different tarballs
> > > ourselves. Do you have an old copy of the patch you can share?
> > 
> > Yes. I mean no. I am not sure. I have libpng-apng git checkout
> > and also the 1.6.25 extracted tarball directory (but not sure
> > when I got it), and the tarballs for 1.6.5 and 1.6.28.
> > 
> > But I think I found our problem:
> > 
> > user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.28-apng.patch.gz
> > 0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab
> > user@shadownet ~/re-src$ guix hash tarballs/libpng-1.6.25-apng.patch.gz
> > 026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5
> > 
> > (inputs
> >  `(("apng" ,(origin
> >     (method url-fetch)
> >      (uri
> >      (string-append "mirror://sourceforge/libpng-apng/libpng16/"
> >      version "/libpng-" version "-apng.patch.gz"))
> >      (sha256
> >      (base32
> >      "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5"))))))
> > 
> > My really strong guess is that we never updated the hash for
> > libpng-apng when the libpng was updated fron which libpng-apng
> > inherits its version.
> > 
> > I don't have the time to look at our git history right now,
> > but you could do that, look at wether libpng-apng was touched
> > since 1.6.25->1.6.28 update of libpng.
> > 
> 
> git blame shows that back in February I updated libpng to 1.6.28 from
> 1.6.25, but that the last time libpng-apng was touched was by ng0 back
> in January.
> 
> commit: 864738baaa7bb75c08647ccfc684736479e67f7f

Okay, so I will send the update for libpng-apng (which due to its
inheritance of libpng is just the hash) and I will also add a second
commit which adds a comment above libpng that we must update libpng-apng
when we update libpng, if that's already possible (libpng-apng might not
immediately be up to date, but we don't update libpng immediately aswell
due to it being a core-updates candidate).

> 
> -- 
> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted



-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On Sun, Jul 30, 2017 at 09:37:22AM +0000, ng0 wrote:
> Efraim Flashner transcribed 4.1K bytes:
> > On Wed, Jul 26, 2017 at 06:56:51AM +0000, ng0 wrote:
> > > My really strong guess is that we never updated the hash for
> > > libpng-apng when the libpng was updated fron which libpng-apng
> > > inherits its version.

[...]

> > git blame shows that back in February I updated libpng to 1.6.28 from
> > 1.6.25, but that the last time libpng-apng was touched was by ng0 back
> > in January.
> > 
> > commit: 864738baaa7bb75c08647ccfc684736479e67f7f

Aha, that must be it!

> Okay, so I will send the update for libpng-apng (which due to its
> inheritance of libpng is just the hash) and I will also add a second
> commit which adds a comment above libpng that we must update libpng-apng
> when we update libpng, if that's already possible (libpng-apng might not
> immediately be up to date, but we don't update libpng immediately aswell
> due to it being a core-updates candidate).

I think we should give libpng-apng its own version because, as you said,
libpng-apng may not be developed at the same pace as libpng. This way,
we won't end up with a broken libpng-apng again.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

Leo Famulari transcribed 2.2K bytes:
> On Sun, Jul 30, 2017 at 09:37:22AM +0000, ng0 wrote:
> > Efraim Flashner transcribed 4.1K bytes:
> > > On Wed, Jul 26, 2017 at 06:56:51AM +0000, ng0 wrote:
> > > > My really strong guess is that we never updated the hash for
> > > > libpng-apng when the libpng was updated fron which libpng-apng
> > > > inherits its version.
> 
> [...]
> 
> > > git blame shows that back in February I updated libpng to 1.6.28 from
> > > 1.6.25, but that the last time libpng-apng was touched was by ng0 back
> > > in January.
> > > 
> > > commit: 864738baaa7bb75c08647ccfc684736479e67f7f
> 
> Aha, that must be it!
> 
> > Okay, so I will send the update for libpng-apng (which due to its
> > inheritance of libpng is just the hash) and I will also add a second
> > commit which adds a comment above libpng that we must update libpng-apng
> > when we update libpng, if that's already possible (libpng-apng might not
> > immediately be up to date, but we don't update libpng immediately aswell
> > due to it being a core-updates candidate).
> 
> I think we should give libpng-apng its own version because, as you said,
> libpng-apng may not be developed at the same pace as libpng. This way,
> we won't end up with a broken libpng-apng again.

I agree. Does someone of you want to make the patches and commits,
or should I prepare and send some?

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 1577 bytes --]

ng0 transcribed 2.5K bytes:
> Leo Famulari transcribed 2.2K bytes:
> > On Sun, Jul 30, 2017 at 09:37:22AM +0000, ng0 wrote:
> > > Efraim Flashner transcribed 4.1K bytes:
> > > > On Wed, Jul 26, 2017 at 06:56:51AM +0000, ng0 wrote:
> > > > > My really strong guess is that we never updated the hash for
> > > > > libpng-apng when the libpng was updated fron which libpng-apng
> > > > > inherits its version.
> > 
> > [...]
> > 
> > > > git blame shows that back in February I updated libpng to 1.6.28 from
> > > > 1.6.25, but that the last time libpng-apng was touched was by ng0 back
> > > > in January.
> > > > 
> > > > commit: 864738baaa7bb75c08647ccfc684736479e67f7f
> > 
> > Aha, that must be it!
> > 
> > > Okay, so I will send the update for libpng-apng (which due to its
> > > inheritance of libpng is just the hash) and I will also add a second
> > > commit which adds a comment above libpng that we must update libpng-apng
> > > when we update libpng, if that's already possible (libpng-apng might not
> > > immediately be up to date, but we don't update libpng immediately aswell
> > > due to it being a core-updates candidate).
> > 
> > I think we should give libpng-apng its own version because, as you said,
> > libpng-apng may not be developed at the same pace as libpng. This way,
> > we won't end up with a broken libpng-apng again.

I appended a patch how I understood your idea.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #1.2: 0001-gnu-libpng-apng-Update-to-1.6.28.patch --]
[-- Type: text/plain, Size: 3782 bytes --]

From 4326cad38700df43909eb6f430217fdfa4eca89f Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Tue, 1 Aug 2017 15:37:28 +0000
Subject: [PATCH] gnu: libpng-apng: Update to 1.6.28.

Fixes <https://bugs.gnu.org/27556>.

* gnu/packages/image.scm (libpng-apng): Update to 1.6.28.
Remove inherit of 'libpng'.
(version): Use own version, remove 'package-version libpng'.
(source): Add it.
(arguments): Update hash of libpng-apng source.
---
 gnu/packages/image.scm | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 139be6281..3be675fc2 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2016, 2017 Kei Kebreau <kei@openmailbox.org>
-;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -91,11 +91,27 @@ library.  It supports almost all PNG features and is extensible.")
    (license license:zlib)
    (home-page "http://www.libpng.org/pub/png/libpng.html")))
 
+;; libpng-apng could be not in sync with libpng,
+;; reference bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27556
 (define-public libpng-apng
   (package
-    (inherit libpng)
     (name "libpng-apng")
-    (version (package-version libpng))
+    (version "1.6.28")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (list (string-append "mirror://sourceforge/libpng/libpng16/"
+                                 version "/libpng-" version ".tar.xz")
+                  (string-append
+                   "ftp://ftp.simplesystems.org/pub/libpng/png/src"
+                   "/libpng16/libpng-" version ".tar.xz")
+                  (string-append
+                   "ftp://ftp.simplesystems.org/pub/libpng/png/src/history"
+                   "/libpng16/libpng-" version ".tar.xz")))
+       (sha256
+        (base32
+         "0ylgyx93hnk38haqrh8prd3ax5ngzwvjqw5cxw7p9nxmwsfyrlyq"))))
+    (build-system gnu-build-system)
     (arguments
      `(#:phases
        (modify-phases %standard-phases
@@ -111,7 +127,7 @@ library.  It supports almost all PNG features and is extensible.")
                (and (apply-patch "the-patch")
                     (for-each apply-patch
                               (find-files "\\.patch"))))
-           #t))
+             #t))
          (add-before 'configure 'no-checks
            (lambda _
              (substitute* "Makefile.in"
@@ -126,15 +142,19 @@ library.  It supports almost all PNG features and is extensible.")
                                   version "/libpng-" version "-apng.patch.gz"))
                   (sha256
                    (base32
-                    "026r0gbkf6d6v54wca02cdxln8sj4m2c1yk62sj2aasv2ki2ffh5"))))))
+                    "0m5nv70n9903x3xzxw9qqc6sgf2rp106ha0x6gix0xf8wcrljaab"))))))
     (native-inputs
      `(("libtool" ,libtool)))
+    ;; libpng.la says "-lz", so propagate it.
+    (propagated-inputs
+     `(("zlib" ,zlib)))
     (synopsis "APNG patch for libpng")
     (description
      "APNG (Animated Portable Network Graphics) is an unofficial
 extension of the APNG (Portable Network Graphics) format.
 APNG patch provides APNG support to libpng.")
-    (home-page "https://sourceforge.net/projects/libpng-apng/")))
+    (home-page "https://sourceforge.net/projects/libpng-apng/")
+    (license license:zlib)))
 
 (define-public libpng-1.2
   (package
-- 
2.13.3


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#27556: libpng has wrong hash. [Fwd: Re: why has the hash for libpng-apng 1.6.28 changed?]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

On Tue, Aug 01, 2017 at 03:47:08PM +0000, ng0 wrote:
> From 4326cad38700df43909eb6f430217fdfa4eca89f Mon Sep 17 00:00:00 2001
> From: ng0 <ng0@infotropique.org>
> Date: Tue, 1 Aug 2017 15:37:28 +0000
> Subject: [PATCH] gnu: libpng-apng: Update to 1.6.28.
> 
> Fixes <https://bugs.gnu.org/27556>.
> 
> * gnu/packages/image.scm (libpng-apng): Update to 1.6.28.
> Remove inherit of 'libpng'.
> (version): Use own version, remove 'package-version libpng'.
> (source): Add it.
> (arguments): Update hash of libpng-apng source.

Thanks! Pushed as e0958c2df833a5eb3b6ecfb66f8d971cd44dd49b

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]