unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: 27212@debbugs.gnu.org, ng0 <ng0@pragmatique.xyz>,
	Marius Bakke <mbakke@fastmail.com>
Subject: bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem.
Date: Sat, 3 Jun 2017 20:25:00 +0200	[thread overview]
Message-ID: <20170603202500.547f3d47@scratchpost.org> (raw)
In-Reply-To: <20170603180013.15853-1-dannym@scratchpost.org>

Hi,

sorry for the slip-up.

The error handling in 203a9455c4695152fc5d0085bffeead9ce3216c2 was improved for the case when there's no iso9660 primary volume descriptor anywhere and no terminator either.  In that case the CD is broken.

But if there's no iso9660 volume descriptor AT ALL (primary or not) it's not a fatal error for guix gnu/build/file-systems.scm - it just means we picked the wrong filesystem type and should try the next one.  This case was not handled correctly and this patch addresses this.

I'd like help with testing this patch.  If someone with a fast computer could apply this patch, then run make check-system, and then, if everything worked, run guix system reconfigure /etc/config.scm , that would be great (my computer is building guix master for the last 3 days and probably needs 4 more - so no idea whether the patch works).

@Marius: I don't understand why reverting 203a9455c4695152fc5d0085bffeead9ce3216c2 didn't fix it.  It should have.  (I can't try it myself because I'm in forced-system-update purgatory - argh).

  reply	other threads:[~2017-06-03 18:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 16:53 bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot ng0
2017-06-03 17:01 ` Marius Bakke
2017-06-03 17:30   ` ng0
2017-06-03 18:00   ` bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem Danny Milosavljevic
2017-06-03 18:25     ` Danny Milosavljevic [this message]
2017-06-03 19:45       ` Leo Famulari
2017-06-03 19:57         ` Jelle Licht
2017-06-03 20:11           ` Danny Milosavljevic
2017-06-03 20:12         ` Danny Milosavljevic
2017-06-03 19:38 ` bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot jah
2017-06-04 11:14 ` ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170603202500.547f3d47@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=27212@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    --cc=ng0@pragmatique.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).