unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ng0 <ng0@pragmatique.xyz>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27212@debbugs.gnu.org
Subject: bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot
Date: Sat, 3 Jun 2017 17:30:56 +0000	[thread overview]
Message-ID: <20170603173056.7622qgvocdbn3gpi@abyayala> (raw)
In-Reply-To: <8737bh0zvt.fsf@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

Marius Bakke transcribed 1.4K bytes:
> ng0 <ng0@pragmatique.xyz> writes:
> 
> > Otherwise perfectly working systems I have *all* break after
> > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=203a9455c4695152fc5d0085bffeead9ce3216c2
> >
> > and the last thing  they display before guile repl is the
> > message in that commit.
> >
> > Yes, I use labels. No, I don't use complicated setups.
> > Please test such changes before applying them in the wild..
> > I just hope this happened here and the break is a mistake.
> 
> I *just* noticed the same thing. I also tried reverting this commit, but
> that just entered a (re)boot loop. Not sure what's up, but two of my
> GuixSD systems are affected.
> 
> On my way out now, but will investigate more tomorrow. CC Danny in case
> of insight (which report by Chris did this address?).
> 
> Older generations are fine.

Thanks.

Results like this should be avoided. As long as this happens
there is a reason for the 'beta' label.

It might be usable in all kinds of environments, but we
have to have rules and guidelines when something can be
applied just like this after QA or when a certain set
of people have to aprove the change as they did
test the change and it worked.

I consider file-system one of these cases.
If the commit touches the way towards boot, approval
is the way to go.

-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-03 17:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03 16:53 bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot ng0
2017-06-03 17:01 ` Marius Bakke
2017-06-03 17:30   ` ng0 [this message]
2017-06-03 18:00   ` bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem Danny Milosavljevic
2017-06-03 18:25     ` Danny Milosavljevic
2017-06-03 19:45       ` Leo Famulari
2017-06-03 19:57         ` Jelle Licht
2017-06-03 20:11           ` Danny Milosavljevic
2017-06-03 20:12         ` Danny Milosavljevic
2017-06-03 19:38 ` bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot jah
2017-06-04 11:14 ` ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170603173056.7622qgvocdbn3gpi@abyayala \
    --to=ng0@pragmatique.xyz \
    --cc=27212@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).