From: Danny Milosavljevic <dannym@scratchpost.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 27007@debbugs.gnu.org
Subject: bug#27007: [PATCH 1/2] bootloader: Use menu-entry to define custom bootloader entries.
Date: Thu, 1 Jun 2017 00:11:31 +0200 [thread overview]
Message-ID: <20170601001131.70855905@scratchpost.org> (raw)
In-Reply-To: <20170531072328.16116-2-m.othacehe@gmail.com>
Hi Mathieu,
On Wed, 31 May 2017 09:23:27 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:
> +(define-record-type* <menu-entry>
...
> + (initrd menu-entry-initrd)) ; file name of the initrd as a gexp
For another future patch: Hmm, should we make this optional? I didn't have an initrd for many years.
> --- a/gnu/bootloader/extlinux.scm
> +++ b/gnu/bootloader/extlinux.scm
> @@ -37,7 +37,8 @@
> corresponding to old generations of the system."
>
> (define all-entries
> - (append entries (bootloader-configuration-menu-entries config)))
> + (append entries (map menu-entry->boot-parameters
> + (bootloader-configuration-menu-entries config))))
Since we have menu-entry as a public datatype now, should we maybe use menu-entries for all the bootloader stuff ? I think this would be easier to maintain because boot-parameters is a serialized format we can't easily change (because it's stored into a "parameters" file per generation, and generations can't ever be deleted).
In that case maybe it could rather be boot-parameters->menu-entry for the other (i.e. the GuixSD) entries instead of this.
> + (define (boot-parameters->gexp params)
Maybe rather menu-entry->gexp and take a menu-entry ?
> +(define (menu-entry->boot-parameters menu-entry)
Then we'd have menu-entry->boot-parameters *and* boot-parameters->menu-entry which is usually a dead giveaway that we are doing something strange. It would make it either a 1:1 map or lose data on the roundtrip, both of which are weird.
That's why I think if we have public <menu-entry> records anyway now, let's use them for the bootloader stuff throughout.
WDYT?
next prev parent reply other threads:[~2017-05-31 22:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 20:00 bug#27007: boot-parameters are not documented Tomáš Čech
2017-05-20 20:31 ` Mathieu Othacehe
2017-05-20 21:07 ` Leo Famulari
2017-05-20 21:43 ` Tomáš Čech
2017-05-20 20:52 ` Danny Milosavljevic
2017-05-20 21:00 ` Tomáš Čech
2017-05-22 15:55 ` Ludovic Courtès
2017-05-22 17:31 ` Mathieu Othacehe
2017-05-23 8:13 ` Ludovic Courtès
2017-05-23 9:31 ` Mathieu Othacehe
2017-05-23 9:57 ` Tomáš Čech
2017-05-23 11:23 ` Ludovic Courtès
2017-05-23 11:40 ` Mathieu Othacehe
2017-05-23 12:24 ` Ludovic Courtès
2017-05-31 7:23 ` bug#27007: [PATCH 0/2] Use menu-entry to define custom bootloader entries Mathieu Othacehe
2017-05-31 7:23 ` bug#27007: [PATCH 1/2] bootloader: " Mathieu Othacehe
2017-05-31 22:11 ` Danny Milosavljevic [this message]
2017-06-01 8:34 ` Mathieu Othacehe
2017-06-01 11:14 ` Danny Milosavljevic
2017-06-02 9:29 ` Mathieu Othacehe
2017-06-02 14:30 ` Marius Bakke
2017-06-01 11:22 ` Ludovic Courtès
2017-06-05 10:23 ` Ludovic Courtès
2017-06-06 8:14 ` Mathieu Othacehe
2017-05-31 7:23 ` bug#27007: [PATCH 2/2] doc: Adapt to multiple bootloader support Mathieu Othacehe
2017-05-31 21:57 ` Danny Milosavljevic
2017-06-05 10:38 ` Ludovic Courtès
2017-06-05 10:36 ` Ludovic Courtès
2017-06-05 14:11 ` Danny Milosavljevic
2017-06-06 22:51 ` Ludovic Courtès
2017-06-08 10:59 ` Mathieu Othacehe
2017-06-06 9:20 ` Mathieu Othacehe
2017-05-24 20:11 ` bug#27007: boot-parameters are not documented Danny Milosavljevic
2017-05-26 8:47 ` Ludovic Courtès
2017-05-26 9:03 ` ng0
2017-06-08 10:57 ` bug#27007: [PATCH v2 1/2] bootloader: Use menu-entry to define custom bootloader entries Mathieu Othacehe
2017-06-08 10:57 ` bug#27007: [PATCH v2 2/2] doc: Adapt to multiple bootloader support Mathieu Othacehe
2017-06-08 12:39 ` Ludovic Courtès
2017-06-08 14:33 ` Mathieu Othacehe
2017-06-08 12:36 ` bug#27007: [PATCH v2 1/2] bootloader: Use menu-entry to define custom bootloader entries Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601001131.70855905@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=27007@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).