bug#26610: python-gpg broke; python-gpg 1.9.0 does not exist

bug#26610: python-gpg broke; python-gpg 1.9.0 does not exist

[Christopher Allan Webber]

Commit 8439c9c05e upgraded gpgme to 1.9.0.

Unfortunately, python-gpg's version is tied to gpgme:

(define-public python-gpg
  (package
    (name "python-gpg")
    (version (package-version gpgme))
    ;; [...]

This is a problem, because upgrading gpgme "automatically" upgraded
python-gpg, and there is no python-gpg release of 1.9.0.  The latest
release is 1.8.0:

  https://pypi.python.org/pypi/gpg/1.8.0

I'm not sure it makes sense to tie the package version to python-gpg's
package version anyway... if upgrading gpgme does trigger the upgrade of
python-gpg "automatically", then that would mean that even if there was
a pythong-gpg available with the new version, the hash would be
incorrect.

bug#26610: python-gpg broke; python-gpg 1.9.0 does not exist

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

On Sat, Apr 22, 2017 at 11:37:00AM -0500, Christopher Allan Webber wrote:
> Commit 8439c9c05e upgraded gpgme to 1.9.0.
> 
> Unfortunately, python-gpg's version is tied to gpgme:
> 
> (define-public python-gpg
>   (package
>     (name "python-gpg")
>     (version (package-version gpgme))
>     ;; [...]
> 
> This is a problem, because upgrading gpgme "automatically" upgraded
> python-gpg, and there is no python-gpg release of 1.9.0.  The latest
> release is 1.8.0:
> 
>   https://pypi.python.org/pypi/gpg/1.8.0

I'd hoped the GPGME maintainers would release new versions of python-gpg
in tandem with GPGME, but since that's not the case, we should not use
gpgme's package-version in python-gpg.

Can you try it? I'm not an assword user, so I can't adequately test the
combination of gpgme-1.9.0 and python-gpg-1.8.0.

> I'm not sure it makes sense to tie the package version to python-gpg's
> package version anyway... if upgrading gpgme does trigger the upgrade of
> python-gpg "automatically", then that would mean that even if there was
> a pythong-gpg available with the new version, the hash would be
> incorrect.

Right, this technique doesn't work if one forgets to update the other
packages... as I forgot to do in this case :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#26610: python-gpg broke; python-gpg 1.9.0 does not exist

[Ivan Vilata i Balaguer]

I think I also got bitten by this:

```
$ guix package --fallback -u
warning: failed to install locale: Invalid argument

Starting download of /gnu/store/8anrjg1qj2sqij6883v057l86wac2vln-gpg-1.9.0.tar.gz
From https://pypi.io/packages/source/g/gpg/gpg-1.9.0.tar.gz...
following redirection to `https://pypi.org/packages/source/g/gpg/gpg-1.9.0.tar.gz'...
following redirection to `https://files.pythonhosted.org/packages/source/g/gpg/gpg-1.9.0.tar.gz'...
ERROR: download failed "https://files.pythonhosted.org/packages/source/g/gpg/gpg-1.9.0.tar.gz" 404 "Not Found"

Starting download of /gnu/store/8anrjg1qj2sqij6883v057l86wac2vln-gpg-1.9.0.tar.gz
From http://mirror.hydra.gnu.org/file/gpg-1.9.0.tar.gz/sha256/1x74i6q713c0bckls7rdm8kgsmllf9qvy9x62jghszlhgjkyh9nd...
ERROR: download failed "http://mirror.hydra.gnu.org/file/gpg-1.9.0.tar.gz/sha256/1x74i6q713c0bckls7rdm8kgsmllf9qvy9x62jghszlhgjkyh9nd" 404 "Not Found"

Starting download of /gnu/store/8anrjg1qj2sqij6883v057l86wac2vln-gpg-1.9.0.tar.gz
From http://tarballs.nixos.org/sha256/1x74i6q713c0bckls7rdm8kgsmllf9qvy9x62jghszlhgjkyh9nd...
ERROR: download failed "http://tarballs.nixos.org/sha256/1x74i6q713c0bckls7rdm8kgsmllf9qvy9x62jghszlhgjkyh9nd" 404 "Not Found"
failed to download "/gnu/store/8anrjg1qj2sqij6883v057l86wac2vln-gpg-1.9.0.tar.gz" from "https://pypi.io/packages/source/g/gpg/gpg-1.9.0.tar.gz"
builder for `/gnu/store/16rsli2x9sh4fr9fa0yy4mn5pkmqwy3h-gpg-1.9.0.tar.gz.drv' failed to produce output path `/gnu/store/8anrjg1qj2sqij6883v057l86wac2vln-gpg-1.9.0.tar.gz'
cannot build derivation `/gnu/store/gvji20dwv204p39ii010sx267kkpjd15-python-gpg-1.9.0.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/8m8whiqpxy5b45x18rvskq523nl7237d-assword-0.10.drv': 1 dependencies couldn't be built
guix package: error: build failed: build of `/gnu/store/8m8whiqpxy5b45x18rvskq523nl7237d-assword-0.10.drv' failed
```

I am a user of ``assword``, but pretty much a Guix newbie.  Is there any
way I can help fix this issue?

Thanks,

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

bug#26610: python-gpg broke; python-gpg 1.9.0 does not exist

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

On Fri, May 26, 2017 at 09:51:47PM +0200, Ivan Vilata i Balaguer wrote:
> $ guix package --fallback -u
> warning: failed to install locale: Invalid argument
> 
> Starting download of /gnu/store/8anrjg1qj2sqij6883v057l86wac2vln-gpg-1.9.0.tar.gz
> From https://pypi.io/packages/source/g/gpg/gpg-1.9.0.tar.gz...
> following redirection to `https://pypi.org/packages/source/g/gpg/gpg-1.9.0.tar.gz'...
> following redirection to `https://files.pythonhosted.org/packages/source/g/gpg/gpg-1.9.0.tar.gz'...
> ERROR: download failed "https://files.pythonhosted.org/packages/source/g/gpg/gpg-1.9.0.tar.gz" 404 "Not Found"

[...]

> guix package: error: build failed: build of `/gnu/store/8m8whiqpxy5b45x18rvskq523nl7237d-assword-0.10.drv' failed

> I am a user of ``assword``, but pretty much a Guix newbie.  Is there any
> way I can help fix this issue?

You can try changing the python-gpg package's version to the last
available upstream version. On PyPi, that's 1.8.0.

Then, try rebuilding the packages that depend on python-gpg (`guix
refresh -l python-gpg python2-gpg`).

Hopefully it all works. Then, you can send a patch with your fix :)

Let us know if you need help!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#26610: python-gpg broke; python-gpg 1.9.0 does not exist

[Ivan Vilata i Balaguer]

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

Leo Famulari (2017-05-27 10:11:46 -0400) wrote:

> You can try changing the python-gpg package's version to the last
> available upstream version. On PyPi, that's 1.8.0.
> 
> Then, try rebuilding the packages that depend on python-gpg (`guix
> refresh -l python-gpg python2-gpg`).
> 
> Hopefully it all works. Then, you can send a patch with your fix :)
> 
> Let us know if you need help!

Ok, attaching the patch.  These are the steps I followed to test it:

 0. Apply the patch.

 1. Add ``python-gpg`` at the end of ``gnu/packages/gnupg.scm`` (sorry
    for my poor Scheme habilities).

 2. Run ``guix environment --ad-hoc -l gnu/packages/gnupg.scm python
    assword coreutils``.

 3. Import ``gpg`` in Python and check ``gpg.version.versionstr``, dump
    ``assword`` program to verify that it uses the same build of
    ``python-gnupg``.

 4. Run ``assword`` and check that everything works.

Probably many steps can be done better/more easily, but my knowledge is
very limited.  Links for improving that are welcome.`;)`

Thanks and cheers,

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: 0001-gnu-python-gpg-Use-explicit-version-1.8.0-instead-of.patch --]
[-- Type: text/plain, Size: 1019 bytes --]

From bef8ccca58150ad4714cfa65472d5f2e9ae7b283 Mon Sep 17 00:00:00 2001
From: Ivan Vilata-i-Balaguer <ivan@selidor.net>
Date: Thu, 1 Jun 2017 10:33:09 +0200
Subject: [PATCH] gnu: python-gpg: Use explicit version 1.8.0 instead of
 GPGME's.

GPGME defines version 1.9.0, which isn't yet available for python-gnupg, whose
latest version is 1.8.0, so we use that explicitly instead.  Fixes #26610.

* gnu/packages/gnupg.scm (python-gpg): Use explicit version 1.8.0 instead of GPGME's.
---
 gnu/packages/gnupg.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index 440e7d550..c2b02789b 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -410,7 +410,7 @@ and every application benefits from this.")
 (define-public python-gpg
   (package
     (name "python-gpg")
-    (version (package-version gpgme))
+    (version "1.8.0")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "gpg" version))
-- 
2.12.2

bug#26610: python-gpg broke; python-gpg 1.9.0 does not exist

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

On Thu, Jun 01, 2017 at 10:43:33AM +0200, Ivan Vilata i Balaguer wrote:
>  0. Apply the patch.
> 
>  1. Add ``python-gpg`` at the end of ``gnu/packages/gnupg.scm`` (sorry
>     for my poor Scheme habilities).
> 
>  2. Run ``guix environment --ad-hoc -l gnu/packages/gnupg.scm python
>     assword coreutils``.
> 
>  3. Import ``gpg`` in Python and check ``gpg.version.versionstr``, dump
>     ``assword`` program to verify that it uses the same build of
>     ``python-gnupg``.
> 
>  4. Run ``assword`` and check that everything works.
> 
> Probably many steps can be done better/more easily, but my knowledge is
> very limited.  Links for improving that are welcome.`;)`

Sounds like a good test :)


> From bef8ccca58150ad4714cfa65472d5f2e9ae7b283 Mon Sep 17 00:00:00 2001
> From: Ivan Vilata-i-Balaguer <ivan@selidor.net>
> Date: Thu, 1 Jun 2017 10:33:09 +0200
> Subject: [PATCH] gnu: python-gpg: Use explicit version 1.8.0 instead of
>  GPGME's.
> 
> GPGME defines version 1.9.0, which isn't yet available for python-gnupg, whose
> latest version is 1.8.0, so we use that explicitly instead.  Fixes #26610.
> 
> * gnu/packages/gnupg.scm (python-gpg): Use explicit version 1.8.0 instead of GPGME's.

Thank you! Pushed as 99c63f3f072e73540a65d4a7b5dac9aaeb3ed50d.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]