bug#26581: Leftover patch round-up

bug#26581: Leftover patch round-up

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 2392 bytes --]

Let's find the patch files whose filenames are not referenced anywhere,
except possibly in 'gnu/local.mk':

$ for patch in gnu/packages/patches/*; do result=$(grep -rI ${patch##*/}) \
&& test ${result%%:*} != "gnu/local.mk" || echo $patch; done
gnu/packages/patches/gcc-libiberty-printf-decl.patch
gnu/packages/patches/grub-CVE-2015-8370.patch
gnu/packages/patches/grub-freetype.patch
gnu/packages/patches/grub-gets-undeclared.patch
gnu/packages/patches/guile-arm-fixes.patch
gnu/packages/patches/hypre-doc-tables.patch
gnu/packages/patches/hypre-ldflags.patch
gnu/packages/patches/mplayer2-theora-fix.patch
gnu/packages/patches/readline-7.0-mingw.patch
gnu/packages/patches/soprano-find-clucene.patch
gnu/packages/patches/util-linux-CVE-2017-2616.patch
gnu/packages/patches/xf86-video-intel-compat-api.patch
gnu/packages/patches/xf86-video-intel-glibc-2.20.patch

Specific notes for each file:

gcc-libiberty-printf-decl.patch: Added in
b810a85019ab3c4ee1f889d0751b8eb06157dadc and mentioned in the
commit message but never used, AFAICT. Ludo?

gnu/packages/patches/grub-CVE-2015-8370.patch,
gnu/packages/patches/grub-freetype.patch,
gnu/packages/patches/grub-gets-undeclared.patch: Unused since grub was
updated to 2.02~beta3 in 4c7260011e219eb3ebf5da976ab107dbd5997829. 

gnu/packages/patches/guile-arm-fixes.patch: Unused since guile was
updated to 2.0.12 in 923d9caa1800fb48b1745cf9ef0fd294a423d4cd,
4f07bb6b433a7fa2fdcb5f465f7b9dfdf0140dae.

gnu/packages/patches/hypre-doc-tables.patch,
gnu/packages/patches/hypre-ldflags.patch: Added but not used in
528bb46436be39a4f4d3e7b3e908c34e92cca5f8. I pinged Eric on #guix.

gnu/packages/patches/mplayer2-theora-fix.patch: Unused since
a6d605e648643cd98582bf1e339bf60706d7c6c6

gnu/packages/patches/readline-7.0-mingw.patch: Introduced in
ae12d586275cdd96db23fb01bf840b2055b5b979, but never used. Jan, can you
take a look?

gnu/packages/patches/soprano-find-clucene.patch: Unused since
dbbb45dd7318528ea92a56992be789d0b5cf2120.

gnu/packages/patches/util-linux-CVE-2017-2616.patch: Unused since
util-linux was updated to 2.29.2 in
83090f6ae7eb5353049b253f74670d72d9387463. The history of this update is
very confusing.

gnu/packages/patches/xf86-video-intel-compat-api.patch,
gnu/packages/patches/xf86-video-intel-glibc-2.20.patch: Unused since
6cc328b43b1ae2cc1d201844cff7c619187cca5e.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#26581: Leftover patch round-up

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Thu, Apr 20, 2017 at 02:25:38PM -0400, Leo Famulari wrote:
> Let's find the patch files whose filenames are not referenced anywhere,
> except possibly in 'gnu/local.mk':
> 
> $ for patch in gnu/packages/patches/*; do result=$(grep -rI ${patch##*/}) \
> && test ${result%%:*} != "gnu/local.mk" || echo $patch; done

This shell snippet needs improvement, to say the least! But it worked
okay this time :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#26581: Leftover patch round-up

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> Let's find the patch files whose filenames are not referenced anywhere,
> except possibly in 'gnu/local.mk':

Woohoo, spring cleanup!  :-)

> Specific notes for each file:
>
> gcc-libiberty-printf-decl.patch: Added in
> b810a85019ab3c4ee1f889d0751b8eb06157dadc and mentioned in the
> commit message but never used, AFAICT. Ludo?

It was used for 5.3 (commit e3d0fcbf7e55e8cbe8d0a1c5a24d73f341d7243b,
which the commit above reinstated; see
<https://gcc.gnu.org/ml/gcc-help/2016-04/msg00039.html>) but useless in
5.4.  So yes, can be removed!

Except for this one:

> gnu/packages/patches/readline-7.0-mingw.patch: Introduced in
> ae12d586275cdd96db23fb01bf840b2055b5b979, but never used. Jan, can you
> take a look?

… it looks like you can go ahead and remove’em all!

Maybe we should add a makefile target to check for stale patches?

Thanks,
Ludo’.

bug#26581: Leftover patch round-up

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Fri, Apr 21, 2017 at 11:19:41PM +0200, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> > gcc-libiberty-printf-decl.patch: Added in
> > b810a85019ab3c4ee1f889d0751b8eb06157dadc and mentioned in the
> > commit message but never used, AFAICT. Ludo?
> 
> It was used for 5.3 (commit e3d0fcbf7e55e8cbe8d0a1c5a24d73f341d7243b,
> which the commit above reinstated; see
> <https://gcc.gnu.org/ml/gcc-help/2016-04/msg00039.html>) but useless in
> 5.4.  So yes, can be removed!

Ah, thanks for sharing the context.

> Except for this one:
> 
> > gnu/packages/patches/readline-7.0-mingw.patch: Introduced in
> > ae12d586275cdd96db23fb01bf840b2055b5b979, but never used. Jan, can you
> > take a look?
> 
> … it looks like you can go ahead and remove’em all!

Done as 04b906799168008c41f62402eee74bd47c1c2681.

> Maybe we should add a makefile target to check for stale patches?

We're discussing it here:

http://lists.gnu.org/archive/html/guix-devel/2017-04/msg00439.html

I'll leave this bug open while we decide what to do about
readline-7.0-mingw.patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#26581: Leftover patch round-up

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

On Fri, Apr 21, 2017 at 06:06:54PM -0400, Leo Famulari wrote:
> I'll leave this bug open while we decide what to do about
> readline-7.0-mingw.patch.

I've removed this patch in commit
bfa3e64d7f97c759e5b4f5977827100ecd0df03c

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]