From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#25917: [PATCH] services: Don't check filesystem even if #:check?
	if not #:needed-for-boot.
Date: Mon, 13 Mar 2017 20:55:04 +0100
Message-ID: <20170313205504.485459c8@scratchpost.org>
References: <87wpbw83ev.fsf@gnu.org>
	<20170312165604.1273-1-dannym@scratchpost.org>
	<878to9bleb.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42908)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cnW4b-0000gg-CQ
	for bug-guix@gnu.org; Mon, 13 Mar 2017 15:56:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cnW4Y-0002Ro-S5
	for bug-guix@gnu.org; Mon, 13 Mar 2017 15:56:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56135)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cnW4Y-0002RN-Hx
	for bug-guix@gnu.org; Mon, 13 Mar 2017 15:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cnW4Y-0007Ni-Br
	for bug-guix@gnu.org; Mon, 13 Mar 2017 15:56:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25917.B25917.148943491428319@debbugs.gnu.org>
In-Reply-To: <878to9bleb.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 25917@debbugs.gnu.org

> One thing I don=E2=80=99t get is that, if the file system is not
> needed-for-boot?, then it doesn=E2=80=99t get a Shepherd service in the f=
irst
> place.

But what is supposed to happen to filesystems where mount? but not needed-f=
or-boot? if Shepherd doesn't mount it?  Does some other part mount it ?  Is=
 it just put into fstab or something ?

> In your original message, you wrote that the problem is that =E2=80=9Cthe=
 initrd
> doesn't contain the fsck tool=E2=80=9D, so it=E2=80=99s a problem in linu=
x-initrd.scm,
> no?

I don't know where we should fix it.  If you want to reproduce it, I tested=
 it with this config

  (file-systems (cons* ...
                       (file-system
                        (device "NO NAME")
                        (title 'label)
                        (mount-point "/mnt/tmp")
                        (type "vfat")
                        (needed-for-boot? #f)
                        (mount? #t)
                        (check? #t))
                       %base-file-systems))

and an USB flash memory stick with name "NO NAME" (the default of the stick=
 :) ).

The effect is if not needed-for-boot? but check? , the boot breaks because =
it can't find fsck.vfat .

vfat is good for testing this since it's usually the only filesystem of tha=
t type on the system and so it can't be required by another filesystem entr=
y and mask the problem.