From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks) Date: Sat, 4 Mar 2017 17:33:39 +0000 Message-ID: <20170304173339.ubumkmfdfrkbascj@abyayala> References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <20170304164309.08e43b4c@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckCVS-0002qB-Tm for bug-guix@gnu.org; Sat, 04 Mar 2017 11:26:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckCVP-0000AT-MQ for bug-guix@gnu.org; Sat, 04 Mar 2017 11:26:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:41999) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckCVP-0000A9-7T for bug-guix@gnu.org; Sat, 04 Mar 2017 11:26:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ckCVO-0000QU-BH for bug-guix@gnu.org; Sat, 04 Mar 2017 11:26:03 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20170304164309.08e43b4c@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic Cc: 25957@debbugs.gnu.org On 17-03-04 16:43:09, Danny Milosavljevic wrote: > Hi ng0, > > > I think there should be a reference to /gnu/store/ reddis and not > > "/usr/sbin/redis-server". Different problem, related bug.. This can be > > solved in a commit after this bug. > > Yeah. > > I would question why a normal application needs to start a redis *server* in the first place. Sounds strange to me. But I agree that if it wants to do that it should use a store reference. > > says "Redis is designed to be a very long running process in your server" so that definitely reads to me that a normal program shouldn't just start redis-server when it feels like it (and I hope it stops it again later? After reading the source code it doesn't appear that way...). > > says "WARNING: this has not been tested in a while. YMMV". Uhhhh. Not confidence-inspiring. It was the first time I read about reddis in gitolite context, and in all the time I used gitolite I never really needed it when building or running. I disregard this as not very important and not really important at all to fix. It should be fixed in the long run, but my main concern was usability of gitolite, which has been addressed in one of the two patches I've sent.