unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: 25831-done@debbugs.gnu.org
Subject: bug#25831: Expose http_proxy setting on GuixSD
Date: Wed, 22 Feb 2017 15:26:31 -0500	[thread overview]
Message-ID: <20170222202631.GB28813@jasmine> (raw)
In-Reply-To: <8737f60ypb.fsf@gnu.org>

On Wed, Feb 22, 2017 at 09:15:12PM +0100, Mathieu Lirzin wrote:
> Leo Famulari <leo@famulari.name> writes:
> > +                (list (string-append "PATH=" #$lsof "/bin")
> > +                      #$@(if http-proxy
> > +                           (list (string-append "http_proxy=" http-proxy))
> > +                           '()))
>                             ^^
>                             missin two spaces in THEN and ELSE part ;)

I'm still learning what looks right :)

> Otherwise, LGTM.

Thanks for your advice and review!

I pushed the change as 93d32da9f8bba815b1effe6358904b5e1f9c73ff.

  reply	other threads:[~2017-02-22 20:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 17:19 bug#25831: Expose http_proxy setting on GuixSD Leo Famulari
2017-02-21 18:17 ` Mathieu Lirzin
2017-02-21 20:26   ` Leo Famulari
2017-02-22  9:51     ` Mathieu Lirzin
2017-02-22 19:22       ` Leo Famulari
2017-02-22 20:15         ` Mathieu Lirzin
2017-02-22 20:26           ` Leo Famulari [this message]
2017-02-23 16:20             ` ng0
2017-02-23 17:05               ` Leo Famulari
2017-02-23 17:50                 ` ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170222202631.GB28813@jasmine \
    --to=leo@famulari.name \
    --cc=25831-done@debbugs.gnu.org \
    --cc=mthl@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).