From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: bug#25235: Wrapped python programs get native-inputs in PYTHONPATH Date: Mon, 26 Dec 2016 13:26:08 -0500 Message-ID: <20161226182608.GA20609@jasmine> References: <87eg13birp.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87y3zahf8t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLZzH-0000X0-Qu for bug-guix@gnu.org; Mon, 26 Dec 2016 13:27:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLZzC-000705-SW for bug-guix@gnu.org; Mon, 26 Dec 2016 13:27:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:40528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cLZzC-0006zx-PT for bug-guix@gnu.org; Mon, 26 Dec 2016 13:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cLZzC-0004Js-HU for bug-guix@gnu.org; Mon, 26 Dec 2016 13:27:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <87y3zahf8t.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 25235@debbugs.gnu.org On Tue, Dec 20, 2016 at 03:00:50PM +0100, Ludovic Courtès wrote: > Marius Bakke skribis: > > > The 'wrap' phase of 'python-build-system' adds native-inputs to > > PYTHONPATH of the wrapped programs. This causes unnecessary runtime > > dependencies and may create problems when cross-compiling. > > > > Given that all python dependencies are now supposed to be propagated, > > perhaps we can simply remove the wrap phase? It only touches PYTHONPATH. > > We cannot simply remove it: it is meant for packages that provide > standalone programs, such as ‘certbot’. For these, it automatically > wraps bin/* and we don’t even have to have propagated inputs, which is > pretty cool. > > However, you are right that native inputs shouldn’t be there. Probably > we need to add some filtering in the ‘wrap’ phase? While looking at the beets package definition with fresh eyes, I realize that it will surely break once this change is made. So it will make a good test case for this improvement :)