[PATCH] gnu: add dependencies to poppler.

[PATCH] gnu: add dependencies to poppler.

[Cyril Roelandt]

Add libpng and zlib to the inputs.
---
Hello!

This patch is quite simple. It adds both libpng (which  was already available
in Guix) and zlib (which has to be explicitely enabled) to poppler. Note that
zlib is not enabled by default, even if it is found on the system, because it
is "not safe" according to the poppler developers. Andreas, do you know why ?
Maybe we should remove it from the dependencies.

I also listed the dependencies that are not yet satisfied. I think I will take
care of libopenjpeg soon, but it requires cmake, and I'd rather write a cmake
build system first.

Cyril.

 gnu/packages/pdf.scm |   13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 5a9d513..a172414 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -25,6 +25,7 @@
   #:use-module (gnu packages compression)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages libjpeg)
+  #:use-module (gnu packages libpng)
   #:use-module (gnu packages libtiff)
   #:use-module (gnu packages pkg-config))
 
@@ -40,15 +41,25 @@
                      "1rmrspavldlpqi6g76fijcmshy80m0kxd01nc1dmy4id3h4las44"))))
    (build-system gnu-build-system)
    ;; FIXME: more dependencies could  be added
+   ;;  cairo output:       no (requires cairo >= 1.10.0)
+   ;;  qt4 wrapper:        no
+   ;;  glib wrapper:       no (requires cairo output)
+   ;;    introspection:    no
+   ;;  use gtk-doc:        no
+   ;;  use libcurl:        no
+   ;;  use libopenjpeg:    no
    (inputs `(("fontconfig" ,fontconfig)
              ("freetype" ,freetype)
              ("libjpeg-8" ,libjpeg-8)
+             ("libpng" ,libpng)
              ("libtiff" ,libtiff)
              ("pkg-config" ,pkg-config)
              ("zlib" ,zlib)))
    (arguments
     `(#:tests? #f ; no test data provided with the tarball
-      #:configure-flags '("--enable-xpdf-headers"))) ; to install header files
+      #:configure-flags
+       '("--enable-xpdf-headers" ; to install header files
+         "--enable-zlib")))
    (synopsis "Poppler, a pdf rendering library")
    (description
     "Poppler is a PDF rendering library based on the xpdf-3.0 code base.")
-- 
1.7.10.4

Re: [PATCH] gnu: add dependencies to poppler.

[Ludovic Courtès]

Cyril Roelandt <tipecaml@gmail.com> skribis:

> Add libpng and zlib to the inputs.

Looks good to me.

> This patch is quite simple. It adds both libpng (which  was already available
> in Guix) and zlib (which has to be explicitely enabled) to poppler. Note that
> zlib is not enabled by default, even if it is found on the system, because it
> is "not safe" according to the poppler developers. Andreas, do you know why ?
> Maybe we should remove it from the dependencies.

Indeed, it would be good to see what’s meant by “not safe”.

Thanks!

Ludo’.

Re: [PATCH] gnu: add dependencies to poppler.

[Andreas Enge]

Am Sonntag, 24. März 2013 schrieb Cyril Roelandt:
> Note that zlib is not enabled by default, even if it is found
> on the system, because it is "not safe" according to the poppler
> developers. Andreas, do you know why ? Maybe we should remove it from
> the dependencies.

There is some discussion at
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526864
but it is not very conclusive. I would suggest to go ahead and to enable 
the switch for zlib.

Andreas

Re: [PATCH] gnu: add dependencies to poppler.

[Cyril Roelandt]

On 03/28/2013 08:20 PM, Andreas Enge wrote:
> Am Sonntag, 24. März 2013 schrieb Cyril Roelandt:
>> Note that zlib is not enabled by default, even if it is found
>> on the system, because it is "not safe" according to the poppler
>> developers. Andreas, do you know why ? Maybe we should remove it from
>> the dependencies.
>
> There is some discussion at
>     http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526864
> but it is not very conclusive. I would suggest to go ahead and to enable
> the switch for zlib.
>

OK. Do you mind if I push this patch to the xorg branch, then ?

Cyril.

Re: [PATCH] gnu: add dependencies to poppler.

[Andreas Enge]

Am Donnerstag, 28. März 2013 schrieb Cyril Roelandt:
> OK. Do you mind if I push this patch to the xorg branch, then ?

Please do.

Andreas

Re: [PATCH] gnu: add dependencies to poppler.

[Cyril Roelandt]

On 03/28/2013 10:26 PM, Andreas Enge wrote:
> Am Donnerstag, 28. März 2013 schrieb Cyril Roelandt:
>> OK. Do you mind if I push this patch to the xorg branch, then ?
>
> Please do.
>

Pushed!

Cyril.