lsof

lsof

[Andreas Enge]

Hello,

the lsof tarball contains the source in a two-stage process: After 
unpacking, one is left with lsof_4.87_src.tar, which needs to be unpacked 
as well. I tried the following:

   (arguments
    `(#:phases
      (alist-replace
       'unpack
       (lambda* (#:key source name version #:allow-other-keys)
         (let ((unpack (assoc-ref %standard-phases 'unpack))
               (inner (string-append name "_" version "_src.tar")))
           (apply unpack (list #:source source))
           (apply unpack (list #:source inner))))
       %standard-phases)))

But apparently, NAME and VERSION are not passed through as function 
arguments (they are #f). Would it make sense to changes this? Or do you see 
a preferable way of doing the second stage unpacking?

Andreas

Re: lsof

[Ludovic Courtès]

Hi!

Andreas Enge <andreas@enge.fr> skribis:

> the lsof tarball contains the source in a two-stage process: After 
> unpacking, one is left with lsof_4.87_src.tar, which needs to be unpacked 
> as well.

Weird.

> I tried the following:
>
>    (arguments
>     `(#:phases
>       (alist-replace
>        'unpack
>        (lambda* (#:key source name version #:allow-other-keys)
>          (let ((unpack (assoc-ref %standard-phases 'unpack))
>                (inner (string-append name "_" version "_src.tar")))
>            (apply unpack (list #:source source))
>            (apply unpack (list #:source inner))))
>        %standard-phases)))
>
> But apparently, NAME and VERSION are not passed through as function 
> arguments (they are #f). Would it make sense to changes this?

It wouldn’t hurt to pass them, and it may be helpful in cases like this.
So feel free to add it to build-system/gnu.scm and gnu-build-system.scm.

> Or do you see a preferable way of doing the second stage unpacking?

You could use (find-files "." "\\.tar$") to find the tar file, I guess.

Ludo’.

Re: lsof

[Andreas Enge]

Am Sonntag, 3. März 2013 schrieb Ludovic Courtès:
> Andreas Enge <andreas@enge.fr> skribis:
> > the lsof tarball contains the source in a two-stage process: After
> > unpacking, one is left with lsof_4.87_src.tar, which needs to be
> > unpacked as well.
> Weird.

I have seen it before, the tarball contains the source tarball and some 
additional metadata.

> > But apparently, NAME and VERSION are not passed through as function
> > arguments (they are #f). Would it make sense to changes this?
> It wouldn’t hurt to pass them, and it may be helpful in cases like this.
> So feel free to add it to build-system/gnu.scm and gnu-build-system.scm.

This looks complicated after all: One would probably need to repeat NAME 
and VERSION in the arguments section of a package; source seems to be 
passed automatically. And then there is the semantic difference between the 
name of a derivation and the name of a package...

> > Or do you see a preferable way of doing the second stage unpacking?
> You could use (find-files "." "\\.tar$") to find the tar file, I guess.

Thanks, I will rather go for this!

Andreas