From: Andreas Enge <andreas@enge.fr>
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] gnu: Add GNU Prolog. (was: GNU Prolog: configure: error: cannot run /bin/sh ./config.sub)
Date: Thu, 31 Jan 2013 10:22:42 +0100 [thread overview]
Message-ID: <201301311022.42480.andreas@enge.fr> (raw)
In-Reply-To: <87r4l20yad.fsf_-_@karetnikov.org>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
Am Donnerstag, 31. Januar 2013 schrieb Nikita Karetnikov:
> This patch works, but I'd like to simplify it a bit. Is it possible?
There is no need to repeat the phases that do not change in your patch. If
you have a look at icu4c.scm, there is an example using "alist-replace" for
the configure phase that changes; moreover, it just patches a file first
and then calls the normal configure of %standard-phases:
(alist-replace
'configure
(lambda* (#:key #:allow-other-keys #:rest args)
(let ((configure (assoc-ref %standard-phases 'configure)))
(substitute* "configure"
(("`/bin/sh")
(string-append "`" (which "bash"))))
(apply configure args)))
%standard-phases))
Andreas
[-- Attachment #2: Type: text/html, Size: 3597 bytes --]
next prev parent reply other threads:[~2013-01-31 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 21:11 GNU Prolog: configure: error: cannot run /bin/sh ./config.sub Nikita Karetnikov
2013-01-30 21:16 ` Andreas Enge
2013-01-31 5:24 ` [PATCH] gnu: Add GNU Prolog. (was: GNU Prolog: configure: error: cannot run /bin/sh ./config.sub) Nikita Karetnikov
2013-01-31 9:13 ` [PATCH] gnu: Add GNU Prolog Ludovic Courtès
2013-02-01 16:31 ` Nikita Karetnikov
2013-02-01 16:59 ` Ludovic Courtès
2013-01-31 9:22 ` Andreas Enge [this message]
2013-01-30 22:06 ` GNU Prolog: configure: error: cannot run /bin/sh ./config.sub Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301311022.42480.andreas@enge.fr \
--to=andreas@enge.fr \
--cc=bug-guix@gnu.org \
--cc=nikita@karetnikov.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).