[PATCH] gnu build system: enable test-target during the check phase

[PATCH] gnu build system: enable test-target during the check phase

[Andreas Enge]

[-- Attachment #1.1: Type: text/plain, Size: 348 bytes --]

Hello,

the attached patch should go to core-updates, but I would be in favour of 
moving it quickly to the master branch. It enables other make targets for 
the check phase; for instance, openssl needs "make test". The machinery was 
essentially in place, but the test-target variable was not passed to the 
appropriate build function.

Andreas



[-- Attachment #1.2: Type: text/html, Size: 1881 bytes --]

[-- Attachment #2: 0002-gnu-build-system-enable-test-target-during-the-check.patch --]
[-- Type: text/x-patch, Size: 1361 bytes --]

From 80b6c78100ee5a2acedd2276639ea2fa770ec4a5 Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Sat, 29 Dec 2012 21:03:23 +0100
Subject: [PATCH 2/2] gnu build system: enable test-target during the check
 phase

* guix/build-system/gnu.scm: add variable test-target
---
 guix/build-system/gnu.scm |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index 9d94680..53fc474 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -152,6 +152,7 @@ System: GCC, GNU Make, Bash, Coreutils, etc."
                     (out-of-source? #f)
                     (path-exclusions ''())
                     (tests? #t)
+                    (test-target "check")
                     (parallel-build? #t) (parallel-tests? #t)
                     (patch-shebangs? #t)
                     (strip-binaries? #t)
@@ -193,6 +194,7 @@ which could lead to gratuitous input divergence."
                   #:out-of-source? ,out-of-source?
                   #:path-exclusions ,path-exclusions
                   #:tests? ,tests?
+                  #:test-target ,test-target
                   #:parallel-build? ,parallel-build?
                   #:parallel-tests? ,parallel-tests?
                   #:patch-shebangs? ,patch-shebangs?
-- 
1.7.10.4

Re: [PATCH] gnu build system: enable test-target during the check phase

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> the attached patch should go to core-updates, but I would be in favour of 
> moving it quickly to the master branch. It enables other make targets for 
> the check phase; for instance, openssl needs "make test". The machinery was 
> essentially in place, but the test-target variable was not passed to the 
> appropriate build function.

Thanks, I applied it to ‘core-updates’.

I think that branch will have to be merged within one or two weeks
anyway if we are to release in January.  So I think we’ll just merge
this patch then.  WDYT?

Ludo’.

Re: [PATCH] gnu build system: enable test-target during the check phase

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Am Sonntag, 30. Dezember 2012 schrieb Ludovic Courtès:
> Andreas Enge <andreas@enge.fr> skribis:
> > the attached patch should go to core-updates, but I would be in favour
> > of moving it quickly to the master branch. It enables other make
> > targets for the check phase; for instance, openssl needs "make test".
> > The machinery was essentially in place, but the test-target variable
> > was not passed to the appropriate build function.
> 
> Thanks, I applied it to ‘core-updates’.
> 
> I think that branch will have to be merged within one or two weeks
> anyway if we are to release in January.  So I think we’ll just merge
> this patch then.  WDYT?

Whenever you like; I do not mind compiling gcc from time to time...

Andreas

[-- Attachment #2: Type: text/html, Size: 3738 bytes --]