* [PATCH] gnu build system: enable test-target during the check phase
@ 2012-12-29 20:10 Andreas Enge
2012-12-30 21:37 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Enge @ 2012-12-29 20:10 UTC (permalink / raw
To: bug-guix
[-- Attachment #1.1: Type: text/plain, Size: 348 bytes --]
Hello,
the attached patch should go to core-updates, but I would be in favour of
moving it quickly to the master branch. It enables other make targets for
the check phase; for instance, openssl needs "make test". The machinery was
essentially in place, but the test-target variable was not passed to the
appropriate build function.
Andreas
[-- Attachment #1.2: Type: text/html, Size: 1881 bytes --]
[-- Attachment #2: 0002-gnu-build-system-enable-test-target-during-the-check.patch --]
[-- Type: text/x-patch, Size: 1361 bytes --]
From 80b6c78100ee5a2acedd2276639ea2fa770ec4a5 Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Sat, 29 Dec 2012 21:03:23 +0100
Subject: [PATCH 2/2] gnu build system: enable test-target during the check
phase
* guix/build-system/gnu.scm: add variable test-target
---
guix/build-system/gnu.scm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index 9d94680..53fc474 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -152,6 +152,7 @@ System: GCC, GNU Make, Bash, Coreutils, etc."
(out-of-source? #f)
(path-exclusions ''())
(tests? #t)
+ (test-target "check")
(parallel-build? #t) (parallel-tests? #t)
(patch-shebangs? #t)
(strip-binaries? #t)
@@ -193,6 +194,7 @@ which could lead to gratuitous input divergence."
#:out-of-source? ,out-of-source?
#:path-exclusions ,path-exclusions
#:tests? ,tests?
+ #:test-target ,test-target
#:parallel-build? ,parallel-build?
#:parallel-tests? ,parallel-tests?
#:patch-shebangs? ,patch-shebangs?
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gnu build system: enable test-target during the check phase
2012-12-29 20:10 [PATCH] gnu build system: enable test-target during the check phase Andreas Enge
@ 2012-12-30 21:37 ` Ludovic Courtès
2013-01-01 13:59 ` Andreas Enge
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2012-12-30 21:37 UTC (permalink / raw
To: Andreas Enge; +Cc: bug-guix
Andreas Enge <andreas@enge.fr> skribis:
> the attached patch should go to core-updates, but I would be in favour of
> moving it quickly to the master branch. It enables other make targets for
> the check phase; for instance, openssl needs "make test". The machinery was
> essentially in place, but the test-target variable was not passed to the
> appropriate build function.
Thanks, I applied it to ‘core-updates’.
I think that branch will have to be merged within one or two weeks
anyway if we are to release in January. So I think we’ll just merge
this patch then. WDYT?
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-01 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-29 20:10 [PATCH] gnu build system: enable test-target during the check phase Andreas Enge
2012-12-30 21:37 ` Ludovic Courtès
2013-01-01 13:59 ` Andreas Enge
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).