From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: [PATCH] gnu build system: enable test-target during the check phase Date: Sat, 29 Dec 2012 21:10:31 +0100 Message-ID: <201212292110.31400.andreas@enge.fr> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_3403QE5PddMZzWn" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:57416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tp2jx-00048g-Oa for bug-guix@gnu.org; Sat, 29 Dec 2012 15:10:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tp2ju-0004kI-UO for bug-guix@gnu.org; Sat, 29 Dec 2012 15:10:41 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:65413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tp2ju-0004k8-KV for bug-guix@gnu.org; Sat, 29 Dec 2012 15:10:38 -0500 List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: bug-guix@gnu.org --Boundary-00=_3403QE5PddMZzWn Content-Type: multipart/alternative; boundary="Boundary-01=_3403QEFb7xJNIbw" Content-Transfer-Encoding: 7bit --Boundary-01=_3403QEFb7xJNIbw Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello, the attached patch should go to core-updates, but I would be in favour of moving it quickly to the master branch. It enables other make targets for the check phase; for instance, openssl needs "make test". The machinery was essentially in place, but the test-target variable was not passed to the appropriate build function. Andreas --Boundary-01=_3403QEFb7xJNIbw Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: 7bit

Hello,

 

the attached patch should go to core-updates, but I would be in favour of moving it quickly to the master branch. It enables other make targets for the check phase; for instance, openssl needs "make test". The machinery was essentially in place, but the test-target variable was not passed to the appropriate build function.

 

Andreas

 

 

 

--Boundary-01=_3403QEFb7xJNIbw-- --Boundary-00=_3403QE5PddMZzWn Content-Type: text/x-patch; charset="UTF-8"; name="0002-gnu-build-system-enable-test-target-during-the-check.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0002-gnu-build-system-enable-test-target-during-the-check.patch" =46rom 80b6c78100ee5a2acedd2276639ea2fa770ec4a5 Mon Sep 17 00:00:00 2001 =46rom: Andreas Enge Date: Sat, 29 Dec 2012 21:03:23 +0100 Subject: [PATCH 2/2] gnu build system: enable test-target during the check phase * guix/build-system/gnu.scm: add variable test-target =2D-- guix/build-system/gnu.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm index 9d94680..53fc474 100644 =2D-- a/guix/build-system/gnu.scm +++ b/guix/build-system/gnu.scm @@ -152,6 +152,7 @@ System: GCC, GNU Make, Bash, Coreutils, etc." (out-of-source? #f) (path-exclusions ''()) (tests? #t) + (test-target "check") (parallel-build? #t) (parallel-tests? #t) (patch-shebangs? #t) (strip-binaries? #t) @@ -193,6 +194,7 @@ which could lead to gratuitous input divergence." #:out-of-source? ,out-of-source? #:path-exclusions ,path-exclusions #:tests? ,tests? + #:test-target ,test-target #:parallel-build? ,parallel-build? #:parallel-tests? ,parallel-tests? #:patch-shebangs? ,patch-shebangs? =2D-=20 1.7.10.4 --Boundary-00=_3403QE5PddMZzWn--