unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: bug-guix@gnu.org
Subject: [PATCH] gnu build system: enable test-target during the check  phase
Date: Sat, 29 Dec 2012 21:10:31 +0100	[thread overview]
Message-ID: <201212292110.31400.andreas@enge.fr> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 348 bytes --]

Hello,

the attached patch should go to core-updates, but I would be in favour of 
moving it quickly to the master branch. It enables other make targets for 
the check phase; for instance, openssl needs "make test". The machinery was 
essentially in place, but the test-target variable was not passed to the 
appropriate build function.

Andreas



[-- Attachment #1.2: Type: text/html, Size: 1881 bytes --]

[-- Attachment #2: 0002-gnu-build-system-enable-test-target-during-the-check.patch --]
[-- Type: text/x-patch, Size: 1361 bytes --]

From 80b6c78100ee5a2acedd2276639ea2fa770ec4a5 Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Sat, 29 Dec 2012 21:03:23 +0100
Subject: [PATCH 2/2] gnu build system: enable test-target during the check
 phase

* guix/build-system/gnu.scm: add variable test-target
---
 guix/build-system/gnu.scm |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index 9d94680..53fc474 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -152,6 +152,7 @@ System: GCC, GNU Make, Bash, Coreutils, etc."
                     (out-of-source? #f)
                     (path-exclusions ''())
                     (tests? #t)
+                    (test-target "check")
                     (parallel-build? #t) (parallel-tests? #t)
                     (patch-shebangs? #t)
                     (strip-binaries? #t)
@@ -193,6 +194,7 @@ which could lead to gratuitous input divergence."
                   #:out-of-source? ,out-of-source?
                   #:path-exclusions ,path-exclusions
                   #:tests? ,tests?
+                  #:test-target ,test-target
                   #:parallel-build? ,parallel-build?
                   #:parallel-tests? ,parallel-tests?
                   #:patch-shebangs? ,patch-shebangs?
-- 
1.7.10.4


             reply	other threads:[~2012-12-29 20:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-29 20:10 Andreas Enge [this message]
2012-12-30 21:37 ` [PATCH] gnu build system: enable test-target during the check phase Ludovic Courtès
2013-01-01 13:59   ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201212292110.31400.andreas@enge.fr \
    --to=andreas@enge.fr \
    --cc=bug-guix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).